Received: by 2002:a05:6a10:eb0a:0:0:0:0 with SMTP id hx10csp3393394pxb; Tue, 8 Mar 2022 18:22:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJxbQtJyyTbDyzTUZywLGjx+QVh/ZSWG7fOWqv9gKzORTg4djjOPz9I1b7nDmvcNWDoX9SXj X-Received: by 2002:a05:6a00:a1d:b0:4f6:5051:6183 with SMTP id p29-20020a056a000a1d00b004f650516183mr21460908pfh.42.1646792559209; Tue, 08 Mar 2022 18:22:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646792559; cv=none; d=google.com; s=arc-20160816; b=mxg8c8yzgGGLxkCkqsCzmCPk7oiiadI0kamoT9hPl3TOQkQWkKJjcgfJyDOYzWJOYQ q8D2JzRC2EBTGlqGNnCrSg8hLI0B29/KAvFZUZIGvAL610DzC6DgY4UBNXOdtiGDjv3X GgPTguMWtf4U4URkPqIPi+sxZXf3xaaLQMmeehNuoHfTaYVMl8tfSUbfG2+rB30DXtuq f01wnNpaPhfony9ibyZmH7ZFyW33XZ6iWjKb341lurlm696oHV3X2E3VEu4y2c2J+vX0 cWodyyACGBYSWMb8sHtCgJk3gwEeSX+2G/kmzHwhQrSQuHhHGkxqIFRU8jwkDhu5qh/N HBBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=YlCM3z0vt4xJuaDGP/qHthWWjPQ/iDmyI70ur1aJgMA=; b=pPs9Dblx/mngHVL9mS1SOrHwA1tNo/DrZAGZ58bhIytHYHzQ6HG21yYjWSyTnZAYVr b92WsXyGN+MGLvK6LDl5In3LzFVTX2bf+myI/T8ZijnjopqXBAzGPatsexdpgsx9v9k7 CcjNyc+jGb7U6+P5oH+J2ZCu/XZ5pLuAG1sdd63qSY2kJ15p48cybgixB3+N7MZgxYRf +YyCuoCsA01aoaxiWX0sxSoCPwKT9Gl10ZSFCluTiqeWOGONmkMhakVYBhTkIAnDI9mD UD8sFOxkc5/p3uZ9QzKvW1aF4c/LC8I/EDIJ020uDwH6DwqwsvZuJrkh0z8Jv74btQ10 DcYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=ZeO298VT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id y10-20020a17090a474a00b001bedcbca409si721557pjg.135.2022.03.08.18.22.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 18:22:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=ZeO298VT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 447953527E; Tue, 8 Mar 2022 17:23:49 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230284AbiCIBXu (ORCPT + 99 others); Tue, 8 Mar 2022 20:23:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230406AbiCIBWo (ORCPT ); Tue, 8 Mar 2022 20:22:44 -0500 Received: from mslow1.mail.gandi.net (mslow1.mail.gandi.net [217.70.178.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8328FB54D6; Tue, 8 Mar 2022 17:19:57 -0800 (PST) Received: from relay6-d.mail.gandi.net (unknown [217.70.183.198]) by mslow1.mail.gandi.net (Postfix) with ESMTP id 82E6DC86D9; Tue, 8 Mar 2022 23:32:09 +0000 (UTC) Received: (Authenticated sender: alexandre.belloni@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 03765C0003; Tue, 8 Mar 2022 23:31:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1646782289; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YlCM3z0vt4xJuaDGP/qHthWWjPQ/iDmyI70ur1aJgMA=; b=ZeO298VTaZW4ZKPS+hbL1WnQkoxuOjCmgXkCIu5l9+mlTl+WzqybFHz15IKUn6dhK/iEJx 0RaZ+8+OOFTKo3+f4Kz1ZV4FC53HEwpC0rxmE4DTJiAfyRrmI4p0TyUedzsaJZLbW6wlAi PnHqquyAUoxVVoiX3PuKWCcFC7I26/boPZUnZI1rtrI7qzur9Kco4ZsLM8plhy1jCX5xcF QEU4vwldXDjJxoE7C7QivEi33hy0F/2uARucukhVeB1Eio82925hJnBiM/n1r4+IpV0f8v IgjNOagNWFZmSZ2zcd7pgSA3yUMKqKB5sAQ6zB7mocPxCz0tjFqpqyOwrx5rQw== From: Alexandre Belloni To: Jiasheng Jiang , a.zummo@towertech.it Cc: Alexandre Belloni , linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, patches@opensource.cirrus.com Subject: Re: [PATCH] rtc: rtc-wm8350: Handle error for wm8350_register_irq Date: Wed, 9 Mar 2022 00:31:25 +0100 Message-Id: <164678227866.114704.3399068049794620806.b4-ty@bootlin.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220303085030.291793-1-jiasheng@iscas.ac.cn> References: <20220303085030.291793-1-jiasheng@iscas.ac.cn> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 3 Mar 2022 16:50:30 +0800, Jiasheng Jiang wrote: > As the potential failure of the wm8350_register_irq(), > it should be better to check it and return error if fails. > Also, it need not free 'wm_rtc->rtc' since it will be freed > automatically. > > Applied, thanks! [1/1] rtc: rtc-wm8350: Handle error for wm8350_register_irq commit: 5e086367298dfaa1617885e797c8a58873365f03 Best regards, -- Alexandre Belloni