Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp80809pxp; Tue, 8 Mar 2022 21:03:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJxRS2r5citLMGdFQx32EC0In4RVGT52Z+WZ1nFtoc7mS7fosHiQC3PLFO38Z2to6U1IebVx X-Received: by 2002:a17:90b:1c83:b0:1b9:caa:8230 with SMTP id oo3-20020a17090b1c8300b001b90caa8230mr8518246pjb.26.1646802183503; Tue, 08 Mar 2022 21:03:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646802183; cv=none; d=google.com; s=arc-20160816; b=IZeY+RJi74/olr+DhiWt8rAWxU46j9ufeY4HpbZatiuVUcTG2rEOApdI/I+uA4TlKZ I38PAZMuPL165HF70hk5fEg0qPJtcIzgDXa6MO00k/WIfE0carq3t8yVupCzqaLa6vNT dtIhGri20IK8Cpcx4NHKSXmWOfb0IcF9moI07eLQc79lHMBNDYzXmiaFOf00ROhU7RCu ucaKVLoYzilqYl3dZuXMNsPiDxJDmqcMy+5+EUlbYc0ghMa3EvlGOqe/JgJZaS+T+Qqb Y/948bSjUVL1lXxdCZWIRXWO8Jaek+SOF03dsaQarLrwMfG8a0bhroAmf+zrNdCvWnTH 2w9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=LO/DR14INuzeodgtdGcWr4d8/6gfr0CwS/tZ2Wuz67s=; b=zWgkSJCCNlrj9Goc16G09z2zz/tpvGh9fI59fYo6qIpokvst7gHN10BTb9IUfsxh5T tiD1Y08ABdC8aNPQhbs7YEgpN6xXbIqDb8tWV/7g1/G2/YMXQD30m2XajPkgd6i8dNR5 YBagYM3uARon2dke2lwEzFN00POjbISYz2HDLcob9whb6Zt7ycdN4rRBrFIIri11uvXH n6QukAiyEPrMkaLbFTLzk0pIQsWrH03O6uMztzc+2Vu/U81LVuWC+HTxlwPk5W7f3J8Z EFduMvlLAxfYOVRnC7JEuAqBGsKZPJS5lKkubGK71P+Xz0KZUBXMe9vUMpoLHwb19zjJ DXyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ru9BR2Nm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a22-20020a056a000c9600b004f1126f19b0si803120pfv.349.2022.03.08.21.02.16; Tue, 08 Mar 2022 21:03:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ru9BR2Nm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229541AbiCIFCd (ORCPT + 99 others); Wed, 9 Mar 2022 00:02:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229460AbiCIFC3 (ORCPT ); Wed, 9 Mar 2022 00:02:29 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FB9610BBC9; Tue, 8 Mar 2022 21:01:31 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DDCD66189F; Wed, 9 Mar 2022 05:01:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DAD7EC340E8; Wed, 9 Mar 2022 05:01:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646802090; bh=u9AmhLjdiMXokE3skjPX/ILUo3bIn8slqzpW3UOIBlA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Ru9BR2NmSn2/u7Ecwepa5h03WaDRzPvnoHxzDKws3BGyKBx19D8fsYu3cUwUeVGSU WFLjc5s2ikPFp2FimuYhyt3tmbdWG+yKEQC24QGJeiZA8TbZerfqKyYczV5swN3/16 Ka1Mf3l99L4NnOlBo3M2KOk5ZLOtm70aZavnFUMdCuESwsLC/ffBeEz6p1BKBtzQCO NGsj2TPRb+KOA5UO5fkz5h0QPRJvW5EogZ+z41LK5HyKoGoKk5j1WoYufKaKfZDke2 5w83RohUFDDJLuMGkI1HCmDShSJ558YDfiaBjRcD3l5Zw2lVDJnNW+8DCpOWd/r8do yJzLbqG1GyPCw== Message-ID: Date: Tue, 8 Mar 2022 22:01:27 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH] net: ipv6: fix invalid alloclen in __ip6_append_data Content-Language: en-US To: Tadeusz Struk , David Laight , "davem@davemloft.net" Cc: Hideaki YOSHIFUJI , Jakub Kicinski , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , "netdev@vger.kernel.org" , "bpf@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , "syzbot+e223cf47ec8ae183f2a0@syzkaller.appspotmail.com" References: <20220308000146.534935-1-tadeusz.struk@linaro.org> <14626165dad64bbaabed58ba7d59e523@AcuMS.aculab.com> <6155b68c-161b-0745-b303-f7e037b56e28@linaro.org> <66463e26-8564-9f58-ce41-9a2843891d1a@kernel.org> <45522c89-a3b4-4b98-232b-9c69470124a3@linaro.org> From: David Ahern In-Reply-To: <45522c89-a3b4-4b98-232b-9c69470124a3@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/8/22 12:46 PM, Tadeusz Struk wrote: > That fails in the same way: > > skbuff: skb_over_panic: text:ffffffff83e7b48b len:65575 put:65575 > head:ffff888101f8a000 data:ffff888101f8a088 tail:0x100af end:0x6c0 > dev: > ------------[ cut here ]------------ > kernel BUG at net/core/skbuff.c:113! > invalid opcode: 0000 [#1] PREEMPT SMP KASAN > CPU: 0 PID: 1852 Comm: repro Not tainted > 5.17.0-rc7-00020-gea4424be1688-dirty #19 > Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.15.0-1.fc35 > RIP: 0010:skb_panic+0x173/0x175 > > I'm not sure how it supposed to help since it doesn't change the > alloclen at all. alloclen is a function of fraglen and fraglen is a function of datalen.