Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <05667284-42f7-0df2-8fa0-463ad6ad9601@molgen.mpg.de>
Date:   Wed, 9 Mar 2022 09:12:32 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.2
Subject: Re: [PATCH v2 0/6] hwmon: (nct6775) Convert to regmap, add i2c
 support
Content-Language: en-US
To:     Zev Weiss <zev@bewilderbeest.net>
Cc:     Guenter Roeck <linux@roeck-us.net>,
        Jean Delvare <jdelvare@suse.com>, linux-hwmon@vger.kernel.org,
        devicetree@vger.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
        openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org,
        Oleksandr Natalenko <oleksandr@natalenko.name>,
        Rob Herring <robh+dt@kernel.org>,
        Renze Nicolai <renze@rnplus.nl>
References: <20220309005047.5107-1-zev@bewilderbeest.net>
From:   Paul Menzel <pmenzel@molgen.mpg.de>
In-Reply-To: <20220309005047.5107-1-zev@bewilderbeest.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Dear Zev,


Am 09.03.22 um 01:50 schrieb Zev Weiss:

> This is v2 of my patches to add i2c support to the nct6775 driver.
> 
> Changes since v1 [0]:
>   - Added preparatory patch converting driver to regmap API [Guenter]
>   - Replaced ENOSPC with ENOBUFS and removed WARN_ON() in
>     nct6775_add_attr_group() [Guenter]
>   - Added dedicated symbol namespace [Guenter]
>   - Removed nct6775_write_temp() and nct6775_update_device() symbol
>     exports [Guenter]
>   - Reordered patches to put dt-bindings patch first [Krzysztof]
> 
> The nct6775-platform and nct6775-i2c drivers have both been tested on
> the NCT6779D in an ASRock ROMED8HM3 system and the NCT6798 [1] in an
> ASRock X570-D4U (the latter thanks to Renze, CCed); both seem to work
> as expected on both systems.  I don't have access to any asuswmi
> hardware, so testing of the nct6775-platform driver on that to ensure
> it doesn't break there would be appreciated (Oleksandr, perhaps?).

I have an ASUS F2A85-M PRO with that Super I/O. (It’s running coreboot 
right now, but I can test with the proprietary vendor firmware, if you 
tell me what and how I can test this.


Kind regards,

Paul


> [0] https://lore.kernel.org/linux-hwmon/20220226133047.6226-1-zev@bewilderbeest.net/
> [1] Though it's physically labeled (mislabeled?) as an NCT6796, for
>      what that's worth.
> 
> A slightly edited version of the previous cover letter follows:

[…]