Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp212213pxp; Wed, 9 Mar 2022 01:06:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJx+GMTH5OASm9NzuJhOa4nanMT6ornx6qiktffkdkqBPrX9mF4M0WnD3R/6Lnd9dV99NKkF X-Received: by 2002:a17:902:c611:b0:151:9522:8962 with SMTP id r17-20020a170902c61100b0015195228962mr21971931plr.48.1646816772231; Wed, 09 Mar 2022 01:06:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646816772; cv=none; d=google.com; s=arc-20160816; b=dym66WloCNUKOg6e7LdqP7qgzWieWIsIQGa2+46fewwJTFMXKanzfzmxNIVxOsDeNT s+JZ/PfP44A2+86xoAjx5+gVEAtlzU8ASdApFVEXf6rvfJbCbYIhr6L997JPedaJ23WP CIdKfFbxmY6lPL+JlereBgR0RvK7NZfWmvp4X8xjMwrdV0wWLHr7IpnmzsPrHnXfHo6j y3Xsddr6C4M2PG9C8ewxxgzGZ5DCQVzDg0NUTV2+fvRtRcqCLyyZ9dWcW1nQsxNl2UEt 4Jm8WuJbFEcSNu7AeatVVqxxBMBlcyXHovv/Ku5VjnOg5FZ/dfu968XkHjeJt+k0VByj Kc8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date:dkim-signature:dkim-signature; bh=q4AJu/wysJHmIswvQXSaX+yqN3X7O/Pe+3NXzpiDTA8=; b=lyIaasAdD8sZ/wsJfXdBELdwjnp5OQH/2Wo83q4stj2zE8h4PD/Zd/OMSNKM+7CYun +7TU/zsYe+gHRrXlaYXS9sH1OxEsxA5Q0zhrbU/mR3TJPEDe3vgWBpA8jeNUEJMZwPS7 XqQpRufeYETxQWG7DNcOQAlfB0TTxCz0VgJZ0ZrpRahFjYYVzLtcD1QZ2Ydt7WplLOd+ 5UWytXkb2qnGe82NuOrx/qJqnE7vXYI80PaNmWqjiQzNAjpMlWhyB2quK9UlX8qlkK0l xFryXP9cDHqC9ZDHyyCij8LlApdAN8z9FHZ1ibY10b1zpChyiDimN1jXRZysi53HVmyZ vIuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=Y0Fzdvy7; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=mypzG7T8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lp8-20020a17090b4a8800b001bd14e01f90si1638520pjb.126.2022.03.09.01.05.54; Wed, 09 Mar 2022 01:06:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=Y0Fzdvy7; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=mypzG7T8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231616AbiCII7p (ORCPT + 99 others); Wed, 9 Mar 2022 03:59:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230490AbiCII7o (ORCPT ); Wed, 9 Mar 2022 03:59:44 -0500 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D4533CFC1 for ; Wed, 9 Mar 2022 00:58:46 -0800 (PST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id CF83A210FF; Wed, 9 Mar 2022 08:58:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1646816324; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q4AJu/wysJHmIswvQXSaX+yqN3X7O/Pe+3NXzpiDTA8=; b=Y0Fzdvy7p16kKlow8GqWKUk8k/nyRyZ4G2StnJyAv0PV0SYyA5cAV+wuyOxewuQWZu/eij p8li1z/HvoPnTA8SzB9OxKeViJH+3SgKCl3GBzTtC52A4mWT4WNZ+BNYNeIFNw2RqwMEZ0 5uBFcBsJ8oaqfx7eP/kzghnysfrji30= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1646816324; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q4AJu/wysJHmIswvQXSaX+yqN3X7O/Pe+3NXzpiDTA8=; b=mypzG7T8IMXnyC0Gytkq2D053hqMmCQGhUOWuF19SI2gnqtnE61vtEDcSYEtD6VxYmf5NQ N3ro8Qpfoqp+gSBg== Received: from pobox.suse.cz (pobox.suse.cz [10.100.2.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 409EAA3B84; Wed, 9 Mar 2022 08:58:44 +0000 (UTC) Date: Wed, 9 Mar 2022 09:58:44 +0100 (CET) From: Miroslav Benes To: Peter Zijlstra cc: x86@kernel.org, joao@overdrivepizza.com, hjl.tools@gmail.com, jpoimboe@redhat.com, andrew.cooper3@citrix.com, linux-kernel@vger.kernel.org, ndesaulniers@google.com, keescook@chromium.org, samitolvanen@google.com, mark.rutland@arm.com, alyssa.milburn@intel.com, rostedt@goodmis.org, mhiramat@kernel.org, alexei.starovoitov@gmail.com Subject: Re: [PATCH v4 19/45] x86/livepatch: Validate __fentry__ location In-Reply-To: <20220308154318.285971256@infradead.org> Message-ID: References: <20220308153011.021123062@infradead.org> <20220308154318.285971256@infradead.org> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 8 Mar 2022, Peter Zijlstra wrote: > Currently livepatch assumes __fentry__ lives at func+0, which is most > likely untrue with IBT on. Instead make it use ftrace_location() by > default which both validates and finds the actual ip if there is any > in the same symbol. > > Suggested-by: Josh Poimboeuf > Signed-off-by: Peter Zijlstra (Intel) Acked-by: Miroslav Benes M