Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp227511pxp; Wed, 9 Mar 2022 01:28:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJziz5fy7qX8+8J8p6gVXiLaWEo7DamDOHEgRCcmiRo23SQCU6Xq/tFc6FmHj5bYgebSnKF8 X-Received: by 2002:a05:6402:4406:b0:410:e24f:91fd with SMTP id y6-20020a056402440600b00410e24f91fdmr1965088eda.99.1646818104547; Wed, 09 Mar 2022 01:28:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646818104; cv=none; d=google.com; s=arc-20160816; b=SkrQTdjGoi2vO29lQlkeZ2NjI/vqZxd6jD0j3Kvqeb/+dDbCpxQ87sGqURZ6O6UvLh Ey3+LOBt04QyPGuVt7f7j5WRd+9GEM9zpO3/qWSAnRFkvE3fEq07vx0LUnVI5L2CGTVd QX8hGqD7U6MKlMDgjcqYF7qQpSbVCAx4wW3z2f7Okibl0jHSNGLap6c0Z2jyB/pZnIfa KtLkVhHdEw+Tp9nbQWdjVTXLzqD7lUWStcRKl0/IzVBeDmVIsbEHroaSUIC/THq3x8b1 ufO1i+HsQZAsXIPUFxKEnOReErfh2mpV8GOKrVldEtWAz309fR7xV765meNC9w46ndws 8VDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=oajkNxPEtUGCoRw60Kh+hjbhxD8g39tgk6M9/aAms/4=; b=chb70Xxiy8UDXq1AccJ96eKwoi4IOErgcUDryLYkJc1kUrA0TlnQsT5PEYA+tFzvzK MNNXqtC6mxeVCfce9KF/cXP9LgRz9wCjGuiiZQHIRPetBuqJOLJCP3tVZjKjj9Jhyjml Y0nKu7qNDPXW3t7RM5UtsYOhhb1ssjCkQ+Z5No81k0xX/A+xs8Jeb53Qxx1emT0jek1Q bjEINuJaQT91SH920hh0qd+REszJDcToP5O9bhG4AALmnTBQUbQhv5jRFgFtX2h8Jko4 Il9wiUk1S0hnZibaqnut9pTV0as68UOeFXE21woLPY3VLf64fugPKtYn49t4Nuvgh22n 4eIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=B5h5iaT6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p1-20020a1709066a8100b006cfea600277si789543ejr.819.2022.03.09.01.28.01; Wed, 09 Mar 2022 01:28:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=B5h5iaT6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231971AbiCIJNK (ORCPT + 99 others); Wed, 9 Mar 2022 04:13:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231877AbiCIJMx (ORCPT ); Wed, 9 Mar 2022 04:12:53 -0500 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA85616BFB3; Wed, 9 Mar 2022 01:11:55 -0800 (PST) Received: by mail-pj1-x1036.google.com with SMTP id mg21-20020a17090b371500b001bef9e4657cso4710905pjb.0; Wed, 09 Mar 2022 01:11:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=oajkNxPEtUGCoRw60Kh+hjbhxD8g39tgk6M9/aAms/4=; b=B5h5iaT6jAgMvBj4+b8Ifxl1guCDtK2WJTNiON1iyyzH3SZcfdgdbwzZfcFHlQX7CV fJYlLhfpNJUCXfYpEy78XSpNVl9WUsRyKSqXnldVx9rdsJnL8lnQQ7zdAV1IEa7Aadnb F6jLbFCPZOJMDjIefnIuHD68FoIHcaH1Gpev+5EiDfZZQIbJfksrG4G9Occ4nY9yF42Z U+DSc2mt9ywU4ddByvRC1avu9d51Y/oY3+2iU/iDnl1gOnyFm1M/Nz00Al1l6I36djjh EXhBRnAvanWJzxGkrwhiX1ah4BNmQ93ZHmBJGFKcP+/6pXPts1O91JM+J5f8oDC0R2Fa FMfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=oajkNxPEtUGCoRw60Kh+hjbhxD8g39tgk6M9/aAms/4=; b=iLpT6mmGX1aT715btAnUIPqEVgfVUrjGVZDh1gcjEIHf2jISMDU3D96q5krKT8pNhX LjtBIVpRfUWh7mGSkVSpHCmKLq7mUPk0aAo5hSQAY88Rz9N1bTEl0udxOfHlqFdcQpC0 UlqaDczhbPEek2fvQ/sLbSa3wuKQRN9q8/Gg6OSdeLQ0C9XeuesJ0hE6haovLTzOn3Z7 m0+mD3qrKI+dgmUfIO/x1RevCq1z4uFr8SgbU+iZUHFcTvu5LEpEvGLwKZoZgdGnmD91 au/Hcc+LIF2TJp/TnOAwYQ11bDbAhfcbrtzl2rX0+pwlp42copLxGEzzPL4Y+lX9rhkF ibDA== X-Gm-Message-State: AOAM532Lms8ysFsqw2MSwUfu+LJxnaxCgbjNxKGclZgo4e+MbaMXH4qL jwEhIQlV5gStH39Ajas2Zok= X-Received: by 2002:a17:90b:3a81:b0:1bf:9a17:99b7 with SMTP id om1-20020a17090b3a8100b001bf9a1799b7mr5616183pjb.68.1646817115167; Wed, 09 Mar 2022 01:11:55 -0800 (PST) Received: from localhost.localdomain ([159.226.95.43]) by smtp.googlemail.com with ESMTPSA id d10-20020a63360a000000b0037947abe4bbsm1681514pga.34.2022.03.09.01.11.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Mar 2022 01:11:54 -0800 (PST) From: Miaoqian Lin To: Claudiu Manoil , "David S. Miller" , Jakub Kicinski , Yangbo Lu , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] ethtool: Fix refcount leak in gfar_get_ts_info Date: Wed, 9 Mar 2022 09:11:49 +0000 Message-Id: <20220309091149.775-1-linmq006@gmail.com> X-Mailer: git-send-email 2.17.1 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The of_find_compatible_node() function returns a node pointer with refcount incremented, We should use of_node_put() on it when done Add the missing of_node_put() to release the refcount. Fixes: 7349a74ea75c ("net: ethernet: gianfar_ethtool: get phc index through drvdata") Signed-off-by: Miaoqian Lin --- drivers/net/ethernet/freescale/gianfar_ethtool.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/freescale/gianfar_ethtool.c b/drivers/net/ethernet/freescale/gianfar_ethtool.c index ff756265d58f..9a2c16d69e2c 100644 --- a/drivers/net/ethernet/freescale/gianfar_ethtool.c +++ b/drivers/net/ethernet/freescale/gianfar_ethtool.c @@ -1464,6 +1464,7 @@ static int gfar_get_ts_info(struct net_device *dev, ptp_node = of_find_compatible_node(NULL, NULL, "fsl,etsec-ptp"); if (ptp_node) { ptp_dev = of_find_device_by_node(ptp_node); + of_node_put(ptp_node); if (ptp_dev) ptp = platform_get_drvdata(ptp_dev); } -- 2.17.1