Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <695e2818-d924-a535-1b27-58c4de4a8452@nvidia.com>
Date:   Wed, 9 Mar 2022 09:00:23 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v4] arm64: tegra: Add QSPI controllers on Tegra234
Content-Language: en-US
To:     Krishna Yarlagadda <kyarlagadda@nvidia.com>, broonie@kernel.org,
        thierry.reding@gmail.com, linux-spi@vger.kernel.org,
        linux-tegra@vger.kernel.org, ashishsingha@nvidia.com
Cc:     skomatineni@nvidia.com, ldewangan@nvidia.com, robh+dt@kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        p.zabel@pengutronix.de
References: <20220308183026.66394-1-kyarlagadda@nvidia.com>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <20220308183026.66394-1-kyarlagadda@nvidia.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RjJwRXhORjZ3Mk1EQm9WZVl3aGRRZXZSNlY3TERvUUpyNzV6dURZcWJrUURR?=
 =?utf-8?B?NzNkQnM3TmZBT2hZbjVEWFFVL2FpVjhBV3R2ZGhPRlBBWE01aDlVYWZTblIr?=
 =?utf-8?B?aUNPVU5iRDlKSzdsT21WTnZNS0ZQbmJMRlZSVkkyTVJUZEdTYVVQOG0rRUVm?=
 =?utf-8?B?V2tENnFCUWh2YlJVNTA3NVFDcThiQ1hvRlFuZjdHZ1ZyUVRFTmlPcnYxY095?=
 =?utf-8?B?eG52MURlYlhUd1lMb2VxTVJDT2I4cVpxUW5HUlZqU2EvTnlCWlA5YXAwWkpr?=
 =?utf-8?B?MFFSU2laOGw4UGpRSFdJVlNyaklsMkJ0d2dwVkowT280ZElPWkNzdE0wZ2t1?=
 =?utf-8?B?dkdBTGZITDMzTXg4RDZFUTZ2SmJzYWtOQXFabjZlVFFpYkRZaXE4S0J4L0Zn?=
 =?utf-8?B?bFVCeVQzbFp6OG9lWklRQWZsMmhVM2d5L0pNZVJER2JPSWVHVytKdUJwb1l1?=
 =?utf-8?B?NitGa0RIcHVqNGkxVUNRSnlvNEVJVnZtV21yL3FwcXVUS255djlXOEZUaHNB?=
 =?utf-8?B?WnlKZnRTQXBtczR6bGZxYjczMEpOQ1Y0c3kyajRXNC9aNlJDUlBXUXBveFpE?=
 =?utf-8?B?enp6ajdjU0RzMEc3dVJnMVdha1hjR1hvUGs3TzZtaXVXRmo4WlhJQkRpWFBM?=
 =?utf-8?B?TS85dk95dlFRRmhlZGdKU3VWVncvN1FhOTZ4SGtyTHFhM3hnTjVTbk44WFRN?=
 =?utf-8?B?bCt4dEFaOW5pQmxDS1ZCSkZCZ3E5dDh3SmdncHM4ZzQ5VlZobWtROGV3MHdv?=
 =?utf-8?B?NUhjK1Nsb1FkL05kMytrY21GWVNna2tCVUhnOXFKcVAxY0ZYSUxyazhtWHVr?=
 =?utf-8?B?azZTd09FbSt0djNtbmlQZlExR0g4bVlwVjBlUndPSDlQcUR0c2ZEaUs5NExz?=
 =?utf-8?B?dHRlZHhqNC8vNmhzamU2YjV3b1RFQTd2bmgrVVp4cTVDaDYwQ2hlb3hZRERY?=
 =?utf-8?B?eCtQQUxoVysrKzdzcVdRNjU0OWZ1MkpCY3N4U05EVkZlYTFUam16R2FZaGdD?=
 =?utf-8?B?ckFZVm9tRVY4cTcyYk9pcXczUUwrVmlqcUtTSTZvbFN0RDNuaWdyRXFhQ3pp?=
 =?utf-8?B?V1cwTFNjUlV3TWt5clFHNFNrRS96UjM2cElDbzZLSlFyN2hpN0VOK01LelFT?=
 =?utf-8?B?SDFzQkZLNEFKVElHYTdEK2Y4UkpQVFlqcHcyZTVWSWZ3Smd2WmQ3dEdlM0ND?=
 =?utf-8?B?WXBUWnJMN2lqMnNxRUZwakNVRUpMc2tGWWZlbktDUEl0SHc0VFNPRFJoMFJs?=
 =?utf-8?B?Z1pqL09pZEIxWmdDSThKZE4rWGtRV1d3WVdyM3RJT3I4TWRpMnFBQUJrTGNt?=
 =?utf-8?B?NCtwOHU2NGFUeWs4NG1NankxTEUreGJJdFFpMnJSNkRyazVNWXpXZk1xNzQ3?=
 =?utf-8?B?dzVKZ1RmdmYwRStHaVgwK25OdVlXVDFvRXYvSjB6dUpNdEoyVi9QY3dPZ2ZQ?=
 =?utf-8?B?Kys0RXFQbXc0OTBoMzc2SE92R1NvbHlQNnhnTXVReGtidlVnZE1PN0Y4RVFP?=
 =?utf-8?B?WDloT2M1dnF5dFN0K2tqaktpcjNBblppUXhwVFN2NHF6Mk9NU00xQTlJZmdl?=
 =?utf-8?B?VlE2Skw2WjQvQ1d0SVNhdFJTdzY0UjZPSjZhT2J2WE96YjJId2syMGtCNFNa?=
 =?utf-8?B?cWdhOGhrNUJHV3ZtNHg3b0dYTUpIQUl1UUc0QkgwR3ZoMytBdFNoUDIwNTll?=
 =?utf-8?B?QTVUMjJXcjJ4U0YwenFKYjV1R01BVm92b0w2TDJ4ajdjOHdTN0ZCR0RSZFQ5?=
 =?utf-8?B?cGlRcWpyYXIxQlUyYzM2UkI3SG9vMTY4UUdGZEo2RXloeXdJMFdUZW15VDhs?=
 =?utf-8?B?ZGxldkU3TVR4M2tRSGNzSG9ZdHp2RW1IbW1jcUI2R0xOeFg4aUhtSndVT2Z6?=
 =?utf-8?B?TUpuV01uNmdpb3U2OTlJazYzaW1JVHFTQjkycktoNWZJbmhTdi9ZUGlsd1oy?=
 =?utf-8?B?MFQ4WnZBeDlTTWpXLzYzaEh6clJKQzBmZlQybTlkYjNQS1B3ZEJTV3JFejln?=
 =?utf-8?B?QkFWaHEvWVQ2eWhoaThsY0ZZTTdwb1BzYm5NZGdBbGczY1NCbUVOOGpVRG9s?=
 =?utf-8?B?SThucXFBQ1RUTVExdWhqWW9XQjRqVXM4NDUvYk1XK1ExcExCZnZXRkRwM1RV?=
 =?utf-8?B?NjBlSS9GZDZxZmlJZ0R5MDBONlZMVythUW51V0ZGaEFOSHVTdENmbE1SNjJK?=
 =?utf-8?B?SGdZUXlCVjFuc0RRZ2RDc2RKbFlWNFVNWmc2T3JycmV1aE1GMTdCRVpzY1FI?=
 =?utf-8?Q?N/dR6cDLbn1LPikqrDdWPWqqC0B670L0FkwPhE7Baw=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 15ab241a-ac53-45a7-5381-08da01ab4420
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2022 09:00:32.3631
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Q1SaYG8Rbc/LeXUrz9YudympAstyf8IecTSeyJZr3xLhAM0EtiQ2cBQGIPCN2niA34zTy5yOAx2kfwb9UXffWA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4093
X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 08/03/2022 18:30, Krishna Yarlagadda wrote:
> From: Ashish Singhal <ashishsingha@nvidia.com>
> 
> This adds the QSPI controllers on the Tegra234 SoC and populates the
> SPI NOR flash device for the Jetson AGX Orin platform.
> 
> Signed-off-by: Ashish Singhal <ashishsingha@nvidia.com>
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> Signed-off-by: Krishna Yarlagadda <kyarlagadda@nvidia.com>
> ---
> v4:
> sort definitions in include and dt files
> 
>   .../boot/dts/nvidia/tegra234-p3701-0000.dtsi  | 12 ++++++++
>   arch/arm64/boot/dts/nvidia/tegra234.dtsi      | 28 +++++++++++++++++++
>   include/dt-bindings/clock/tegra234-clock.h    |  8 ++++++
>   include/dt-bindings/reset/tegra234-reset.h    |  2 ++
>   4 files changed, 50 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi b/arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi
> index d95a542c0bca..798de9226ba5 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3701-0000.dtsi
> @@ -7,6 +7,18 @@
>   	compatible = "nvidia,p3701-0000", "nvidia,tegra234";
>   
>   	bus@0 {
> +		spi@3270000 {
> +			status = "okay";
> +
> +			flash@0 {
> +				compatible = "jedec,spi-nor";
> +				reg = <0>;
> +				spi-max-frequency = <102000000>;
> +				spi-tx-bus-width = <4>;
> +				spi-rx-bus-width = <4>;
> +			};
> +		};
> +
>   		mmc@3460000 {
>   			status = "okay";
>   			bus-width = <8>;
> diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> index aaace605bdaa..448512af7dea 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> @@ -654,6 +654,20 @@
>   			reset-names = "i2c";
>   		};
>   
> +		spi@3270000 {
> +			compatible = "nvidia,tegra234-qspi";
> +			reg = <0x3270000 0x1000>;
> +			interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			clocks = <&bpmp TEGRA234_CLK_QSPI0_2X_PM>,
> +				 <&bpmp TEGRA234_CLK_QSPI0_PM>;
> +			clock-names = "qspi", "qspi_out";
> +			resets = <&bpmp TEGRA234_RESET_QSPI0>;
> +			reset-names = "qspi";
> +			status = "disabled";
> +		};
> +
>   		pwm1: pwm@3280000 {
>   			compatible = "nvidia,tegra194-pwm",
>   				     "nvidia,tegra186-pwm";
> @@ -666,6 +680,20 @@
>   			#pwm-cells = <2>;
>   		};
>   
> +		spi@3300000 {
> +			compatible = "nvidia,tegra234-qspi";
> +			reg = <0x3300000 0x1000>;
> +			interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>;
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			clocks = <&bpmp TEGRA234_CLK_QSPI1_2X_PM>,
> +				 <&bpmp TEGRA234_CLK_QSPI1_PM>;
> +			clock-names = "qspi", "qspi_out";
> +			resets = <&bpmp TEGRA234_RESET_QSPI1>;
> +			reset-names = "qspi";
> +			status = "disabled";
> +		};
> +
>   		mmc@3460000 {
>   			compatible = "nvidia,tegra234-sdhci", "nvidia,tegra186-sdhci";
>   			reg = <0x03460000 0x20000>;
> diff --git a/include/dt-bindings/clock/tegra234-clock.h b/include/dt-bindings/clock/tegra234-clock.h
> index 8cae969e8cba..bd4c3086a2da 100644
> --- a/include/dt-bindings/clock/tegra234-clock.h
> +++ b/include/dt-bindings/clock/tegra234-clock.h
> @@ -140,6 +140,14 @@
>   #define TEGRA234_CLK_PEX2_C9_CORE		173U
>   /** @brief output of gate CLK_ENB_PEX2_CORE_10 */
>   #define TEGRA234_CLK_PEX2_C10_CORE		187U
> +/** @brief CLK_RST_CONTROLLER_CLK_SOURCE_QSPI0 switch divider output */
> +#define TEGRA234_CLK_QSPI0_2X_PM		192U
> +/** @brief CLK_RST_CONTROLLER_CLK_SOURCE_QSPI1 switch divider output */
> +#define TEGRA234_CLK_QSPI1_2X_PM		193U
> +/** @brief output of the divider QSPI_CLK_DIV2_SEL in CLK_RST_CONTROLLER_CLK_SOURCE_QSPI0 */
> +#define TEGRA234_CLK_QSPI0_PM			194U
> +/** @brief output of the divider QSPI_CLK_DIV2_SEL in CLK_RST_CONTROLLER_CLK_SOURCE_QSPI1 */
> +#define TEGRA234_CLK_QSPI1_PM			195U
>   /** @brief CLK_RST_CONTROLLER_CLK_SOURCE_SDMMC_LEGACY_TM switch divider output */
>   #define TEGRA234_CLK_SDMMC_LEGACY_TM		219U
>   /** @brief output of gate CLK_ENB_PEX0_CORE_0 */
> diff --git a/include/dt-bindings/reset/tegra234-reset.h b/include/dt-bindings/reset/tegra234-reset.h
> index 1362cd5e03f0..547ca3b60caa 100644
> --- a/include/dt-bindings/reset/tegra234-reset.h
> +++ b/include/dt-bindings/reset/tegra234-reset.h
> @@ -40,6 +40,8 @@
>   #define TEGRA234_RESET_PWM6			73U
>   #define TEGRA234_RESET_PWM7			74U
>   #define TEGRA234_RESET_PWM8			75U
> +#define TEGRA234_RESET_QSPI0			76U
> +#define TEGRA234_RESET_QSPI1			77U
>   #define TEGRA234_RESET_SDMMC4			85U
>   #define TEGRA234_RESET_UARTA			100U
>   #define TEGRA234_RESET_PEX0_CORE_0		116U


Thanks! This looks good to me. You already have my signed-off but ...

Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Cheers
Jon

-- 
nvpublic