Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp263287pxp; Wed, 9 Mar 2022 02:24:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJxkmPEU1sdznGrmY/WD38KkCY8rGgEAOWSL6LIw6tAf4104RHmnIhUfKiSqE/Iy4Jvex4nP X-Received: by 2002:a17:907:3f95:b0:6d3:feb2:ef88 with SMTP id hr21-20020a1709073f9500b006d3feb2ef88mr17410363ejc.480.1646821477166; Wed, 09 Mar 2022 02:24:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646821477; cv=none; d=google.com; s=arc-20160816; b=STPa6wpQr+Pv9fWKL+4biSeFvoOSN0GZ3W027L5kudTDiL6ATa7LF7SU8vwGweepeS 4PisU4TD3Buw8+jVcPOxZLt/nO8E0+HgMaTXUG4IanhPSqxbb/DwSAPTZ/kj4a6egodr URtO3+8WXD1vNzPEvtHW067eZMcu3EM8dlvxJlMa+K/fe642XyD88j8+q/jfVDp0Zm8i cIPSenqF+YthpaofZufQJN3ffvFWVuSV35cPXEm03iS8Wf+tyN9gQHBP7+ujaH0yJfqh f/c2G7TtSy3Fy+XLKlmgQp3mrB1I5Geo82v1zMkLf+KgDpuxZZ408O5riYPclts7r8hO KIsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:cc:to:subject:message-id :from:content-transfer-encoding:date:dkim-signature:mime-version; bh=4Li/atw8t4VHrlTtZr7lVd54CxfuY0zgPh9pM5418Gw=; b=RKw77yA5yBKv+RMfMacppjA6azUk2hXIfE2YRqKEj2ZW24XGBDv9YSdx+feaJEfPwX TEcYTlnA7sYX0EwAbso+M5K8Sy96v9ZkJqojepZWGjgNzYf7BtuA7VCWFNYevCX/cxW3 CRkz7HIfIsOL8h76Dx9o6HjmxcDlCfroeemo9MsensLCcCMHEIbrztZKxdNHMyramr2P k/rDKHzH7VuFL390iCKINr5YNas/0cmVQtXNGCyqo1I5iEQCy4DRIykdYBCUeaapw2iX +nW58ppW2hzVUeh4KS3rpFtcAVtpO8jha/YZPqE1VTGDsE8AH/YbAMG3NXmCOek5rjh+ UTCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=Pdnrk6qw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q10-20020aa7d44a000000b0041613ab1d22si895600edr.553.2022.03.09.02.24.13; Wed, 09 Mar 2022 02:24:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=Pdnrk6qw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232163AbiCIJfz (ORCPT + 99 others); Wed, 9 Mar 2022 04:35:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232146AbiCIJft (ORCPT ); Wed, 9 Mar 2022 04:35:49 -0500 Received: from out0.migadu.com (out0.migadu.com [IPv6:2001:41d0:2:267::]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57EBF85955; Wed, 9 Mar 2022 01:34:50 -0800 (PST) MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1646818488; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4Li/atw8t4VHrlTtZr7lVd54CxfuY0zgPh9pM5418Gw=; b=Pdnrk6qwBRHlXgjDlB+kplmOEV1Q3EpIVprYkuLXjYsuNxMs4Sj2qdWeeSnBFDLMInRJDK gv1tdrWuovr/cnnpl7YPJZDEFlNG5XSbGuJ4632b8iilQtsPG3Jags+ib1keAfIPoOE+Ij SWbKI6QtI8pj1woS2lJN20ORZnNd1to= Date: Wed, 09 Mar 2022 09:34:47 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Yajun Deng" Message-ID: <9e6973cfbca0ef70bfd57f499a7f5397@linux.dev> Subject: Re: [PATCH for-next 0/9] RDMA: get rid of create_user_ah To: "Leon Romanovsky" Cc: jgg@nvidia.com, selvin.xavier@broadcom.com, galpress@amazon.com, sleybo@amazon.com, liangwenpeng@huawei.com, liweihang@huawei.com, mustafa.ismail@intel.com, shiraz.saleem@intel.com, dennis.dalessandro@cornelisnetworks.com, mike.marciniszyn@cornelisnetworks.com, zyjzyj2000@gmail.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: References: <20220308143428.3401170-1-yajun.deng@linux.dev> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thank you for the tip.=0A -- Yajun=0A=0AMarch 9, 2022 5:21 PM, "Leon Roma= novsky" wrote:=0A=0A> On Tue, Mar 08, 2022 at 10:34:2= 8PM +0800, Yajun Deng wrote:=0A> =0A>> The two members create_user_ah and= create_ah in struct ib_device_ops=0A>> are very similar. we can use crea= te_ah for all case. so get rid of=0A>> create_user_ah.=0A> =0A> 1. Please= read commit message and content of commit 676a80adba01=0A> ("RDMA: Remov= e AH from uverbs_cmd_mask") that added that .create_user_ah()=0A> callbac= k.=0A> 2. You should send patches as a series that is threaded and not as= =0A> stand-alone patches.=0A> =0A> Thanks