Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <affb2499-d0c8-9f8f-bfc0-3bf8b2fa431c@collabora.com>
Date:   Wed, 9 Mar 2022 10:50:50 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.1
Subject: Re: [PATCH] mmc: mtk-msdc: change a log level
Content-Language: en-US
To:     Alexandre Bailon <abailon@baylibre.com>,
        chaotian.jing@mediatek.com, ulf.hansson@linaro.org,
        matthias.bgg@gmail.com
Cc:     linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20220308094924.2868042-1-abailon@baylibre.com>
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
In-Reply-To: <20220308094924.2868042-1-abailon@baylibre.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Il 08/03/22 10:49, Alexandre Bailon ha scritto:
> We write data to RPMB, we get many time the following log:
> mtk-msdc 11230000.mmc: phase: [map:ffffffff] [maxlen:32] [final:10]
> 
> dev_info is used to print that log but it seems that log is only
> useful for debbuging. Use dev_dbg instead of dev_info.
> 
> Signed-off-by: Alexandre Bailon <abailon@baylibre.com>

Hello Alexandre,

I definitely agree with this change, but the commit title is not clear enough;
can you please change it to something like

mmc: mtk-sd: Silence delay phase calculation debug log


After the change,
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

> ---
>   drivers/mmc/host/mtk-sd.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index d5a9c269d492..05c8b4de46f3 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -1914,8 +1914,8 @@ static struct msdc_delay_phase get_best_delay(struct msdc_host *host, u32 delay)
>   		final_phase = (start_final + len_final / 3) % PAD_DELAY_MAX;
>   	else
>   		final_phase = (start_final + len_final / 2) % PAD_DELAY_MAX;
> -	dev_info(host->dev, "phase: [map:%x] [maxlen:%d] [final:%d]\n",
> -		 delay, len_final, final_phase);
> +	dev_dbg(host->dev, "phase: [map:%x] [maxlen:%d] [final:%d]\n",
> +		delay, len_final, final_phase);
>   
>   	delay_phase.maxlen = len_final;
>   	delay_phase.start = start_final;
>