Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220309052842.247031-1-michael@michaelkloos.com>
 <CAK8P3a2Mr_z6h7eg1O8ZN5_qE-o+8KFFBum3CxyuDYeF50s1dw@mail.gmail.com> <e936de26-95b7-1eed-008e-8d025b638265@michaelkloos.com>
In-Reply-To: <e936de26-95b7-1eed-008e-8d025b638265@michaelkloos.com>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Wed, 9 Mar 2022 12:47:50 +0100
Message-ID: <CAK8P3a33g1D2mE2Z_ZsukMCBZ3gCGdDbH+2osHZe0Y8GoO_5UA@mail.gmail.com>
Subject: Re: [PATCH] riscv: Work to remove kernel dependence on the M-extension
To:     "Michael T. Kloos" <michael@michaelkloos.com>
Cc:     Arnd Bergmann <arnd@arndb.de>, Palmer Dabbelt <palmer@dabbelt.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        linux-riscv <linux-riscv@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Mar 9, 2022 at 12:43 PM Michael T. Kloos
<michael@michaelkloos.com> wrote:
>
> Thank you for your feedback.  I don't really have much of an
> opinion about that right now aside from that I know where things
> are in the current structure and am comfortable.  My goal with this
> contribution was to keep it in-line with the current config
> structure.  Hence, I put it right next to the menuconfig option
> to control CONFIG_RISCV_ISA_C under Platform Type.
>
> I wouldn't necessarily be opposed to rethinking the way platform
> feature selection is presented in menuconfig.  If people feel that
> most users will be looking for an rv64gc config and that it should
> be made for clear, perhaps it could be done.  I would need to do
> more thinking about how exactly that would look.
>
> I do think that it is outside the scope of this patch.  Were you
> working on something like that and worried about a merge conflict?

As I said, I think your patch is ok, and I have no objections to it
being merged. It's just one more option among others that
can cause problems if users get it wrong.

       Arnd