Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp406517pxp; Wed, 9 Mar 2022 05:27:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJxEA7y1fq+7AgeZ6F8k/N4cxrxZ9RTOWQ4HEwc/awLC4Mu2GXmG4PTjx2s6sOotP6/jCopC X-Received: by 2002:a63:5250:0:b0:380:bfd9:4124 with SMTP id s16-20020a635250000000b00380bfd94124mr1436637pgl.206.1646832448732; Wed, 09 Mar 2022 05:27:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646832448; cv=none; d=google.com; s=arc-20160816; b=V3luP6N4EId3pIux/muzLqJ57Gkgftl6qP4rEF4xEeaduDGi0tAzEUS7imUGe1Od+p S66upa/uJr0S9Lpgpylti3cqyatC04XjuHWCnYjPoN9AIqHaO7ew4Fk0GBaAa1JjZkPG AXq9ULinQscz6e415ia0HWWJQM+i5wTMNfFg2Hlv8ni8re+tyLLHnmhQlH068GmVIrKl vPmpPSX24uDGpTZmpr7ISY1l5zNbczrVDhLfxt8Ycr0CCJyJcAF5qmfZlOfyaVfAboom c/uhGJVgXLMMnKwIxvGDFHPzDsqIvYAJjS/ik/RI5xda3ChylDWuI3Oq4Hvkt/yyrTVK NPMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:references :in-reply-to:mime-version:dkim-signature; bh=SWzu+GeLFBzjWwTtfyysupse2w7hgdBZ4RPgbP0Le9s=; b=keZ99rEQe2OxTVQA3tIa8cxBfD4tKAeYyrukhkW7XJApRgRwqRQwtDGl/+o0E72MRH p9AmqTVlM5DOklM3ixvUkZ+dFyUBNWO55V4oF55abLSOsnCAkaov2QgnuIk2+N3cWPZB +gBxXWM9f4lYIUiIfH6YFr1Bu1ASk+w5ay4n3wJGvXT1JMLP7s5oASGIUHmwJ0ElMjPv UvAGQU2xN3Tix67MFjnUpJPsHCZfd+C0i8CU7o3tpxiYqY9KRWrz5YECDEJdbC1gmBCc MEva5Vrksr/kfpnHnQKwxm+PS+IPL17a+5VRoMC6m2Y/07tb4Ge8MfaneJl4aIazthBM 5/UQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ra455ULI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i25-20020aa796f9000000b004f6aaa43acesi1812211pfq.130.2022.03.09.05.27.12; Wed, 09 Mar 2022 05:27:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ra455ULI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231978AbiCILPv (ORCPT + 99 others); Wed, 9 Mar 2022 06:15:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230392AbiCILPt (ORCPT ); Wed, 9 Mar 2022 06:15:49 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF41F13CA2B; Wed, 9 Mar 2022 03:14:50 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 900B9B82023; Wed, 9 Mar 2022 11:14:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5476CC340EE; Wed, 9 Mar 2022 11:14:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646824488; bh=k62VYnEAja+A8m7m/Ypa0GboSWV+2bBhbEgOgQIQVR4=; h=In-Reply-To:References:From:Date:Subject:To:Cc:From; b=ra455ULILUulZFobV379nzboqFYi3ADAbkEj4B9+/CzI/43yRfkwPIo+Z8h7C+BOX n30vrJFpQF8OJ40Xlnp6jzeVzgMH+mg8pXx1IJQuOVaCunqMhcqlw9F0ISv1D1CUMg dC9WRDkvN6X/0CGRKQ366APg3kv/sJtuYsyPxjclha11pA7YWrdZ2OW8ojm6qLZISn 6lTmlE+YPuUIItTJqxzYYv/tGAk+yPcNJtGgmaBEceyfCG6zaHvaC4g+HdHnKP057c KG+uC9ssTeeYJNT273ofFgIgQJTrBEjbr8pdJzapwK9q4hzY0rE/6WTGO93pEXhNHE XpuRYY3RcGDdQ== Received: by mail-wr1-f48.google.com with SMTP id q14so2477025wrc.4; Wed, 09 Mar 2022 03:14:48 -0800 (PST) X-Gm-Message-State: AOAM5323QugK2H0HUaUycwEcOSPEiY6KeEldVDaE6Pmu9ODEuAL5Iq1V +HdGQZOpN9CLLKGWnA/6JYOAYqUq/oBZJ6P7L5Q= X-Received: by 2002:a5d:4387:0:b0:1ed:a13a:ef0c with SMTP id i7-20020a5d4387000000b001eda13aef0cmr15722930wrq.62.1646824486677; Wed, 09 Mar 2022 03:14:46 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a05:6000:1d93:0:0:0:0 with HTTP; Wed, 9 Mar 2022 03:14:45 -0800 (PST) In-Reply-To: References: From: Namjae Jeon Date: Wed, 9 Mar 2022 20:14:45 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] exfat: do not clear VolumeDirty in writeback To: "Yuezhang.Mo@sony.com" Cc: "sj1557.seo@samsung.com" , "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Andy.Wu@sony.com" , "Wataru.Aoyama@sony.com" , "Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp" Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2022-03-08 19:55 GMT+09:00, Yuezhang.Mo@sony.com : > Hi Namjae Jeon, > >> > +int exfat_clear_volume_dirty(struct super_block *sb) { >> > + if (sb->s_flags & (SB_SYNCHRONOUS | SB_DIRSYNC)) >> How about moving exfat_clear_volume_dirty() to IS_DIRSYNC() check in each >> operations instead of this check? > > I found that VolumeDirty keeps VOL_DIRTY until sync or umount regardless of > sync or dirsync enabled, > because there is no paired call to > exfat_set_volume_dirty()/exfat_clear_volume_dirty() in > __exfat_write_inode(). > > If exfat_set_volume_dirty()/exfat_clear_volume_dirty() is called in pairs in > __exfat_write_inode(), > it will cause frequent writing of bootsector. > > So, how about removing exfat_clear_volume_dirty() from each operations, > except in exfat_sync_fs()? Okay. Please send the patch for this. Thanks! > > > Best Regards, > Yuezhang Mo >