Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 9 Mar 2022 13:00:45 +0000
From:   Mark Brown <broonie@kernel.org>
To:     John Keeping <john@metanate.com>
Cc:     alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Daniel Beer <daniel.beer@igorinstitute.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: tas5805m: fix pdn polarity
Message-ID: <Yiik/f+2bYbU4UL8@sirena.org.uk>
References: <20220309104104.3605112-1-john@metanate.com>
 <YiiZv7Fc8a4O1nYR@sirena.org.uk>
 <Yiie1OUCvi49f1Q7@donbot>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="hjBCmlAKl+Qf/it8"
Content-Disposition: inline
In-Reply-To: <Yiie1OUCvi49f1Q7@donbot>
Precedence: bulk


--hjBCmlAKl+Qf/it8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 09, 2022 at 12:34:28PM +0000, John Keeping wrote:
> On Wed, Mar 09, 2022 at 12:12:47PM +0000, Mark Brown wrote:
> > On Wed, Mar 09, 2022 at 10:41:04AM +0000, John Keeping wrote:
> >=20
> > > Fixes: ec45268467f4 ("ASoC: add support for TAS5805M digital amplifie=
r")
> >=20
> > Please don't insert fixes tags unless you're actually fixing a bug,
> > stylistic improvements like this - people try to use the tag for
> > backporting bug fixes and so on so extra tags create noise for them.

> This isn't purely stylistic - it affects the interpretation of pdn-gpios
> in the device tree so that it matches all of the other bindings that use
> this property: active means PDN asserted.

So there's some functional change?  That's not at all clear from either
the patch description or the code - it's flipping both the ACTIVE mode
for the GPIO and all the values set which should result in no visible
change.  If there is a functional problem that is being fixed the
description needs to be clear as to what that is.

--hjBCmlAKl+Qf/it8
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmIopPwACgkQJNaLcl1U
h9Dz6Qf/Rx3O2NC+fo44hKIqYpJBFJAGAT1vhCKye5rC0cPnfrahsuAJlCCtNnD0
0lH5kzPWDHEDWwFgdqTReBykG6CR2XJeMbmppFJBDXRwleeKLkZsxC4L9b4iQlK3
B5/67vv6Ju0SECEO8XDQQGnqPYclkGA+Bw0fzUvFZtpLxQFgVgbvO5Zy3NDnPLIb
NEMZECzfJP2At7zBbYhBR/VgLRNNjfskD1A/fFb66ldkUUenIy5oQc4EhsowIuFQ
C6hrzwilfB8c2M5gAF1wHdr8I8oOkauoHazJJ2awQZypPn2xKU8JEW2tArhHpTQs
INvjPb0PRGQJls6P1GKKHKNngVgXzg==
=uZKY
-----END PGP SIGNATURE-----

--hjBCmlAKl+Qf/it8--