Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20220309115507.30019-1-laurentiu.palcu@oss.nxp.com>
References: <20220309115507.30019-1-laurentiu.palcu@oss.nxp.com>
Subject: Re: [PATCH v2] media: i2c: rdacm2x: properly set subdev entity function
From:   Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc:     Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>,
        Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
To:     Jacopo Mondi <jacopo+renesas@jmondi.org>,
        Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
        Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Niklas =?utf-8?q?S=C3=B6derlund?= 
        <niklas.soderlund+renesas@ragnatech.se>,
        Rob Herring <robh@kernel.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>
Date:   Wed, 09 Mar 2022 15:04:28 +0000
Message-ID: <164683826808.123014.1703937676440784435@Monstersaurus>
User-Agent: alot/0.10
Precedence: bulk

Quoting Laurentiu Palcu (2022-03-09 11:55:06)
> The subdevice entity function was left unset, which produces a warning
> when probing the device:
>=20
> mxc-md bus@58000000:camera: Entity type for entity rdacm20 19-0051 was
> not initialized!
>=20
> This patch will set entity function to MEDIA_ENT_F_CAM_SENSOR and leave
> flags unset.
>=20
> Fixes: 34009bffc1c6 ("media: i2c: Add RDACM20 driver")
> Fixes: a59f853b3b4b ("media: i2c: Add driver for RDACM21 camera module")

Ohh, I've never seen a use case for two fixes tags before.
I don't think this requires two patches to implement the fix though.

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

> Signed-off-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
> ---
> Changes in v2:
>         * leave entity flags unset;
>=20
> Cheers,
> Laurentiu
>=20
>  drivers/media/i2c/rdacm20.c | 2 +-
>  drivers/media/i2c/rdacm21.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/media/i2c/rdacm20.c b/drivers/media/i2c/rdacm20.c
> index 025a610de893..9c6f66cab564 100644
> --- a/drivers/media/i2c/rdacm20.c
> +++ b/drivers/media/i2c/rdacm20.c
> @@ -611,7 +611,7 @@ static int rdacm20_probe(struct i2c_client *client)
>                 goto error_free_ctrls;
> =20
>         dev->pad.flags =3D MEDIA_PAD_FL_SOURCE;
> -       dev->sd.entity.flags |=3D MEDIA_ENT_F_CAM_SENSOR;
> +       dev->sd.entity.function =3D MEDIA_ENT_F_CAM_SENSOR;
>         ret =3D media_entity_pads_init(&dev->sd.entity, 1, &dev->pad);
>         if (ret < 0)
>                 goto error_free_ctrls;
> diff --git a/drivers/media/i2c/rdacm21.c b/drivers/media/i2c/rdacm21.c
> index 12ec5467ed1e..ef31cf5f23ca 100644
> --- a/drivers/media/i2c/rdacm21.c
> +++ b/drivers/media/i2c/rdacm21.c
> @@ -583,7 +583,7 @@ static int rdacm21_probe(struct i2c_client *client)
>                 goto error_free_ctrls;
> =20
>         dev->pad.flags =3D MEDIA_PAD_FL_SOURCE;
> -       dev->sd.entity.flags |=3D MEDIA_ENT_F_CAM_SENSOR;
> +       dev->sd.entity.function =3D MEDIA_ENT_F_CAM_SENSOR;
>         ret =3D media_entity_pads_init(&dev->sd.entity, 1, &dev->pad);
>         if (ret < 0)
>                 goto error_free_ctrls;
> --=20
> 2.17.1
>