Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7967cc8f-11af-0236-9ed6-ea9a84702965@amd.com>
Date:   Wed, 9 Mar 2022 10:03:18 -0600
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.2
Subject: Re: [PATCH] x86/mce: Unify vendors grading logic and provide AMD
 machine error checks
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
Cc:     tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com,
        x86@kernel.org, yazen.ghannam@amd.com,
        linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org,
        bilbao@vt.edu
References: <20220308184133.712761-1-carlos.bilbao@amd.com>
 <YievKnn5hSK0AvMt@nazgul.tnic>
From:   Carlos Bilbao <carlos.bilbao@amd.com>
In-Reply-To: <YievKnn5hSK0AvMt@nazgul.tnic>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V2JKQVR5MlpYK2R3QzFDVFdFZ2hZb0M1dmlRTzh4NkJCWnBKTEdhZVU5c1lC?=
 =?utf-8?B?RzVSc2FaaXQzM2thNng4cFBkK0VOSFl0T2Y4djlMSndZZXd2RmxLVU9rTUc3?=
 =?utf-8?B?Snc3dnQyaXNYM3lZT0RFYkNRNS9PSEhYVGN3ZzhBa29vaDVjOFNndjdUVTB1?=
 =?utf-8?B?Yjg2T0x6RzBTc2NFa2pTYmNOMisyK0tMOWw3RVdUcE1TdmZ2TENmbmlKQis2?=
 =?utf-8?B?UTd3QWJ6RmxLWjJ2bVNQeU11WHgxa1pEOUpFeWF1LzE3R1JTTlZxUWxEU24x?=
 =?utf-8?B?RS9OTFBIcHVqWlBoWW12eEkxeGp2TzF3blBJZTI1RDRzNjlKLzRPNmVNdjBl?=
 =?utf-8?B?eXpRSGVvUzc0UUx0R3dkSEc1NU9kalRmTEFOT3ZkTUZPSWpUdFowVlY4WmRZ?=
 =?utf-8?B?eXZvNEd4ajU1S1VTbi84REhlUkFON0JqR3dlMnRNRVJ4dzZPWERuZ2plMDhB?=
 =?utf-8?B?YkFUR1ZCMkRPSVM1OXNubjMvOUNrc0IwaFAyV1M0QzU0VzNBL0FIREVycmk4?=
 =?utf-8?B?SVBIbGFudm9IcENtNlVTQmo1eUhhQXlQMW5YR3JQQWZRTnhycXc1TEZwWmVY?=
 =?utf-8?B?cno4Y05nUHNsK3dieTFOYlNTU1ZpNnJrQzVqMUxVeGVvcEt4d2tsK1hMRDQ4?=
 =?utf-8?B?SGJrZzBIaWtkbUp1QVh2MDlRbWdPRjBFbG11cjBqRFFZNjdYUC9WTHFkRk11?=
 =?utf-8?B?N3ZLUHNSWFRXVk5UZDN5Z2F5dFBweThSRGZmWjBOWkM0Z3BGRTFRSm8rV3ps?=
 =?utf-8?B?MHZpYUt4aHJETEx3RG9GdWhRTytZQnYzSHNxelFBVWVudUROaUNuakR5dTFO?=
 =?utf-8?B?MGlJb1hFOGJ6ZCtXRVhXWmkrMndHODdwdEtnSW51S25Bb0lZbFE5VzVXOWpk?=
 =?utf-8?B?QkRNYzlwcjBhVnI1VmswM3JmdGJrMUR1ZUtSM3A2MlR0YjczUm1iYk1QS0dm?=
 =?utf-8?B?TmlDM3UrU1JjSCtTeXMzN0g0QktUWVVIQUV6dWVqZ3dGRWwwaXh0ODFUNmVH?=
 =?utf-8?B?TjZNQXZlb3Rrcy9EYVk1czZXZXJpQnQybkFXTmZKbWR3R29KT0FaOC85QUpF?=
 =?utf-8?B?aElVMTVWSGxZUGlISFBvZERRaVpLYi9wckhzSW1LVGNTVmhlQVpndmlqclBk?=
 =?utf-8?B?d29jcnVnZVFWd1lEbFhGV21LWjBvSU1BZG4xK2ZpOVBtU3g2WjE2T3BDYU9m?=
 =?utf-8?B?cEUreEp2T2FvYzE4QkhVYUZhWEZ5TGQxMXJnVCtQenpPbk1YMTBRWHVhL1BJ?=
 =?utf-8?B?alVZd3gvUWJzOVludmkvbDl4cDJzQ0JhckpYeGtNM1dYR3h4Y3JDQVBGTUNB?=
 =?utf-8?B?Y1FRY2pteTJPK3hJUTRWUzl0U0NVMHlvUjZIVlJtVkRKZitzblpjaTl4RWZj?=
 =?utf-8?B?ekJXUmRtSlI5UWJMNjRsTkdrRVNBQjVOeUlaMzA4dkorRERnWmI2b3IwbTRq?=
 =?utf-8?B?aWhHQkNCbXQveXNpRnJ2UysyZklScEVWbDd5bW9WWG0yTUk0dU1OakRuZHNC?=
 =?utf-8?B?elFjdTNlaFE1eEMzWEJha29icEhBQ3J3VmNqTzNWYkdHZ2JXdEozNTZ4USsw?=
 =?utf-8?B?MXpXaGc0aENIalhNSzYxejdiVlE3V0ZabFBTdmloL2x1dXZtcWwxK3FqTXlp?=
 =?utf-8?B?cXAxK1FQVTZtMm1LTTFpZXkrUjFNZ2dEY3dYeXZ6WmZYUlc3M0F3L2gzcTFI?=
 =?utf-8?B?SDZmM2JPNVhpRnZzZmRvVnRBdGFQb2JjSjE4dWNGYWZENUxtMm4rblc1R3pY?=
 =?utf-8?B?UFhJQkNqeVJ0VWJoZTZRZlBOY21Wd3Nhb3dJQ1pZZmppcE9UV1pEZjdtb1hX?=
 =?utf-8?B?S3llaFpsWXNlNHFEeS9DaEhwem1KRFdwY2U3OU1sV3I3cTliaVlhMGJDc2k5?=
 =?utf-8?B?VW9BMm13Q3lQd1JnZWgxc3lESlN6dUxuY2dHUzV0V3Y1ZzdUOGpORkc0Mmx6?=
 =?utf-8?B?KzRNR0ZTd3MvUGhKMWMzajVDc1NwMXJYZll2cXphVzN5RWphaEo5V1dBZXM5?=
 =?utf-8?B?WUlpU2dPWkQ4QWlHbDBNSGRtNGVKSTVHTVZoMER0Ujlnd0cvSUI2WFZkTkUy?=
 =?utf-8?B?a0w5bWlVekFaYTV6aGJyOEI5VUlZcEhzZFFLZVBGVUhnWDZEY2F2b1Ura0dR?=
 =?utf-8?B?QnZoR0FVS3NlRkxwRUY3cU1ON2tBR2tyOHdQM0xuWHpMZzBWNDhBdktaN0hZ?=
 =?utf-8?Q?KuK15eHni7ctfXfr/849ZYQ=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8cf39534-9a1c-4b52-01de-08da01e654cc
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5874.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2022 16:03:20.5764
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0+5lKkU38iCRTkjq0yjCABz+I9KZ5jtaItD4dhY43rePxH6h5E+x0fCs6fzM2Wc5CqN9Tfb7bkNS0zCcEAAYiQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3126
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/8/2022 1:32 PM, Borislav Petkov wrote:
> On Tue, Mar 08, 2022 at 12:41:34PM -0600, Carlos Bilbao wrote:
>> AMD's severity grading covers very few machine errors. In the graded cases
>> there are no user-readable messages, complicating debugging of critical
>> hardware errors. Furthermore, with the current implementation AMD MCEs have
>> no support for the severities-coverage file. Adding new severities for AMD
>> with the current logic would be too convoluted.
>>
>> Fix the above issues including AMD severities to the severity table, in
>> combination with Intel MCEs. Unify the severity grading logic of both
>> vendors. Label the vendor-specific cases (e.g. cases with different
>> registers) where checks cannot be implicit with the available features.
>>
>> Signed-off-by: Carlos Bilbao <carlos.bilbao@amd.com>
>> ---
>>  arch/x86/include/asm/mce.h         |   7 ++
>>  arch/x86/kernel/cpu/mce/severity.c | 188 +++++++++++++++--------------
>>  2 files changed, 103 insertions(+), 92 deletions(-)
> 
> Sorry, maybe you're too new to this and you probably haven't read the
> old discussions we have had about the severity grading turd. In order to
> save you some time: adding more to that macro insanity is not going to
> happen.
> 
> The AMD severity grading functions are *actually* readable vs this
> abomination which I hate with passion.
> 
> If you want to add more logic, you should add to mce_severity_amd(),
> perhaps call other helper functions which grade based on a certain
> aspect of the error type, split the logic, use comments, etc, but
> *definitely* not this.
> 
> Thx.
> 

Understood, sending a new patch in that direction.

Thanks,
Carlos