Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp621632pxp; Wed, 9 Mar 2022 09:15:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJxSmGF0k6nO1U2RkAW55LVlQyqcGOesP4+AhhqL6+5kMC3m49ni2DO9IOwKF1mlsIY+0+zJ X-Received: by 2002:a63:ec4f:0:b0:378:d43b:2272 with SMTP id r15-20020a63ec4f000000b00378d43b2272mr591737pgj.29.1646846120120; Wed, 09 Mar 2022 09:15:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646846120; cv=none; d=google.com; s=arc-20160816; b=IRrDg+RVgXqXZngWv5xuCMQ1QWxgmNewq9rooI9qLP9RcMT7EB7z7j9K8D5Jp+DgnI ZiWFLUOnmibP+8WWMgqYO5SwlEDoZZiqNahr4tqLpJYJEfPUOSncoacufEXQRNZIWAiG +Td1jCTjEvOo/1gu6p6b5MzbuD4BRxMh5T8FrVEbRXRLvxitJYOmwXLrZyrczS6V96TN A+cofQnwSTsRGQr9wNqiuieJZIXPvF2Hp4vVEsX6E4A7VxFMCqnQ4+oP0zmTnVlOe1Xq 23lDC4Oo7GHmV5bV86F+W5HmmIwW2zeMEJR1abMvDWAgsmkaHllpcM8AI+8Zd/yTXXcO mOhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=TBjkZF+VASeBBFI1OAc29aFrXNteY0hfl/8xpsAGj6I=; b=AjNBCwYKGG9hwt4czhCNkY8H2rMXFOL0r98hrPUc4kJaxq/P1AUNY8je6/jtKsLF/6 0sK05evGuwpzJtcfnqAORnItTs5WH1wBWKSeY0KZ7SecZHjmzzFsEsWW/t8wBWU8+SQS Vm8VEdFS3KMxEG/IBjWhDfyUftNgqVw/PGuAgQEVfkrvnL7Kjgh0ad9exV5wotDolPLh D7i86CAaVYCWFsKeMd8KthgA/lGgzcBEjn21kM13uY02QY97Qa8WK8rZNrVRBauNWeCV UcEkiTzouevaWGUYdmm4KeQhP8Af1WhfL2CpVvtfyJktMA6GW+D2eC9qVLpsjWVhjBs3 /K+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@microchip.com header.s=mchp header.b=sddeQC0q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i1-20020a170902cf0100b0014fe2ca91a1si2627033plg.12.2022.03.09.09.15.02; Wed, 09 Mar 2022 09:15:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@microchip.com header.s=mchp header.b=sddeQC0q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236383AbiCIQvr (ORCPT + 99 others); Wed, 9 Mar 2022 11:51:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235512AbiCIQox (ORCPT ); Wed, 9 Mar 2022 11:44:53 -0500 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8478377DE; Wed, 9 Mar 2022 08:38:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1646843917; x=1678379917; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ktAuPeikT5yIzQagKaEvWRybAOSvIjqqN73SIJDSJFk=; b=sddeQC0qY5EzG7AN9NlKoTk8AHUv9wMosYHZ5nBmIM7NYmv/ZmqqUje8 qQ9OjInt5bltMNweDp5cBNObEjx3GSliA1uW3Nz1kgvO14JJBK8CO+D9+ GO8tTVRhqZDdeNkd5wD7CHz/P/MhG/z9zhE3XfEDFPZeELvbjSgmDhu2G bLM65V2/DRjiEYXpnTtyQgNDNCr5sgF5bfR23EHWHghTmPjf8Q8cxvkbI qO2ohgg/K3e5KHaNcstQnayJO9Xml7PVUqJVC/t75MitZApCHtsT/zCIr zYZjDtqWklXWnJYMlg0Fp/lKr+Emp7/ZdRP9UEkMbqmhQAIY4m4f/h/kd Q==; X-IronPort-AV: E=Sophos;i="5.90,167,1643698800"; d="scan'208";a="148642546" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa4.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 09 Mar 2022 09:38:36 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Wed, 9 Mar 2022 09:38:35 -0700 Received: from ROB-ULT-M18282.microchip.com (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2375.17 via Frontend Transport; Wed, 9 Mar 2022 09:38:28 -0700 From: Eugen Hristev To: , CC: , , , , , , Eugen Hristev , Hans Verkuil Subject: [PATCH v8 02/13] media: atmel: atmel-isc-base: replace is_streaming call in s_fmt_vid_cap Date: Wed, 9 Mar 2022 18:37:47 +0200 Message-ID: <20220309163758.2672727-3-eugen.hristev@microchip.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220309163758.2672727-1-eugen.hristev@microchip.com> References: <20220309163758.2672727-1-eugen.hristev@microchip.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,T_SCC_BODY_TEXT_LINE, T_SPF_PERMERROR autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In s_fmt_vid_cap, we should check if vb2_is_busy and return EBUSY, not check if it's streaming to return the busy state. Suggested-by: Hans Verkuil Signed-off-by: Eugen Hristev Reviewed-by: Jacopo Mondi --- drivers/media/platform/atmel/atmel-isc-base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/atmel/atmel-isc-base.c b/drivers/media/platform/atmel/atmel-isc-base.c index d2cc6c99984f..67b4a2323fed 100644 --- a/drivers/media/platform/atmel/atmel-isc-base.c +++ b/drivers/media/platform/atmel/atmel-isc-base.c @@ -1029,7 +1029,7 @@ static int isc_s_fmt_vid_cap(struct file *file, void *priv, { struct isc_device *isc = video_drvdata(file); - if (vb2_is_streaming(&isc->vb2_vidq)) + if (vb2_is_busy(&isc->vb2_vidq)) return -EBUSY; return isc_set_fmt(isc, f); -- 2.25.1