Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220131162940.210846-1-david@redhat.com> <20220131162940.210846-4-david@redhat.com>
In-Reply-To: <20220131162940.210846-4-david@redhat.com>
From:   Yang Shi <shy828301@gmail.com>
Date:   Wed, 9 Mar 2022 10:48:23 -0800
Message-ID: <CAHbLzkpoNeSPyzGV9arXK7BrVWpERy0yGRggn1ZaRam8RrHyRQ@mail.gmail.com>
Subject: Re: [PATCH v3 3/9] mm: slightly clarify KSM logic in do_swap_page()
To:     David Hildenbrand <david@redhat.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Hugh Dickins <hughd@google.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        David Rientjes <rientjes@google.com>,
        Shakeel Butt <shakeelb@google.com>,
        John Hubbard <jhubbard@nvidia.com>,
        Jason Gunthorpe <jgg@nvidia.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Mike Rapoport <rppt@linux.ibm.com>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Matthew Wilcox <willy@infradead.org>,
        Vlastimil Babka <vbabka@suse.cz>, Jann Horn <jannh@google.com>,
        Michal Hocko <mhocko@kernel.org>,
        Nadav Amit <namit@vmware.com>, Rik van Riel <riel@surriel.com>,
        Roman Gushchin <guro@fb.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Peter Xu <peterx@redhat.com>,
        Donald Dutile <ddutile@redhat.com>,
        Christoph Hellwig <hch@lst.de>,
        Oleg Nesterov <oleg@redhat.com>, Jan Kara <jack@suse.cz>,
        Liang Zhang <zhangliang5@huawei.com>,
        Linux MM <linux-mm@kvack.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Jan 31, 2022 at 8:33 AM David Hildenbrand <david@redhat.com> wrote:
>
> Let's make it clearer that KSM might only have to copy a page
> in case we have a page in the swapcache, not if we allocated a fresh
> page and bypassed the swapcache. While at it, add a comment why this is
> usually necessary and merge the two swapcache conditions.
>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
>  mm/memory.c | 38 +++++++++++++++++++++++---------------
>  1 file changed, 23 insertions(+), 15 deletions(-)
>
> diff --git a/mm/memory.c b/mm/memory.c
> index 923165b4c27e..3c91294cca98 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -3615,21 +3615,29 @@ vm_fault_t do_swap_page(struct vm_fault *vmf)
>                 goto out_release;
>         }
>
> -       /*
> -        * Make sure try_to_free_swap or reuse_swap_page or swapoff did not

We could remove the reference to "reuse_swap_page", right?

> -        * release the swapcache from under us.  The page pin, and pte_same
> -        * test below, are not enough to exclude that.  Even if it is still
> -        * swapcache, we need to check that the page's swap has not changed.
> -        */
> -       if (unlikely((!PageSwapCache(page) ||
> -                       page_private(page) != entry.val)) && swapcache)
> -               goto out_page;
> -
> -       page = ksm_might_need_to_copy(page, vma, vmf->address);
> -       if (unlikely(!page)) {
> -               ret = VM_FAULT_OOM;
> -               page = swapcache;
> -               goto out_page;
> +       if (swapcache) {
> +               /*
> +                * Make sure try_to_free_swap or reuse_swap_page or swapoff did
> +                * not release the swapcache from under us.  The page pin, and
> +                * pte_same test below, are not enough to exclude that.  Even if
> +                * it is still swapcache, we need to check that the page's swap
> +                * has not changed.
> +                */
> +               if (unlikely(!PageSwapCache(page) ||
> +                            page_private(page) != entry.val))
> +                       goto out_page;
> +
> +               /*
> +                * KSM sometimes has to copy on read faults, for example, if
> +                * page->index of !PageKSM() pages would be nonlinear inside the
> +                * anon VMA -- PageKSM() is lost on actual swapout.
> +                */
> +               page = ksm_might_need_to_copy(page, vma, vmf->address);
> +               if (unlikely(!page)) {
> +                       ret = VM_FAULT_OOM;
> +                       page = swapcache;
> +                       goto out_page;
> +               }
>         }
>
>         cgroup_throttle_swaprate(page, GFP_KERNEL);
> --
> 2.34.1
>