Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp867367pxp; Wed, 9 Mar 2022 14:35:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJxpYo/cLeJ/kSN9eEKRcKYnnZkcSvq3HlOdp596owQQf9jM0yZAMPdipEwyYuMklVZrOQyx X-Received: by 2002:a17:906:86da:b0:6db:62b6:f3ee with SMTP id j26-20020a17090686da00b006db62b6f3eemr1783168ejy.442.1646865304816; Wed, 09 Mar 2022 14:35:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646865304; cv=none; d=google.com; s=arc-20160816; b=x+36+UJ4IzAI5tTR3ffqG7ZUxysuWk4nr1a0h+fMZfTPoZ31l5PBQsLcGz+bRe/vev MM6q1PouljJFjLGAsIulBby2rFmasSIgxaezXKPhkuITSqIMSmbHyjynd8ij0/Ji9rLq JqVD8R36pY0B1mSBfoEPI1hl3VJYOwGPCXFQkmARjcmAhkIjpHcflStfcAz1Oq2kFpBt 00+hhBU1zJ17Hr4vtnkSHUhkL9JraRWEhKnbsUfQTcSgDeS07lV5x+2e5H7FQTfu0I7K WKQd3d8WbhgoSONlRVM8NzgYTKn5l4aPgR0oNbxtaIAmLjZOCV/gd+JmmOEj5XTq49Me YzHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id:dkim-signature; bh=TU5GSQcUsGsLm0QedmIo4Msii85jhaXsQwdtUQuJMSQ=; b=e+6oi2NMJfR++gkPkcV+Ow4q96PUSdobexS+A3+4maev3BqyS0FpKbGOFBUdwV1a4I Jx59T4tzdQeBmcSiZKjONDI/fXYbeRMw1OYMA8Ch3onbmcvvlwrsgpD2l4vyUlPCUXZH w5Oavps2V7oQwecT1mcBa3yYRKHDwzazD2Zdu5C58HO0qcaejtYT9Evn5K+0rs1q6Chh nvmxSrJ2bK6iW1oxAcC/R6oZ+R+Xh2RDqDyIf4qfPqcI8OQP6ez7zwasBBkE2fFLqhtx qvrSpKNXSlV9pjhid1FbwWavchzX1Yc+PJMG1TZxlMUKWpm00z2H48pwIjwpSmRNGa/X L22Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VZZiYWZf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x25-20020a1709060a5900b006db707540f2si1445635ejf.154.2022.03.09.14.34.42; Wed, 09 Mar 2022 14:35:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=VZZiYWZf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231868AbiCISkQ (ORCPT + 99 others); Wed, 9 Mar 2022 13:40:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232677AbiCISkO (ORCPT ); Wed, 9 Mar 2022 13:40:14 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id AF6C652B12 for ; Wed, 9 Mar 2022 10:39:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646851151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TU5GSQcUsGsLm0QedmIo4Msii85jhaXsQwdtUQuJMSQ=; b=VZZiYWZf9hLa/81sh3aCS22+YFCVU6+XIUExDiFMVr9S1cE0THWv/F22FloPEvwU2Uof1Y lLdbzIHIUrxMFuoOz8Pf4bTCzw3DmSQcWsLgLMUQvANrsZyrYmTFy9MToRJPuXBOWMZqJ4 EPf2eTxGwIXTcSxlUY/tVxn1otxIkwI= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-575-NWK8lvi0OVOJjeTASFVorg-1; Wed, 09 Mar 2022 13:39:10 -0500 X-MC-Unique: NWK8lvi0OVOJjeTASFVorg-1 Received: by mail-qk1-f197.google.com with SMTP id bj2-20020a05620a190200b005084968bb24so2140838qkb.23 for ; Wed, 09 Mar 2022 10:39:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=TU5GSQcUsGsLm0QedmIo4Msii85jhaXsQwdtUQuJMSQ=; b=1XSwG3Ms+GcEI02Vp3v2EFz5Ls/wkkmBNN8I0buFFuDb4IyTuS5V74KMAwuhT9kef6 /SWcj1y5Bf/c7CO0lxL/3KWf13o1uPEKFqfgebtajzae2cLIV0YzE8KloqZNspcQmLSn 5NYAsVEbGEEBVQrbvadxCQkIynJUoeUth0LXDRmkk30X/t+P8h4Fveq4vSwLEw9OpQAe VJ5+DTrwvD+8U/j43Fgpq/adUQWgoy0bzFc2tLENSf5vWcROiXd4/HDNNaV19wCvm3Ya bK5NdQkO3w8hn1ICDqOErxvETSGlq1qc09uuYnNIqJMa8tHs2saLhgXWQknHxGcuyczj hbog== X-Gm-Message-State: AOAM531utV3kHef3yJOl7hTOCvlwJhowN6KHZaa8JW27WzvZF+/ndC/a ajIoCa4UwOn4J9ZnbCk56x8DfQq0/mWnrsY9zx6X5nueIDrdQtMbhGmBoqFdcoy07BYM8dXjBSm I/WjlCFZu8o1ZckTm5/502aS7 X-Received: by 2002:a05:6214:d44:b0:435:b8fd:b1d7 with SMTP id 4-20020a0562140d4400b00435b8fdb1d7mr808166qvr.19.1646851150315; Wed, 09 Mar 2022 10:39:10 -0800 (PST) X-Received: by 2002:a05:6214:d44:b0:435:b8fd:b1d7 with SMTP id 4-20020a0562140d4400b00435b8fdb1d7mr808157qvr.19.1646851150152; Wed, 09 Mar 2022 10:39:10 -0800 (PST) Received: from [192.168.1.3] (68-20-15-154.lightspeed.rlghnc.sbcglobal.net. [68.20.15.154]) by smtp.gmail.com with ESMTPSA id t7-20020a05622a180700b002e0ccf0aa49sm1829549qtc.62.2022.03.09.10.39.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Mar 2022 10:39:09 -0800 (PST) Message-ID: <737c8db7461567ec04d5e2a7dbec58b699f8f16c.camel@redhat.com> Subject: Re: [PATCH v2 02/19] netfs: Generate enums from trace symbol mapping lists From: Jeff Layton To: David Howells Cc: linux-cachefs@redhat.com, Anna Schumaker , Steve French , Dominique Martinet , David Wysochanski , Ilya Dryomov , Jeffle Xu , Linus Torvalds , linux-afs@lists.infradead.org, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs-developer@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 09 Mar 2022 13:39:08 -0500 In-Reply-To: <1712592.1646840957@warthog.procyon.org.uk> References: <164678185692.1200972.597611902374126174.stgit@warthog.procyon.org.uk> <164678192454.1200972.4428834328108580460.stgit@warthog.procyon.org.uk> <1712592.1646840957@warthog.procyon.org.uk> Content-Type: text/plain; charset="ISO-8859-15" User-Agent: Evolution 3.42.4 (3.42.4-1.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2022-03-09 at 15:49 +0000, David Howells wrote: > Jeff Layton wrote: > > > Should you undef EM and E_ here after creating these? > > Maybe. So far it hasn't mattered... > I wasn't suggesting there was a bug there, more just a code hygiene thing. With macro names as generic as that (especially), it'd probably be good to undef them once you're done. -- Jeff Layton