Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220308025547.20412-1-sagarmp@cs.unc.edu> <de1b0152-7521-db6f-355a-b906ecbe84dd@linux.intel.com>
In-Reply-To: <de1b0152-7521-db6f-355a-b906ecbe84dd@linux.intel.com>
From:   Sagar Patel <sagarmp@cs.unc.edu>
Date:   Wed, 9 Mar 2022 13:01:50 -0500
Message-ID: <CAMGmevBHM-mrZsNGHK44yhHY8kipiErBf=tgqQZ5E3LgHO49TQ@mail.gmail.com>
Subject: Re: [PATCH] checkpatch: use python3 to find codespell dictionary
To:     =?UTF-8?Q?P=C3=A9ter_Ujfalusi?= <peter.ujfalusi@linux.intel.com>
Cc:     Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Mar 8, 2022 at 2:58 AM P=C3=A9ter Ujfalusi wrote:
> > In addition, when searching for the dictionary, do not check if the
> > codespell binary exists since codespell can be installed via a Python
> > package manager. In this case, a codespell binary is not exported in
> > $PATH, but a dictionary does exist.
>
> Installing codespell via pip will place the 'codespell' executable under
> the user's $HOME/.local/bin/ and it expects that it is in PATH:

Good point, I'll reword the commit message in v2.

> Having said that, the executable itself is not used by checkpatch.pl, so
>
> Reviewed-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>

Thank you!

---Sagar Patel