Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp938239pxp; Wed, 9 Mar 2022 16:27:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJzPzemOmrEWrku/hXXPeZ33Yob+3ZsfnPXARhyrf3nbSX6eVT4u23HHLmwaEcKPBdQ28wyr X-Received: by 2002:a17:906:40a:b0:6db:3e2a:a7ce with SMTP id d10-20020a170906040a00b006db3e2aa7cemr1988246eja.255.1646872039343; Wed, 09 Mar 2022 16:27:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646872039; cv=none; d=google.com; s=arc-20160816; b=lJtMZeFDPLVvpBptSmh/hIh8OhDgK8NoU0MRqzItnf5hxoymOLXXkxowMEaChq+rrY 1A3PryIXpGlIL1rdUw4zwMF79nYi5M5B1sFu5q8tdl9m9dlAJOClhDKDouozChstNYUG sPTcXTllVvRXsvN8Qt4URNqRR1oDrsGAkqiw0pUN1RccPIdr0MuD6ZBSytIF8MGnWICB yL0hd6dpljrvrEq6ojSo+PhOlF4SnBBQiuSa2rLNMXRihLfxHPjnFp/JYg3DKZT4WBm7 puPGPEEDQA5Z9nk2h92e5TRjdMGPZw3VRLYZEf4zngm49l40AAbcwlnyEJcv2SOoS8Ld dtKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=an98V/AtD70mmakLBSFdzl5jNVO5y6gUhFCcF21+EEY=; b=pkeCsjWW9MOAUDJHGFSYbP3mo3OzzHh/Br/mjBCF8K0MsKzfvRmHfqdZxd62qAzNY0 zAhccXAEmkBsyeX/Ld/z4stvjstr6MkFDz1vYu8MGS90x5kjWGDkaUGGOVFecQX73li9 v3w9/EWFgx9/EVs3YqGWPHC1NLDJe24jsnKPNn5Jqh1NMmmTunrEPG8PBSg2U8uc4fyM yS0pmwIW0Tjs83JXaoQPKmMwJO+1C5OU2WcCMpAs48ynl9SkrjXUzBVT1pi3bHZovdwH YjXgkKeOK1HBy0JwtGMde8TLZQOXw5On0SrEpo4ZcAIZE8jFpV2auK3kDm2UpM20lgKO 65bw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=hkaigC8u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u12-20020aa7d88c000000b00415f69620b5si2380384edq.0.2022.03.09.16.26.56; Wed, 09 Mar 2022 16:27:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=hkaigC8u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238650AbiCIWar (ORCPT + 99 others); Wed, 9 Mar 2022 17:30:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235018AbiCIWap (ORCPT ); Wed, 9 Mar 2022 17:30:45 -0500 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79204120F6F for ; Wed, 9 Mar 2022 14:29:46 -0800 (PST) Received: by mail-pl1-x636.google.com with SMTP id h5so1844586plf.7 for ; Wed, 09 Mar 2022 14:29:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=an98V/AtD70mmakLBSFdzl5jNVO5y6gUhFCcF21+EEY=; b=hkaigC8u1dOWV+Y/5WrTIaGgDw4SwziAkNwHjOw8BmC31/Ct8FXN5F8ZhWAfCZ6uzD OktEgyyX9trBlsz3TDvRCHXCTwP52EEadSYoQHbmAvslrJHY2aX+WoYHjAnSXrBDTiIk xroa7D2C4E/Co3wqm/f/619kWbsiafU9NMdx0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=an98V/AtD70mmakLBSFdzl5jNVO5y6gUhFCcF21+EEY=; b=aZh+m3D2xT7d4bBg6vCmvTsOWvBA/je30e+YTrlLdg5+IgzXrgk8TeFdVDUiQ4hJtj nJptnoBCPO29F24l9p52oAsT2LNxFGARYnAOTCuQt1FMy/AzNSm+2hxgN0X+qR00vmAG t1DMIfjMFHR6aD7xkZAmr7scgcwvrXvDmxQwXRdIfL+aPmZyhNqWoic+WgDv6k6t33Rc 0kHqn55d/zV5iwDkoS7IouJYhVa2gr0/DCb52EHdN4sT09CVOTGpru4q8XwzJC3Uwl/8 K3c1G46EgKID8PFdVmkpP3MuFLrxxl2C9QyQcGKId029OXXYFvURqJZdN2mrZi4zFcf+ MmXQ== X-Gm-Message-State: AOAM532e/3HMwv3mgK6SZOWvxtHZ3L1Vfu59LiNNAUgn0c4rDh7VjTsS jGeCRpXVBBLgTdkcHDq/6Wey4w== X-Received: by 2002:a17:90b:4f43:b0:1bf:4f89:1270 with SMTP id pj3-20020a17090b4f4300b001bf4f891270mr1783872pjb.202.1646864986044; Wed, 09 Mar 2022 14:29:46 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id f21-20020a056a00239500b004f70be86728sm4303064pfc.214.2022.03.09.14.29.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Mar 2022 14:29:45 -0800 (PST) Date: Wed, 9 Mar 2022 14:29:45 -0800 From: Kees Cook To: "Eric W. Biederman" Cc: linux-kernel@vger.kernel.org, Linus Torvalds , Alexey Gladkov , Kyle Huey , Oleg Nesterov , Al Viro , Jens Axboe Subject: Re: [PATCH 05/13] ptrace: Remove tracehook_signal_handler Message-ID: <202203091429.08136CF@keescook> References: <87o82gdlu9.fsf_-_@email.froward.int.ebiederm.org> <20220309162454.123006-5-ebiederm@xmission.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220309162454.123006-5-ebiederm@xmission.com> X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 09, 2022 at 10:24:46AM -0600, Eric W. Biederman wrote: > The two line function tracehook_signal_handler is only called from > signal_delivered. Expand it inline in signal_delivered and remove it. > Just to make it easier to understand what is going on. > > Signed-off-by: "Eric W. Biederman" Reviewed-by: Kees Cook -- Kees Cook