Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <952b68c0-6316-f8fe-16a6-80b85f4d9744@amd.com>
Date:   Wed, 9 Mar 2022 23:17:40 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Cc:     Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>,
        Brijesh Singh <brijesh.singh@amd.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Peter Gonda <pgonda@google.com>,
        Bharata B Rao <bharata@amd.com>,
        Mingwei Zhang <mizhang@google.com>,
        David Hildenbrand <david@redhat.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH RFC v1 9/9] KVM: SVM: Pin SEV pages in MMU during
 sev_launch_update_data()
Content-Language: en-US
To:     "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
References: <20220308043857.13652-1-nikunj@amd.com>
 <20220308043857.13652-10-nikunj@amd.com>
 <421f4fba-3e1c-b676-d74c-02c6c3f804d2@maciej.szmigiero.name>
From:   "Nikunj A. Dadhania" <nikunj@amd.com>
In-Reply-To: <421f4fba-3e1c-b676-d74c-02c6c3f804d2@maciej.szmigiero.name>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VmpNc1QxRE9nQjF1bWlBaU9lNWF4em9Fd1R2TlVjMG4rVHVSWGF5UlhrSVVv?=
 =?utf-8?B?c2Mrekx6Q3ZVdFlzUkx0azFyU2dud0VBZVZwSmhYY1RNSm1LRFVqanFFcFRL?=
 =?utf-8?B?QkovNGcrRGRKL3BWNnFDSW1SaWtlSkJxYVJzNGRLQ3NJY1dNK0t3WWJOaFFB?=
 =?utf-8?B?N0plRlFjMGJoS2xaQ2wvZXl5Y2dxM1JGYk1ZN3R4U0RjWjBDUlhjWmhBRUFZ?=
 =?utf-8?B?MnpFS2R4dEJ0SkxwczI1WFIwcDY3MGhIdWtrblRQaUtTcUZ3ODN5VkFyaDhY?=
 =?utf-8?B?bFpsenJ4dFNrczlHWUxFTDV5dUQ4Tkd0T1pIVmdacUs5ekx2c1YxVWtjM2NZ?=
 =?utf-8?B?LzU5VXA0bVc0T0EyVGVkQ0swQjkwUEdOZWI0MmJrNTdFNG9VQ0J4WjdtMW1J?=
 =?utf-8?B?Y1MyKzlRNmNVMUZheFRGQkZOenlYR1o3UlhaWmMwNlk4VHFtdjFXU0dGdm51?=
 =?utf-8?B?ZEJUY1MrcnJkbXNYSys1eFF5LzJpZXRVcmR5L0w2RmFPLzdRM0VhOGU2cHdN?=
 =?utf-8?B?VzhXWmIySUVQRG5ZWWdKOUdJYi9QbHdMbFJLeEdXekVZTkJmUGx4a3ZxQ242?=
 =?utf-8?B?ZElJa2t1cmJuYVNmNEZBSXpTaGJtcDlXNFJmbE5LRTYrWlFiWjVyU0M3N3hR?=
 =?utf-8?B?QkVJbFRMWDNOcDBpVjA1eCt4dGFTK2Vid1FvMS9ReDZHZXI3UnlGOFR2M0Iv?=
 =?utf-8?B?MERlVHBOb21paTdnNlczZDlFUTk3VVowLzIzK2FQbWpTQ2dodUVJV2V3SXpw?=
 =?utf-8?B?ZnlCSWJKQ29CUTlYdTI3NkphcUlHUEpGN3JtK1pSeUMxeWF5dnB2d2NjVjg0?=
 =?utf-8?B?WjBDbHFlV2ltUkNqUnYyUFNhZ0o2MmFWbXVadTZTc1dGR2twRE1obHU0bnJ5?=
 =?utf-8?B?anIyakNkRWR3ZnpicGdiZk1zSThkS2luR2dRbWg2L1hFS2t4M0lhWDdQRmhx?=
 =?utf-8?B?c0RERXJRaVZySW9EVVdiZjRlRURoWUZYZVg1eW4xZ0YvRXljdjZjY2g1ZzRE?=
 =?utf-8?B?Smp6dldTUldsWWNjdWpZWmIxVzBIK1lmQTR5SEV3dkk1S2JVN2UyWkQzWHll?=
 =?utf-8?B?azd0SW1aY1JIa2ZKSy9sczE5VHpJNzZwbmFFQXUrc2J4T0VleDlUcjl4eHJo?=
 =?utf-8?B?a3EvT1pZZSs0NEU0Uy9DeDMxNHJrL3RPcTNvb1JrNXM3R2dhUW1DQXVuclph?=
 =?utf-8?B?ZitESE85dHI0bENMVkdnZGxZdTJ3TjYrajhacFdzdnVpMUw2MHpxRmsrVnFB?=
 =?utf-8?B?dFNQbXZwUzFIZ2haMjJlS2krZTNCbE9KZUdCeHdMVHpybUVDaEtjblpiKzhn?=
 =?utf-8?B?czcvNklTa1NxejZlc0RIdTRhR2ltMDVzWmpiaHBobFlySnQ4YUlMYW05MEtv?=
 =?utf-8?B?SXQ3cU1mUTN3ajZod0ZXOTIwOFFuME5uRHg5NUVMdW16Z3BxMjZacjUzVlhJ?=
 =?utf-8?B?czF2dHBEaFNKUmt0UHpPWnR3QmN1K3M3MHhvMEtpL3FEWERLMzZ3ZGlIbEln?=
 =?utf-8?B?RlU1aVFNVitTWXp1TEdEb2RVbHZObm5lOXB2WTN1RkZjMCs5QUZCSnpFaDA2?=
 =?utf-8?B?Rnd5Z0RMVHNQbXIxeWJTalIwclljZ0Z1aEpQQVQ4ckw0ZGpTRTRlcndVa0Jx?=
 =?utf-8?B?WHVGU2d2Sm1lOHM4LzhRVHZBMGVOK0hNbGFiaVZNN1FNRG5tampUL0RUcWJG?=
 =?utf-8?B?cFlOR0xhUnRoTEd6VFl2YzlkSlpPeXZMbk9zRXpacnhPeTRYZ1NvOUtNZXIv?=
 =?utf-8?B?ckVDaDJsREhlMmp6WTNHRklpWTFRQnVwWDR2ZU1DSTdHUXdnMXhzSGV6bVZZ?=
 =?utf-8?B?bkxROVB6UDJCVk5BajdsL0c2RnFBbkNEWSthVHRoNzhycVBTVEhHMnFlYTFS?=
 =?utf-8?B?bTNKZ1Z6WHRnNGRDVThGVC9VYjBjS3RNKy9FcGFxVmgwWTcrQVNrWHlEcVFJ?=
 =?utf-8?B?Y3dUZmcvaXNzRWl5dVprU1cvcy8vRTh6OG1qUHd0UEhBQU45RVc1RGhyZE4x?=
 =?utf-8?B?aE9lUTFTZ3VyTC85c01kREZUd0VYQzlCYjdMaXB2a3J1dTJWQmtzcDNrOS9J?=
 =?utf-8?B?NDFqemlPbGxBalNIVnF6S1NXT29CS2xIc1FmR0ZiTVNVcTc0VFlUREoxcmpi?=
 =?utf-8?B?UUxmRU1hZHFTSWdXeExDOTJ2SG9Wa0VjWTVEdFovREQxL3A0NDB1RVRJMWI2?=
 =?utf-8?Q?JHIxeN1bix04uaykjaFtyR4=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 049f7778-4555-4993-5a3d-08da01f4f073
X-MS-Exchange-CrossTenant-AuthSource: SN1PR12MB2477.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2022 17:47:54.8773
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tBz79trXDE0icK85abkWqtVlmJsSc7gpTcLKMO3YZ3DG9tt4AlU3BK3nSjKKqJIFmKEtui1fWUVh28LSQM4k5A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1503
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/9/2022 10:27 PM, Maciej S. Szmigiero wrote:
> On 8.03.2022 05:38, Nikunj A Dadhania wrote:
>> From: Sean Christopherson <sean.j.christopherson@intel.com>
>>
>> Pin the memory for the data being passed to launch_update_data()
>> because it gets encrypted before the guest is first run and must
>> not be moved which would corrupt it.
>>
>> Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
>> [ * Use kvm_for_each_memslot_in_hva_range() to find slot and iterate
>>    * Updated sev_pin_memory_in_mmu() error handling.
>>    * As pinning/unpining pages is handled within MMU, removed
>>      {get,put}_user(). ]
>> Signed-off-by: Nikunj A Dadhania <nikunj@amd.com>
>> ---
>>   arch/x86/kvm/svm/sev.c | 146 +++++++++++++++++++++++++++++++++++++----
>>   1 file changed, 134 insertions(+), 12 deletions(-)
>>
>> diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c
>> index 7e39320fc65d..1c371268934b 100644
>> --- a/arch/x86/kvm/svm/sev.c
>> +++ b/arch/x86/kvm/svm/sev.c
>> @@ -22,6 +22,7 @@
>>   #include <asm/trapnr.h>
>>   #include <asm/fpu/xcr.h>
>>   +#include "mmu.h"
>>   #include "x86.h"
>>   #include "svm.h"
>>   #include "svm_ops.h"
>> @@ -428,9 +429,93 @@ static void *sev_alloc_pages(struct kvm_sev_info *sev, unsigned long uaddr,
>>       return pages;
>>   }
>>   +#define SEV_PFERR_RO (PFERR_USER_MASK)
>> +#define SEV_PFERR_RW (PFERR_WRITE_MASK | PFERR_USER_MASK)
>> +
>> +static struct page **sev_pin_memory_in_mmu(struct kvm *kvm, unsigned long addr,
>> +                       unsigned long size,
>> +                       unsigned long *npages)
>> +{
>> +    unsigned long hva_start, hva_end, uaddr, end, slot_start, slot_end;
>> +    struct kvm_sev_info *sev = &to_kvm_svm(kvm)->sev_info;
>> +    struct interval_tree_node *node;
>> +    struct kvm_memory_slot *slot;
>> +    struct kvm_memslots *slots;
>> +    int idx, ret = 0, i = 0;
>> +    struct kvm_vcpu *vcpu;
>> +    struct page **pages;
>> +    kvm_pfn_t pfn;
>> +    u32 err_code;
>> +    gfn_t gfn;
>> +
>> +    pages = sev_alloc_pages(sev, addr, size, npages);
>> +    if (IS_ERR(pages))
>> +        return pages;
>> +
>> +    vcpu = kvm_get_vcpu(kvm, 0);
>> +    if (mutex_lock_killable(&vcpu->mutex)) {
>> +        kvfree(pages);
>> +        return ERR_PTR(-EINTR);
>> +    }
>> +
>> +    vcpu_load(vcpu);
>> +    idx = srcu_read_lock(&kvm->srcu);
>> +
>> +    kvm_mmu_load(vcpu);
>> +
>> +    end = addr + (*npages << PAGE_SHIFT);
>> +    slots = kvm_memslots(kvm);
>> +
>> +    kvm_for_each_memslot_in_hva_range(node, slots, addr, end) {
>> +        slot = container_of(node, struct kvm_memory_slot,
>> +                    hva_node[slots->node_idx]);
>> +        slot_start = slot->userspace_addr;
>> +        slot_end = slot_start + (slot->npages << PAGE_SHIFT);
>> +        hva_start = max(addr, slot_start);
>> +        hva_end = min(end, slot_end);
>> +
>> +        err_code = (slot->flags & KVM_MEM_READONLY) ?
>> +            SEV_PFERR_RO : SEV_PFERR_RW;
>> +
>> +        for (uaddr = hva_start; uaddr < hva_end; uaddr += PAGE_SIZE) {
>> +            if (signal_pending(current)) {
>> +                ret = -ERESTARTSYS;
>> +                break;
>> +            }
>> +
>> +            if (need_resched())
>> +                cond_resched();
>> +
>> +            /*
>> +             * Fault in the page and sev_pin_page() will handle the
>> +             * pinning
>> +             */
>> +            gfn = hva_to_gfn_memslot(uaddr, slot);
>> +            pfn = kvm_mmu_map_tdp_page(vcpu, gfn_to_gpa(gfn),
>> +                           err_code, PG_LEVEL_4K);
>> +            if (is_error_noslot_pfn(pfn)) {
>> +                ret = -EFAULT;
>> +                break;
>> +            }
>> +            pages[i++] = pfn_to_page(pfn);
>> +        }
>> +    }
> 
> This algorithm looks much better than the previews one - thanks!

Thanks for your feedback earlier. 

> By the way, as far as I know, there could be duplicates in the "page" array
> above since the same hva can be mapped to multiple gfns (in different memslots).
> Is the code prepared to deal with this possibility?

Yes, as the pinning is done with pfn as index, it can get pinned multiple times. During 
memslot destroy path they would get unpinned.

Regards
Nikunj