Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 9 Mar 2022 22:12:00 +0000
From:   Yazen Ghannam <yazen.ghannam@amd.com>
To:     Borislav Petkov <bp@alien8.de>
Cc:     linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
        mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com,
        rric@kernel.org, Smita.KoralahalliChannabasappa@amd.com
Subject: Re: [PATCH v4 10/24] EDAC/amd64: Define function to get Interleave
 Address Bit
Message-ID: <YikmMHYpdehehD9F@yaz-ubuntu>
References: <20220127204115.384161-1-yazen.ghannam@amd.com>
 <20220127204115.384161-11-yazen.ghannam@amd.com>
 <YgpGyceWKsIVYuGv@zn.tnic>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YgpGyceWKsIVYuGv@zn.tnic>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?n2NuzkGh/T8+pJMqBCH7VxWPhH/5uFldAO6xBLlysHQWa0byw72x24L+ABNQ?=
 =?us-ascii?Q?/MOn871c8gxrqtMLE2MUhATkBUPLgI7OZITP8SbF1YXl+SLmuVXLIffnYcNX?=
 =?us-ascii?Q?DZaVW4pL3MtLujJD4kJ8ajvYYpJZDauqLCtahSEEXepP5FQqSO9nytEKrr2s?=
 =?us-ascii?Q?tLJQBA7gi8v6QFEkEHKMdVrIPTO1pdzVx927InzNTV1jqv3Puav2ws0D6B0M?=
 =?us-ascii?Q?nvFQwsj2ag0b8/Dg8xgDsk26mZlJ/5gcLRL75I84E4EHhpzSGetHrKuOPdle?=
 =?us-ascii?Q?FUjk63lQN351wur17OHPxFzxhrRt/v+f+uzCh2yiGMBqENf6MBnmhX3KLHLp?=
 =?us-ascii?Q?+4cHmsgRpCZJ56U59VHWZmHH826KOWeLT+rnMWFXjoICtsIFmug10yy8RNSQ?=
 =?us-ascii?Q?8tJ2wM2sxg55E53jt6k4i4gycs1/i1ay0T/PSO/IAKHMZ3KsGo2E5YJi0gBM?=
 =?us-ascii?Q?rmgBq7RKwzTQvsC+NMtMp9V44FQqSy+CI/1kmH11HAcG2GIrgx8O2b3gHmGD?=
 =?us-ascii?Q?OpzvrhEIWWA/kKa2Nl8xYynfOZxdC2lOT5F4HGulB3mGgdvsO/StpCKkAw8M?=
 =?us-ascii?Q?rc6mCahb5Lw3ndiN4lySnKrpUSVYlNXuyz/G8rC4NR/MgPoh4BZYT+sbR2/2?=
 =?us-ascii?Q?CLHHf6u8K4v9ba31RHp/WybJS/m287P8SieRt5JKe42BbjE5qnM9PH9S7xD0?=
 =?us-ascii?Q?shyITCDRALPhaeZ1jEHtQtgIU+JT13NKAg2uUY+fRaC0juZoemR1TMdli7Xn?=
 =?us-ascii?Q?DNI4PNN/47nj2PdDLeEy3z8FpRh/VfoT9ISBf+dMoSByILDhGccBnlC1ZS24?=
 =?us-ascii?Q?vGdy+oqRCHmIZYnT5MXoETHDMRNk45oD16JI+EW4hK9M25vaTHfurt8pPf4F?=
 =?us-ascii?Q?r8dqFIIMBPdw+2UkKwyOEZIHvK10+iFXfKO8g0HU8xjDj/XIlfSibnKQvUyd?=
 =?us-ascii?Q?YOJPw+NO96igTjYEM6GSdiAGhRt7F5Ef6FzzvcOpSozeJru4uJzCp3yf8SJv?=
 =?us-ascii?Q?2+EiirWfV86oT8Ipbs18UfGz3VtrD5+5DER0D3U45Y92fG/wDOyCVZ4Twv3v?=
 =?us-ascii?Q?O5eom2a/DiQ1wpCHe7Jc7ECS2kzFQyJcTkucrsTWCsv+aSy46kRzRwYxaEOO?=
 =?us-ascii?Q?sRsBcydOG4yUVph6pl/b/yEE0pdIBkkYs5IxjJrYE3wQW/rYPBA+wSD9GDrg?=
 =?us-ascii?Q?OzYVpIXGD7NAeDNxZzVulhW88PGMLGX2HsiOYXfNsAFgX/dhIBKLXb+0cfFE?=
 =?us-ascii?Q?4nhR4vGlh22qdUoGAzQUL8Bx7CUMvoGauc1a1DQ25kRcgoxtiTB74eZMSESP?=
 =?us-ascii?Q?guicEfZKiMBMf2ydevMBYzQvYb04To+eXpBkYQTH5fxLBhWqR0W8LP6BJEEU?=
 =?us-ascii?Q?R1cA9LUyLeNwwdm7tksiiFPTw6GiRe0kN0qsS7KLMnnH4K1PfH38B71xY5s+?=
 =?us-ascii?Q?7TwNMJTfgc4i6KCR49NMAqzPyQPL6jAbUDCR8a/3rxrXbUnMWR8gw+0sMMNL?=
 =?us-ascii?Q?auyNd9vWuu5JciqJW2N9kd9mPyVHE9ucHdO0PW3n65aWvtxIe7peKYsCvRLi?=
 =?us-ascii?Q?/D3oP6rrxfcRvE0d1nNBQC9G/OX8DyjvjMMh7O62ZfZ7uw+ZcMFvC4W4Hn1a?=
 =?us-ascii?Q?UA05GTbeB+ePsyOb7GmcYgk=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 19f825df-b3d3-4cbf-3b87-08da0219d859
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2022 22:12:05.5229
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UO+H/Z+T+FpAPGECzgugX0R55GEOVXrrD+YXKgE4k9cpCLcSKErUFv705LGhUm2SwJbN+7lsONKJbpHCK4X/kA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB3748
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 14, 2022 at 01:10:49PM +0100, Borislav Petkov wrote:
> On Thu, Jan 27, 2022 at 08:41:01PM +0000, Yazen Ghannam wrote:
> > Move code to find the interleave address bit into a separate helper
> > function.
> 
> Same question: what's the point of this change?
>

Yes, I'll update this.

Similar goal as in other places. When the function seems sufficiently long
(subjective I know), break it up into helper functions.

I've been trying to decide based on logical steps. Do you have any general
recommendations or rule-of-thumb?

Thanks,
Yazen