Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8a8f7205-32c1-0618-a29a-c3ef66357681@intel.com>
Date:   Wed, 9 Mar 2022 16:28:27 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [Intel-gfx] [PATCH v10 3/5] mei: gsc: setup char driver alive in
 spite of firmware handshake failure
Content-Language: en-US
To:     Alexander Usyskin <alexander.usyskin@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
CC:     <linux-kernel@vger.kernel.org>,
        Tomas Winkler <tomas.winkler@intel.com>,
        Vitaly Lubart <vitaly.lubart@intel.com>,
        <intel-gfx@lists.freedesktop.org>
References: <20220308163654.942820-1-alexander.usyskin@intel.com>
 <20220308163654.942820-4-alexander.usyskin@intel.com>
From:   "Ceraolo Spurio, Daniele" <daniele.ceraolospurio@intel.com>
In-Reply-To: <20220308163654.942820-4-alexander.usyskin@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aENGbm9GWnExc0RwczAwQm80TUxaT3ExdVpFbFBtcEZmNFJZM3BkT2xVQ2lr?=
 =?utf-8?B?NSthWGozT2NGMEcwRUQ2My9zYjFKNHNBZ2N4cTgyMENLRmttbG5MUkplK0Er?=
 =?utf-8?B?Z21MMGt0eU0vU1hrVjBIMDVhbFJieklFN0RnUlJCTUJ0Q21aT016N3dnTEQr?=
 =?utf-8?B?Y1VPVlc1aWl4dDVjU3NCSkpIZWtRSERFQlNkZEI3MkZmYU9PYlorUWUzSDc4?=
 =?utf-8?B?WXJLVVdvanBzcDNGRjdtdzRLc3RwZUQ4ZHROU1FVeHBXS0lOclJBRWJLQkxi?=
 =?utf-8?B?MjRNT25jVjVNK0VlciszYVhLYytyVE8vT2pTSldVa3hGN0p3U2E5M0pqTkUy?=
 =?utf-8?B?OVI4dzdnLzFub0t0d090c3VpV3JETCtKSlRQVWtEYllxVEZuQUpDd0c2VEtO?=
 =?utf-8?B?SzUvY2htdVpZWk1CUjZFVGVjUTVlTEVHZ2lhQ2wySTlOcngwdUpDTTJ2MmZS?=
 =?utf-8?B?SC9FQ0k4T0k3Wk1KOVUyUHlkclA0T041RDV5Y1hZemVNQ2s5c3puS1g4ZC9Z?=
 =?utf-8?B?WTRoSEJDZUFrZzFOYS8yRDRnOTBSMVRlemNwQlFtd0xBLzM4bWhWZmRHMDht?=
 =?utf-8?B?alhzOUFadE5RbHFFSjBmN2tNa3FHNmdGaXc3bWRKMkNlS1p0NHlYNGpYbHE0?=
 =?utf-8?B?T2JnTHZ0OWZSTVkzWTZlOVI3UUI3VWJKUEFYb0NYL1ZubEdOeXdxSkE3YWFo?=
 =?utf-8?B?Y1lTa1IrVVBDdy9GZGhjcWx1Zm9TYWh2UmZjR3g1VThvcDdZVytjNnNGaUJr?=
 =?utf-8?B?ZjNreU5TYzVrRHp6U3YzaTQ4RXIvbTdtOFFlTDlLRG5FYzhoeVhqT2FkdTdC?=
 =?utf-8?B?SUxJNys3L1hWWnVLNkNNTHZpNitRK1k3T0ZlSHNPdUEwY2JzVzg5b3ZNcnlT?=
 =?utf-8?B?VVZMSjZrcjNEL3dTOGVXVGhlUGRXL2FFWm9DTEpDelRiNVFNNmxZditvdktP?=
 =?utf-8?B?S3MvYVYzdnZ1clhqcDN2OEtNNmU5WHl3YkQxN3pIU25qQkNzdGdvdkg5V2g5?=
 =?utf-8?B?TWh0ZDZQdm5IdVlqSi93c2VwR21mc3VIb3Frem4xbmxkQUMzNlM5ZlBzdUpr?=
 =?utf-8?B?bHhFNlJ5d0RIV1haV1M4NzI2dU9Mb0RnbGlGV04yVEtEN3J6Zkp3TWpWV2Rm?=
 =?utf-8?B?cjY1SE9QU2FJVWdmdE9UVlNPRThWdU03b1ZuNm9VbXQxYVE5b2RIYW1VS25T?=
 =?utf-8?B?UEZKd2Q5S0U5cVBqNHUyZm51VG96SkRSTms1K25lQjhxWCtlbFRDMUNPazBN?=
 =?utf-8?B?Yjk0azBhSnJOZ01QSURSdlZkeWtiK0lJVVJYbEdHZ3ZoK1ltRVNvU0RaVyts?=
 =?utf-8?B?NVM3dXJGbFA5c04ySUEvNmtyUWJ6ZzU1YzFtbDBMajBLcWxFR05BUWEyb2lG?=
 =?utf-8?B?ZE1JbnZlR05oekExZXdtMFp1YUFZdlZidy95cmtOWWdkbkZvQktDNFA3MW1R?=
 =?utf-8?B?eEoxUHNGVThvWC9xb3BYcENveGZDenBKdWlqK1dwTVBKMUZEeklIYUNPbU4w?=
 =?utf-8?B?UWV3Um5NeGdSU29pOGllSCtlZzl3WnpNRm5TQXJQOGZhd2VERGNLVDBJRmhB?=
 =?utf-8?B?cHZtSXlmMnEvSXBIeXh6ZkZJcWhYTitUelZnTGRrYk1NL2JwcDlxTXhVVlpx?=
 =?utf-8?B?U3VVZnR4d0RXbDk4aUVyYWh2YWlZTnBpa2pMbzBncGIxMGRSaXZKalVOY1Jw?=
 =?utf-8?B?dE5oQnJHR0dEWndWZXh3VTZUcUNmZDlwZkYydDMrbEZTd0NOWitwWHNVSEln?=
 =?utf-8?B?RklWZTBRaXBPWUJGRHJRVnhsUnk0OERBeUJSL0RZWmpyeWJMcDdQTDhoVTVE?=
 =?utf-8?B?ODdXSlF0U0RiZStjSkYwd3IwNERSWmVjMmg4QTFLV20rRG13NnVsYzVpbXNU?=
 =?utf-8?B?VHFQY2VVNWFyRnJjNnhxMU0vQXJWUWNXcEZiWGU3cGZlRENILzdlLzBQNldH?=
 =?utf-8?B?L1QrczdHNVVJZC9rV0ZObnlXR3ZoWVgwMitneWo4RXA5Sy9IVWVWZ1dwU3lZ?=
 =?utf-8?B?VmxGbmZ1K0svZFBpQTU0ZWZwSFBPNEk0d1loWTA4WmFJMGlOMEZDVytqQml3?=
 =?utf-8?B?U2JRRFVCeWlJQlZKUVVoOTBtWVBKNUpwcXNDQzlwcUFZWUpCangwdUNZM1F2?=
 =?utf-8?B?T1c3ZTMvMFlEaG5QdzVCVUNSbG9QUVZieFI5LzlIV2d6eU5qVE9PMDVaSVdQ?=
 =?utf-8?B?RVRaRGdxNVFlYjU2RzZVUzEwZCtrVjgrcVdCSXNxNVRJdWlqUFpheUI2eWJ1?=
 =?utf-8?B?QmlWQUhabENoelpRbjZYbTVYY2NRPT0=?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ffe414c-366b-428c-160f-08da022ce739
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5488.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2022 00:28:30.8690
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HLagAZEVRRqiBlmOIPU6XVvgbGZO2cHGPln0pbO+tzl0RTEa86jZwHC7MBKrwkIw3+NjwStB+l7k/CSeP+NAx2xiCgTOfou89BS1BLlj6Ug=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1345
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/8/2022 8:36 AM, Alexander Usyskin wrote:
> Setup char device in spite of firmware handshake failure.
> In order to provide host access to the firmware status registers and other
> information required for the manufacturing process.

IMO this patch should be moved to after the patch that adds the logic to 
fetch the FW version, as that is interesting info for sysfs. Not a blocker.

>
> Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>

Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>

Daniele

> ---
>   drivers/misc/mei/gsc-me.c | 11 ++++++-----
>   1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/misc/mei/gsc-me.c b/drivers/misc/mei/gsc-me.c
> index 0afae70e0609..cf427f6fdec9 100644
> --- a/drivers/misc/mei/gsc-me.c
> +++ b/drivers/misc/mei/gsc-me.c
> @@ -79,11 +79,12 @@ static int mei_gsc_probe(struct auxiliary_device *aux_dev,
>   	pm_runtime_set_active(device);
>   	pm_runtime_enable(device);
>   
> -	if (mei_start(dev)) {
> -		dev_err(device, "init hw failure.\n");
> -		ret = -ENODEV;
> -		goto err;
> -	}
> +	/* Continue to char device setup in spite of firmware handshake failure.
> +	 * In order to provide access to the firmware status registers to the user
> +	 * space via sysfs.
> +	 */
> +	if (mei_start(dev))
> +		dev_warn(device, "init hw failure.\n");
>   
>   	pm_runtime_set_autosuspend_delay(device, MEI_GSC_RPM_TIMEOUT);
>   	pm_runtime_use_autosuspend(device);