Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Guo Zhengkui <guozhengkui@vivo.com>
To:     Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>,
        Alyssa Rosenzweig <alyssa@rosenzweig.io>,
        Thomas Gleixner <tglx@linutronix.de>,
        Marc Zyngier <maz@kernel.org>,
        linux-arm-kernel@lists.infradead.org (moderated list:ARM/APPLE MACHINE
        SUPPORT), linux-kernel@vger.kernel.org (open list:IRQCHIP DRIVERS)
Cc:     zhengkui_guo@outlook.com, Guo Zhengkui <guozhengkui@vivo.com>
Subject: [PATCH] irqchip/apple-aic: application of sizeof() to a pointer
Date:   Thu, 10 Mar 2022 13:02:38 +0800
Message-Id: <20220310050238.4478-1-guozhengkui@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ppB6ACaUV3sidD+2q9lgSwbnnqqoEJQ/58mgUJ8ZYNq3R2XszO7Ki6PwrfoG?=
 =?us-ascii?Q?pHfzAUIj9+qQAqyDBUqzcy0YcC7Ew0Xouh52J55l3brZLUP0zcgdHh67CxZE?=
 =?us-ascii?Q?m417vBGj6l2rOySU+/RIhyUr/7tlUKe6H7Xw9wb/8S401jzmD1zM/29DjZFA?=
 =?us-ascii?Q?QlfiBHOWq0/HrHvOsalWWL9ot1WBBXa0YFrEQ8DKr4fjAkeAjaJdn35APq4I?=
 =?us-ascii?Q?8xTI0tDs/oNb1JVCJ5CyEeEv1s5ilv8UZ5tSAE4Nu46G9iPGbeRkPDwMHWEv?=
 =?us-ascii?Q?UTOyUyxQKv4QzafrZzpALMu8xjB5y4PmrH2XjExIcf0VTJJFOVdptUyB5gG5?=
 =?us-ascii?Q?IL75+FaZXZ0CcZqyzf3gyV6YlkbbKjbaOEYOSvFkxCcauT7HFBoJaXJMKGGH?=
 =?us-ascii?Q?W7zpyq++WC5QBj6T6a94IvrcsNpNFpQ1kluXPCFkTEVzqmWcgdomrc1WsEem?=
 =?us-ascii?Q?7hs4AUphQ7olO42tYtcJ0fxqr3fGz0fGF2UkON6YvZ6a+L8GPJNWc9pOpymk?=
 =?us-ascii?Q?9ZLIer6irnte0s4xgG5oiZKA7HEcZKNwGFqr6PTyfAiW7697pQn2fTDmCwYN?=
 =?us-ascii?Q?37rkCXtY22/7Qqya2GxJBSk6KsgrEGiwZXaka61BOds5G7V/KLaWP2Q/sHZT?=
 =?us-ascii?Q?c9KS7gEF/ayiODmYlTTMxmesss6N2MrW5VbFYRgGWZ9S6MTBKvzUqGssBRrP?=
 =?us-ascii?Q?Bvo+aSQVZEJ5i5/m4XZUTk44+BaETXneQ8zGlfHYdooz10LLguNBAo06mY6n?=
 =?us-ascii?Q?+v2/hUtmajI+hClGKMDyjEY8xbkTF3+uetCjA2AKdOvsiDCeH5d5+Pz0FtQ9?=
 =?us-ascii?Q?t6X0G0rGuzVNPGu+K8wvEu4UlD2mErAKERmRsV3QPDo/6nvsMTFZrLexfCBs?=
 =?us-ascii?Q?wjpB9HnoJzrP3W81Ptfu2ZduYRZTlSWdoIOiPw0b9e8ETW75p1vuJL+7yzEE?=
 =?us-ascii?Q?LEzDpfSxc4WWahAd9kyNyvgy5DHL13LfkSAwhwRkKg/S4uvMEzusCXMefoGd?=
 =?us-ascii?Q?oYA1Tru5qHTfdIpEl0wZX5NN4jhk/d8TCyQ5txDcCGaY7hQG/UqPRZLrfqtP?=
 =?us-ascii?Q?qdnCybQfNxQVeJ4n7XeXjXIPP/yDuga8nqhQr2+40Li/NKplWN97UpBO8zJr?=
 =?us-ascii?Q?y3Zb+Iuoh1Gc9b3DAZnGtu/mwoM7EX70DOQ5IgJ4t0UE46ExXed08A+VmQpG?=
 =?us-ascii?Q?eex7YZfWqKGbHdiA6HT5NWGb6GRH8rpP+ElbsI4crN+WYaxBIrdH5QtpKjK1?=
 =?us-ascii?Q?JAS+GCxk7BPPanZ9Kx4+qorQTmTZu5prH4drcrBjHSjfGbu0Lf9RNu8M1G3J?=
 =?us-ascii?Q?864DDJodfiLdxftsbzz0mKr/LReuxgHb45vgDhB85iCb96hdglAvYmetv+I8?=
 =?us-ascii?Q?s5tij1u0YfLojBwTjEXEwCw/bm04T1HY9N+OlxqMQptFg6/CJAvxmDR4n74v?=
 =?us-ascii?Q?szrP4nzCFcQqKbhxKm/yJMyuHxKQ6KyT?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 78c55d8a-51a6-4054-1976-08da02533a60
X-MS-Exchange-CrossTenant-AuthSource: HK2PR06MB3492.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2022 05:02:51.4389
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Hr4LvWjGV47Kd4+3/GN/she1LrKfqbr1lY1Db4lauOnrVz3ByEnrbP79FsoyXCsnMtqD4ctuahxDSjaCY6ENtQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB5326
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

`ic->fiq_aff[fiq]` is a pointer to the unnamed struct.
`sizeof(ic->fiq_aff[fiq])` intends to get the size of this pointer. But
readers may get confused. `sizeof(unsigned long)` makes more sense because
`unsigned long` has the same size of pointer.

reference:
https://lore.kernel.org/all/Ya%2FeUbdN1+ABFVWf@rowland.harvard.edu/
https://lore.kernel.org/all/YbBGGI9wQenI4kP7@kroah.com/
https://lore.kernel.org/all/20211209062441.9856-1-guozhengkui@vivo.com/

Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
---
 drivers/irqchip/irq-apple-aic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c
index b40199c6625e..23098b469b1a 100644
--- a/drivers/irqchip/irq-apple-aic.c
+++ b/drivers/irqchip/irq-apple-aic.c
@@ -810,7 +810,7 @@ static void build_fiq_affinity(struct aic_irq_chip *ic, struct device_node *aff)
 	if (WARN_ON(n < 0))
 		return;
 
-	ic->fiq_aff[fiq] = kzalloc(sizeof(ic->fiq_aff[fiq]), GFP_KERNEL);
+	ic->fiq_aff[fiq] = kzalloc(sizeof(unsigned long), GFP_KERNEL);
 	if (!ic->fiq_aff[fiq])
 		return;
 
-- 
2.20.1