Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp1143928pxp; Wed, 9 Mar 2022 22:36:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJyLmAy9IFEZKzSTdCJrRnpFWDubvH2lVu+AEZ6GVrrWfytS3Uu+CQyj1U4x0wg2FEIGOuB4 X-Received: by 2002:a05:6a00:2451:b0:4f7:72de:88dd with SMTP id d17-20020a056a00245100b004f772de88ddmr2059214pfj.82.1646894218610; Wed, 09 Mar 2022 22:36:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646894218; cv=none; d=google.com; s=arc-20160816; b=RH18bnmpTaBXWO8wGEG17w7ryNu2CflBUMciKrDsxznzthO10IXAcxHWrUIl5jzBTE 5pLbSFOSLG+F77iLoMHYgxgR2MhP/XKUm0WWsauQHys5u8RGEjIPuyjtQi8NrOoWRydt DGRY8yE7ttvsaqetyptpM4Yb0+JprYffyjvC2U6o+sQGed6gkwrgkw9wH6MXh/IsoQht iI3uRlo6kp5CoWJFLtM71F94mLMZwUmK0qXwlksy7FT4brZmsfvdF7o+zkayzsMKqWxt vYnBWoNIgxpxxxJwcmK0hw6yjwZ5DnlLZrGd8Gi0uaAkkOcVM6HKTHTGVP5Z7o9CIXrW YZxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=wlzgTk54ceIcRNUIRfltpizWVBeZoYCRZ8q4Bed9oLE=; b=Abp0YAOtB2hH3Oa4iFb/2muv+6RuPAgNHB/Wx9VADeEKEE5Fd+Jjx+OGPwG6mcbV1m hQJ47O7tNyxD8SjYt2cLWl3EX6Xnz4ONylvGGvPo9jzws0aMwkScS+vpIVIdKRsAHsz4 KSCGaFrA/RfmO3Jt+jtZrWzUUP+UVs4yjeqM4cXZ7o9GDKB/uUNvLvpefCG495VFbKaR EwFcR5oFJdW/kx3UQN8gghK2kd3Hyjx1h8WYoIe8VXe6mSqHBnsxNeQlC2x2pvvqjzLK H/pQpvjPHit/ALQhHVt5kkElOm9K1j0KnThA9QicJY/5EmzlHXnE6r6E4XA4r9/Q08oC 0Vuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VbMpg2UE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h70-20020a638349000000b00380bcc5074fsi3222264pge.666.2022.03.09.22.36.43; Wed, 09 Mar 2022 22:36:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VbMpg2UE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237273AbiCIViO (ORCPT + 99 others); Wed, 9 Mar 2022 16:38:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237214AbiCIViM (ORCPT ); Wed, 9 Mar 2022 16:38:12 -0500 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8D72FABD1 for ; Wed, 9 Mar 2022 13:37:11 -0800 (PST) Received: by mail-pl1-x629.google.com with SMTP id w4so3084135ply.13 for ; Wed, 09 Mar 2022 13:37:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=wlzgTk54ceIcRNUIRfltpizWVBeZoYCRZ8q4Bed9oLE=; b=VbMpg2UEFOZKZXQ5NwnPX9SeOVkeE9/ZhzMl1B8h7Hb0C9SPsw2hRuqRoes9stgpG9 1FB3SRLXSUXMvALYlhQ9dXYr+e7EVet/DAaXZ4MzxtD8V2glb/+okoXBx/eKxbS3DCX5 KFPv/VFcQ6+a0U1htGoniK7qBY9J7FkUfYYchQY5l0XQDrRHg6X93ApRbOKYQHQnHk9T cv5WoO3ZM2UwLm4Dc0JHLIF9gbBvNm/yb2rrlfUUKBMFd+JffuJu/mF/sd4nz1jpquGH 5FhAWy1r/wN12TTsYuzFc6O1eCQHBMYn42rOLHw7ydiupIAp0bEGo2xnTFr1ZN9K+n72 576g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=wlzgTk54ceIcRNUIRfltpizWVBeZoYCRZ8q4Bed9oLE=; b=iScNpsQc4n5x9b6OZKpWqqqGhVdXGe/VLj5xuBNGrPA7J7SqiOJEFS4blb6Tzquz+/ PscJzrfdROgc+1Y6KxfF9tRMJFTQ2Iz5jiN1OAAeKBJJO0GkuK3eTV6gY6S2ftEK72AJ pfJD0yCZNiflq1sTDTS8uR7NCYcRQ9KOo/56xF0tD2RQTGC237HK+d815jXbHcF3KVi3 87xMy1GItkrwpENcew6hT4alU1FTXAFy/MVObizjTtE+J1/NYb4o6jA2wUJ6rvCTbbyo shBuIt5awu5JExwK7W9br4/+cVNczs7NhuUekZM+1R3qyVpw4NW6YTBikN1/PmIoD8O3 qTFA== X-Gm-Message-State: AOAM530wOmFveYcvS0SHtC540sFjsxBfg0TaXErBamb7yIZh5L0ooJJI 5b1bJHAkLIyluAPmxcUJ3KVe3IcebZLZ+45S X-Received: by 2002:a17:90b:4f44:b0:1bf:61b2:4560 with SMTP id pj4-20020a17090b4f4400b001bf61b24560mr12287231pjb.245.1646861831400; Wed, 09 Mar 2022 13:37:11 -0800 (PST) Received: from [192.168.254.17] ([50.39.160.154]) by smtp.gmail.com with ESMTPSA id s3-20020a056a00194300b004f6da3a1a3bsm4189545pfk.8.2022.03.09.13.37.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Mar 2022 13:37:11 -0800 (PST) Message-ID: <8fdab42f-171f-53d7-8e0e-b29161c0e3e2@linaro.org> Date: Wed, 9 Mar 2022 13:37:10 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] net: ipv6: fix invalid alloclen in __ip6_append_data Content-Language: en-US To: David Ahern , David Laight , "davem@davemloft.net" Cc: Hideaki YOSHIFUJI , Jakub Kicinski , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , "netdev@vger.kernel.org" , "bpf@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , "syzbot+e223cf47ec8ae183f2a0@syzkaller.appspotmail.com" References: <20220308000146.534935-1-tadeusz.struk@linaro.org> <14626165dad64bbaabed58ba7d59e523@AcuMS.aculab.com> <6155b68c-161b-0745-b303-f7e037b56e28@linaro.org> <66463e26-8564-9f58-ce41-9a2843891d1a@kernel.org> <45522c89-a3b4-4b98-232b-9c69470124a3@linaro.org> From: Tadeusz Struk In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/8/22 21:01, David Ahern wrote: > On 3/8/22 12:46 PM, Tadeusz Struk wrote: >> That fails in the same way: >> >> skbuff: skb_over_panic: text:ffffffff83e7b48b len:65575 put:65575 >> head:ffff888101f8a000 data:ffff888101f8a088 tail:0x100af end:0x6c0 >> dev: >> ------------[ cut here ]------------ >> kernel BUG at net/core/skbuff.c:113! >> invalid opcode: 0000 [#1] PREEMPT SMP KASAN >> CPU: 0 PID: 1852 Comm: repro Not tainted >> 5.17.0-rc7-00020-gea4424be1688-dirty #19 >> Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.15.0-1.fc35 >> RIP: 0010:skb_panic+0x173/0x175 >> >> I'm not sure how it supposed to help since it doesn't change the >> alloclen at all. > > alloclen is a function of fraglen and fraglen is a function of datalen. Ok, but in this case it doesn't affect the alloclen and it still fails. -- Thanks, Tadeusz