Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 9 Mar 2022 22:31:59 +0000
From:   Catalin Marinas <catalin.marinas@arm.com>
To:     Nick Desaulniers <ndesaulniers@google.com>
Cc:     Nathan Chancellor <nathan@kernel.org>,
        Will Deacon <will@kernel.org>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        llvm@lists.linux.dev, stable@vger.kernel.org,
        Marc Zyngier <maz@kernel.org>,
        James Morse <james.morse@arm.com>
Subject: Re: [PATCH] arm64: Do not include __READ_ONCE() block in assembly
 files
Message-ID: <Yikq33Q9Cfhbce6F@arm.com>
References: <20220309191633.2307110-1-nathan@kernel.org>
 <CAKwvOdkrgtyE3rU8Xa2B8QQJ1ZErSTB9PDuikPF6=4D4Q80XVQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAKwvOdkrgtyE3rU8Xa2B8QQJ1ZErSTB9PDuikPF6=4D4Q80XVQ@mail.gmail.com>
Precedence: bulk

On Wed, Mar 09, 2022 at 01:53:50PM -0800, Nick Desaulniers wrote:
> On Wed, Mar 9, 2022 at 11:19 AM Nathan Chancellor <nathan@kernel.org> wrote:
> > Avoid this problem by just avoiding the CONFIG_LTO=y __READ_ONCE() block
> > in asm/rwonce.h with assembly files, as nothing in that block is useful
> > to assembly files, which allows ARM_SMCCC_ARCH_WORKAROUND_3 to be
> > properly expanded with CONFIG_LTO=y builds.
> >
> > Cc: stable@vger.kernel.org
> > Fixes: e35123d83ee3 ("arm64: lto: Strengthen READ_ONCE() to acquire when CONFIG_LTO=y")
> > Link: https://lore.kernel.org/r/20220309155716.3988480-1-maz@kernel.org/
> > Reported-by: Marc Zyngier <maz@kernel.org>
> > Acked-by: James Morse <james.morse@arm.com>
> > Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> 
> Thanks for taking point on all of the BHB fallout.
> 
> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> Tested-by: Nick Desaulniers <ndesaulniers@google.com>

Thanks for the review and testing. Unfortunately I've just sent the pull
request to Linus, so didn't include your tags.

-- 
Catalin