Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 9 Mar 2022 22:55:29 +0100
From:   Oscar Salvador <osalvador@suse.de>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Dave Hansen <dave.hansen@linux.intel.com>,
        "Huang, Ying" <ying.huang@intel.com>,
        Abhishek Goel <huntbag@linux.vnet.ibm.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: Only re-generate demotion targets when a numa node
 changes its N_CPU state
Message-ID: <YikiUbWCb3VSrJzV@localhost.localdomain>
References: <20220309144644.4278-1-osalvador@suse.de>
 <20220309130249.60733272aafb3bd5f2e6b88c@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220309130249.60733272aafb3bd5f2e6b88c@linux-foundation.org>
Precedence: bulk

On Wed, Mar 09, 2022 at 01:02:49PM -0800, Andrew Morton wrote:
> On Wed,  9 Mar 2022 15:46:44 +0100 Oscar Salvador <osalvador@suse.de> wrote:
> > +static inline void set_migration_target_nodes() {}
> 
> Compiler won't like that.  Please test (compile and runtime) with
> CONFIG_HOTPLUG_CPU=n.

Sorry, fat fingers. This on top:

diff --git a/include/linux/migrate.h b/include/linux/migrate.h
index c64fe2923fb0..b82b4a9a0136 100644
--- a/include/linux/migrate.h
+++ b/include/linux/migrate.h
@@ -51,7 +51,7 @@ extern bool numa_demotion_enabled;
 #ifdef CONFIG_HOTPLUG_CPU
 extern void set_migration_target_nodes(void);
 #else
-static inline void set_migration_target_nodes() {}
+static inline void set_migration_target_nodes(void) {}
 #endif
 #else

I will wait for some feedback before sending a v2.

thanks Andrew!

-- 
Oscar Salvador
SUSE Labs