Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp1240156pxp; Thu, 10 Mar 2022 01:19:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJzXT3SdKC3WCc2mavGgp6GdtfN+2eQf+h2eqFJ9LWrQOmCpFtooVgSh45qtWbO3niCE4yQM X-Received: by 2002:a17:906:6a04:b0:6cf:db6:bda6 with SMTP id qw4-20020a1709066a0400b006cf0db6bda6mr3389541ejc.738.1646903958335; Thu, 10 Mar 2022 01:19:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646903957; cv=none; d=google.com; s=arc-20160816; b=q8Gr5avwKLFfUJp50PlajWeoefitXkI6B5Du6a3lNYjqhR2bqjTwyIrcL0MB4KIOJv mbiE8a2WdXd+yIow7a5pzrR1Ojz4ZUTiAR2nGEesejmR/jCHhvdIkdvG57lif1CRUTfH Ba8S4JEwY3gjMrd9wYNzVUWCHdOF4zBE5tPTPy+Tvqg8YlBTQ45dK7v+bUFUGmXg8wr/ fGLWwERmFOFza0B0BHSThzIm52EW3Y7P14HFPks9mrzV3Ai0k2VNwnBwJuw1xss5oZ3t kvBLFwNh7XWBMoh0r9Vrc7RLEmXyG52JJXhMLZ5WAx58SQcJKPmJT+TEqBaE0Emc2y6e LYMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Q42zjW8xahSVhGaNilfnj63EHK+Wikk3dCoDovWBQQY=; b=YFVXeUdhP6zpeMdILr40hXPcHKFLsHsKWJU80qAacmGpHm93sMwOc+nsOooxIS0La3 ySCTRp7By/Tf/i/APQjRo2b+DBxtH7hUj2BM6pzmtRDai4csEzPHnVYVBAm0hkRkGfuu Ll12lurXdwTmcUHuNNI//iJU0f56m9deMmxj6vCQSb+AqDXpX6OlhJ+PYEcFFmcya4uE nzCOpKjxRa10wY3vEreGGoELFuK2fHpYQDTICNO29VU3kcJuAsqblCjVqdmizjjIspTy 98SzfOn9U9QQh9VCtOSrHgiW2CiMDNZEpSjRTRH4bFHeT0vZWoO08uTiVkmk9b3ciS2L rRVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=xvVcZ8t2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dz13-20020a0564021d4d00b00416c463d579si16506edb.594.2022.03.10.01.18.54; Thu, 10 Mar 2022 01:19:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=xvVcZ8t2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237803AbiCITWW (ORCPT + 99 others); Wed, 9 Mar 2022 14:22:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237693AbiCITWE (ORCPT ); Wed, 9 Mar 2022 14:22:04 -0500 Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDB31113AF3 for ; Wed, 9 Mar 2022 11:20:53 -0800 (PST) Received: by mail-io1-xd30.google.com with SMTP id e22so3910583ioe.11 for ; Wed, 09 Mar 2022 11:20:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q42zjW8xahSVhGaNilfnj63EHK+Wikk3dCoDovWBQQY=; b=xvVcZ8t2hTLcYyaR8IdpNwhqebsi1HHxLkwIaDM05AD3lNV0N4AV12KaR0NWsN5GuQ pdX87gjBv0H+CKrPZ+nNI3Y1CdEM7ga8ZJKA6pfpf7tU5IuKIkiLC+VBTLutyyiWlE+7 F7tJChmMw4gdInhfNtkjI0XJfVG2xMK14LP/L6QAkEBUaKr898KU7E0rxPJnYVRZXImV QtseXyJto1X7M7YjX3jJ8R2PjtZcDYj53/RHDbrRbEPlQaKvWj16VP35butKsdr6RMuy Untl7fwO6iB27zvzBwP+7A1quiRcAwNFJNjvPJ2Px8ntgSq96yBwRwuBqNv8dujSyoeK ddbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q42zjW8xahSVhGaNilfnj63EHK+Wikk3dCoDovWBQQY=; b=QyeclIRFEcqlZIbu/e7u9hqclqs5fF/8Q0H5QGQf/EjKZlMspltnQRdmUUc+2+Zhh8 jm5bQDtOTMMp9sqzOyNjJ5X9pYbaV2vl/OoLI/xiLJb5Xw7A9HTSOHCYn6TQgLpwlA0U OZE8oovrrudU9pNGG1+TaCPC+OGAV9xyZvseDhbr4Hm7rH3YgxLrKcAkwRLCDxxhF/pt lSlQBjFQnxKgU4kULO5VMCj/kHWAuHscdyV0+/nMqCgWl9wtxWNytiv+ineDq+BpFo83 5EB4jIYesYTgGLmRrrhxWWqe6+Ac8s34myWcXSzcw9cP353jSKLPjCcbZ9ejwAaI8nbp +LWQ== X-Gm-Message-State: AOAM530mt0vGgYEBuaWT8MKbrHEUTn18E427hNTDHwp4pzgDGlH/bkPD MJYSVr9IhZnhmMnXdUwVaAjacg== X-Received: by 2002:a05:6602:2d51:b0:645:a9f2:82f3 with SMTP id d17-20020a0566022d5100b00645a9f282f3mr885134iow.9.1646853653196; Wed, 09 Mar 2022 11:20:53 -0800 (PST) Received: from presto.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id g8-20020a056602248800b006409fb2cbccsm1389182ioe.32.2022.03.09.11.20.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Mar 2022 11:20:52 -0800 (PST) From: Alex Elder To: davem@davemloft.net, kuba@kernel.org Cc: djakov@kernel.org, bjorn.andersson@linaro.org, mka@chromium.org, evgreen@chromium.org, cpratapa@codeaurora.org, avuyyuru@codeaurora.org, jponduru@codeaurora.org, subashab@codeaurora.org, elder@kernel.org, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 7/7] net: ipa: use IPA power device pointer Date: Wed, 9 Mar 2022 13:20:37 -0600 Message-Id: <20220309192037.667879-8-elder@linaro.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220309192037.667879-1-elder@linaro.org> References: <20220309192037.667879-1-elder@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The ipa_power structure contains a copy of the IPA device pointer, so there's no need to pass it to ipa_interconnect_init(). We can also use that pointer for an error message in ipa_power_enable(). Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_power.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ipa/ipa_power.c b/drivers/net/ipa/ipa_power.c index 8a564d72799da..16ece27d14d7e 100644 --- a/drivers/net/ipa/ipa_power.c +++ b/drivers/net/ipa/ipa_power.c @@ -71,7 +71,7 @@ struct ipa_power { }; /* Initialize interconnects required for IPA operation */ -static int ipa_interconnect_init(struct ipa_power *power, struct device *dev, +static int ipa_interconnect_init(struct ipa_power *power, const struct ipa_interconnect_data *data) { struct icc_bulk_data *interconnect; @@ -89,7 +89,7 @@ static int ipa_interconnect_init(struct ipa_power *power, struct device *dev, interconnect++; } - ret = of_icc_bulk_get(dev, power->interconnect_count, + ret = of_icc_bulk_get(power->dev, power->interconnect_count, power->interconnect); if (ret) return ret; @@ -123,7 +123,7 @@ static int ipa_power_enable(struct ipa *ipa) ret = clk_prepare_enable(power->core); if (ret) { - dev_err(&ipa->pdev->dev, "error %d enabling core clock\n", ret); + dev_err(power->dev, "error %d enabling core clock\n", ret); icc_bulk_disable(power->interconnect_count, power->interconnect); } @@ -385,7 +385,7 @@ ipa_power_init(struct device *dev, const struct ipa_power_data *data) spin_lock_init(&power->spinlock); power->interconnect_count = data->interconnect_count; - ret = ipa_interconnect_init(power, dev, data->interconnect_data); + ret = ipa_interconnect_init(power, data->interconnect_data); if (ret) goto err_kfree; -- 2.32.0