Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Date:   Wed, 09 Mar 2022 20:37:14 +0000
From:   Marc Zyngier <maz@kernel.org>
To:     Alyssa Rosenzweig <alyssa@rosenzweig.io>
Cc:     Hector Martin <marcan@marcan.st>,
        Thomas Gleixner <tglx@linutronix.de>,
        Rob Herring <robh+dt@kernel.org>,
        Sven Peter <sven@svenpeter.dev>,
        Mark Kettenis <mark.kettenis@xs4all.nl>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org
Subject: Re: [PATCH v3 0/7] irqchip/apple-aic: Add support for AICv2
In-Reply-To: <YikOZNMmkkDGVhQc@sunset.rosenzweig.io>
References: <20220309192123.152028-1-marcan@marcan.st>
 <YikOZNMmkkDGVhQc@sunset.rosenzweig.io>
User-Agent: Roundcube Webmail/1.4.13
Message-ID: <995ddff0ab7b4dae93a1418eb9a0f4c1@kernel.org>
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022-03-09 20:30, Alyssa Rosenzweig wrote:
>> This also adds support for multi-die AIC2 controllers. While no
>> multi-die products exist yet, the AIC2 in t600x is built to support
>> up to 2 dies, and it's pretty clear how it works, so let's implement
>> it. If we're lucky, when multi-die products roll around, this will
>> let us support them with only DT changes. In order to support the
>> extra die dimension, this introduces a 4-argument IRQ phandle form
>> (3-argument is always supported and just implies die 0).
> 
> Given you have a multidie device in the mail, it's probably best to
> defer merging this series until the multidie code paths are confirmed
> working there?

This code is used on Pro and Max systems, so it has some value as is.
Not to mention that it makes things slightly faster on the original M1
too.

         M.
-- 
Jazz is not dead. It just smells funny...