Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 9 Mar 2022 21:43:05 +0000
From:   Yazen Ghannam <yazen.ghannam@amd.com>
To:     Borislav Petkov <bp@alien8.de>
Cc:     linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
        mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com,
        rric@kernel.org, Smita.KoralahalliChannabasappa@amd.com
Subject: Re: [PATCH v4 02/24] EDAC/amd64: Define functions for DramOffset
Message-ID: <YikfaT7mXWRj7eAh@yaz-ubuntu>
References: <20220127204115.384161-1-yazen.ghannam@amd.com>
 <20220127204115.384161-3-yazen.ghannam@amd.com>
 <Yga3oWKqg7TK6lWZ@zn.tnic>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Yga3oWKqg7TK6lWZ@zn.tnic>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BEniRqHYg1Ocq1rZDSrAF1LRM0HLQ74b9EkOmQVRopaWrnPPgberZSWHeD6k?=
 =?us-ascii?Q?b0GhWn01aWM6tBe5LFJg8eO+2FDotlrEA9hvIEtTj1NQ37EioO3Fq792eKL1?=
 =?us-ascii?Q?8W8IceMpLV2rNsPHCUJ0KbzgcrovItSXElj4YBmNlMFbmSne4onM+9km1Hfp?=
 =?us-ascii?Q?KEXwjSSqNpHQZV4+d+tHQbcn+9u9PJYez2p3QLmZYpATLjWMaTUjgP6W735A?=
 =?us-ascii?Q?D6bgZ+JY+R59CwVoYwOmCOjD4mcQq2QRQ7gTlma3CyKxoLxLSc8/9QhqgKlE?=
 =?us-ascii?Q?j/Ix19wruVVGNbWNYEFMWg4SXnEk3tUumnc5HVo8ijqfNNOorph12pemW0ys?=
 =?us-ascii?Q?LnowQd6PZSGZhNUiK6GQYlCq+WwTvAAZFVFa16iFBjd5/N/AiwUZUtVrkZZZ?=
 =?us-ascii?Q?02KTqMs6KAgAWeJGw+ghVrS6ri2pfiuftGDqY1Tv5errAvmZDNKcXSL637Zh?=
 =?us-ascii?Q?peR2YpbMA35xVCI/dnUjKTHxw7Ie5HZBS4AhZOwYWsNmDX+VXLxn65oeLDF1?=
 =?us-ascii?Q?UGw/NFn1aNjcbrZnY9Yrujxm/qq3+8eV8yHRH0HhTTiDpL+3qzrClpiUJ/XB?=
 =?us-ascii?Q?x8oK57IY8k1dGKDfHh95OB7Z3SP44VuNzxmRFwGNZrEc0v5HV0GiiIdrpnQI?=
 =?us-ascii?Q?ymquHq6AfNwUewtiWJ0Q1clUcbSRicTx2p810wHlvsGlQMOnDCCMEUZGXwJS?=
 =?us-ascii?Q?mhygvR/ELlTUIjTApjMOB4d8FP6pPdNZXENsU0NW/5NjNQhPrHU+YeevTKXF?=
 =?us-ascii?Q?icFuHe8vKWbqtLzMvFFTXfvDncklYdwNGh573y/FLrnSzuZUDnjPRtanh9gj?=
 =?us-ascii?Q?nZfM/dKFGe0hR5Hj2ivw6gp3+sOIP2MsGb9LKcjtSF3MwMBZKbc4gAv3UCen?=
 =?us-ascii?Q?iwOLVMxaL+bkoPahxscjp0yTtVAB+wKOGmVMrEBZ1z8c8nnaPPZLdt5LM4F6?=
 =?us-ascii?Q?/PXnPyU32nBuQzi5BxYnsp9Dvz98daN+8J8cLrD++HlS+x/9/YqQlTYh8bNp?=
 =?us-ascii?Q?252YKHOwdg9+9+MdO1VRwxo3plYJVQl91IEse685ItxYHmbXakAT2cwH5gjo?=
 =?us-ascii?Q?x6vh2Ik5Gd/1/3oMQOs2c45D82WpZut8xJ1v2+/SiaKNdQgd2k/pXfRN27Vv?=
 =?us-ascii?Q?lcTsCI/iSriTclGyAayBBY9zt9/DtJlYs4yY6TnHL6IbDP4midWWTfdmbMw3?=
 =?us-ascii?Q?Z+zH0ZRV8n/hDbAxHuk2BVxMyOabIXpv79iSo7hWiKq5iT4BKkTyOLXbGqW0?=
 =?us-ascii?Q?QSliImuZsRYYeWXP+PjrgircRVtmsrSiZYoWJDfWQXXOIZQjn97r98GRR3mH?=
 =?us-ascii?Q?eHxzfHH/JXcO6z4TkSuInLhpwzWpmn4fGLXu04MbSLKpnCHO33qZf8Hqoqfl?=
 =?us-ascii?Q?+TdWrwrrOsvxnhOYCqmeiRQeVcRaqBS02kAlq6tWeD3xCIGilDQ0nPi6oJdH?=
 =?us-ascii?Q?G67yXHMx7GnEWR8X4m4PqfbJ09zzOlBn?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8cf3e51b-23f4-4fe5-4a12-08da0215cd60
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2022 21:43:09.0804
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LYGDnFc7oD1bTbNiSYrefRoGcNCpDuwNwegu6l18Hib+6rKSnQoOwYnzhoIFpaP0yZ8XuIkJXfgH7KRb/zlwKw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1201MB0241
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Feb 11, 2022 at 08:23:13PM +0100, Borislav Petkov wrote:
> On Thu, Jan 27, 2022 at 08:40:53PM +0000, Yazen Ghannam wrote:
> > @@ -1099,22 +1140,13 @@ static int umc_normaddr_to_sysaddr(u64 norm_addr, u16 nid, u8 umc, u64 *sys_addr
> >  	ctx.nid = nid;
> >  	ctx.inst_id = umc;
> >  
> > -	/* Read D18F0x1B4 (DramOffset), check if base 1 is used. */
> > -	if (df_indirect_read_instance(nid, 0, 0x1B4, umc, &ctx.tmp))
> > +	if (remove_dram_offset(&ctx)) {
> > +		pr_debug("Failed to remove DRAM offset");
> 
> You don't need that pr_debug - remove_dram_offset() already has one for
> the single error case.
>

Yep, will remove.

Thanks,
Yazen