Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Sa, Nuno" <Nuno.Sa@analog.com>
To:     Steve Lee <steve.lee.analog@gmail.com>,
        "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "perex@perex.cz" <perex@perex.cz>,
        "tiwai@suse.com" <tiwai@suse.com>,
        "ckeepax@opensource.cirrus.com" <ckeepax@opensource.cirrus.com>,
        "geert@linux-m68k.org" <geert@linux-m68k.org>,
        "rf@opensource.wolfsonmicro.com" <rf@opensource.wolfsonmicro.com>,
        "shumingf@realtek.com" <shumingf@realtek.com>,
        "srinivas.kandagatla@linaro.org" <srinivas.kandagatla@linaro.org>,
        "krzk@kernel.org" <krzk@kernel.org>,
        "dmurphy@ti.com" <dmurphy@ti.com>,
        "jack.yu@realtek.com" <jack.yu@realtek.com>,
        "steves.lee@maximintegrated.com" <steves.lee@maximintegrated.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: RE: [PATCH] ASoC: max98390: Add reset gpio control
Thread-Topic: [PATCH] ASoC: max98390: Add reset gpio control
Thread-Index: AQHYNFccgr40UHo4NUKAxl3T8tSFjay4TIUA
Date:   Thu, 10 Mar 2022 08:48:09 +0000
Message-ID: <SJ0PR03MB67794358405FA661992A206D990B9@SJ0PR03MB6779.namprd03.prod.outlook.com>
References: <20220310081548.31846-1-steve.lee.analog@gmail.com>
In-Reply-To: <20220310081548.31846-1-steve.lee.analog@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?oCRQDjaD4zBkWdx1IBT8xqRhlB03qffoV1wQZ9wuWo+qzyhVnwwSp8d4Tl?=
 =?iso-8859-1?Q?MSoPmuf3HN8+2Zj4Yq7ielacmdoXfdKfEHNTKJGVF8NZ0ajosDkLTrAFw/?=
 =?iso-8859-1?Q?ZQf6ecxNlVkBzxIOkEg79DEmg3nXB0w39VWZEeLFAiw4eolPw1JIY6D+z6?=
 =?iso-8859-1?Q?0LD6+7ZK4lTlMGJ/5YDJ4ZE6ft1ze1S2RWGE31fY5jC4Ovbq/CPBL3aLWh?=
 =?iso-8859-1?Q?hCJejcosngOGmsAAG/B8bgKK9cxFdcVxUVKDmVUUQ/J77lz3FozvXgwbWG?=
 =?iso-8859-1?Q?omTCVqPTLcSubXD/Zq3QlXHn6LamOT+VbqU9muan8a3E6x8HO0nzzxHVfw?=
 =?iso-8859-1?Q?Sp72ac5+2/6NJh0RaHyJGYo8Bpsmu8PiQAf60rvmRq9C0MJYjFUhMC+ytv?=
 =?iso-8859-1?Q?BgO1nI0Xmixjehe2u/3S6EV5nxJSPQ7Jd+vyZBnGX+fi6T7wJVnnSi/QG4?=
 =?iso-8859-1?Q?io95yUi1xS0i7RCLKXF9hfdqnhYJsZk+tSI6AHkVQhOBnISHLtOf9EWBPz?=
 =?iso-8859-1?Q?oRNWqvtvdj8L58WsFDAFba69fejObdLO8qki7wTwpWQ8hC5zyg2RbImeJo?=
 =?iso-8859-1?Q?qA7h/3qs8Qr0vOigiFgTJcArz43bi9HqkQx/OmvhWiZJAeOCUgdGBKsFhL?=
 =?iso-8859-1?Q?9mxZXDKLhmptU07mntM3SA43uGrZnBcQ1tDDGcsJHqAFAWuwChOCAUMswB?=
 =?iso-8859-1?Q?2T0I9oqDkOVU/DxiuiCEPEVD+pkwfLdXilkPkbYfwbp5q+n/6FHkyT5K6f?=
 =?iso-8859-1?Q?LR9YK+K1z9iBcEARRTxE42++rCbo6HtDg7VjEykVoT4aVjIMg3BVXwFFp/?=
 =?iso-8859-1?Q?RrbM1wdWZZhLnr4mCyqLw3N1/bBGnk/RYaQxjQNjV0yLhFnZF+2Z5nAJ2e?=
 =?iso-8859-1?Q?YJxCzHGZqqf0cJXyFtk1DsRfw+RayUJjU2mNCcoPXDADK5Y+9El+5Q2Oqf?=
 =?iso-8859-1?Q?nSQSeKeux+k54eGTzdomAxlw4dnP1V1mFm8VPMCm1FXzjgvSu+1B/rj/9c?=
 =?iso-8859-1?Q?Q4gb/5WgjlRwtJuQ8ITqQ3QXC40iOc2PgCmtPz0Ou/z9Cyv/8Eud/232HG?=
 =?iso-8859-1?Q?w2V8K0dv6IkKPpYptylzYp8KePg5WgZvYrl89Zz7v0A+eOj9GZ+n6GvEH8?=
 =?iso-8859-1?Q?Ft/KfqK+G+2Kv5xLb0BT+m0rskVnH9tiWWwP3zpBnHi+fH6LrI7fWiOF+E?=
 =?iso-8859-1?Q?4VG7d0mdsCE+XvGMWl0SM7gycsJYmT6AlXyioBA8eaaqba21rE9rmJMBOv?=
 =?iso-8859-1?Q?pk0MsHWDI16X9dB/PByR4nyUngmhiwQpfYlQLr3rbEuJ9+iurjPxKcuc1n?=
 =?iso-8859-1?Q?mIQ+LiqfiRXExE9pT+/XPIKLGhgYOe8aIlM6vKxX7c7KFjhnM2kTzPf/4z?=
 =?iso-8859-1?Q?kJcUpArxf2ylqVxNTH4fG63bhfCC1toFbaTn0Dd6Xk7wNrMpWaZZ/lmSEJ?=
 =?iso-8859-1?Q?5lIdnUSp2Extf57MZEbqEy2hvbw0SEC3+tKdT5XJepRR+dCLOREhPwKVca?=
 =?iso-8859-1?Q?uXIdXAWXPZ0EdgU7c1nqpePFF4nPATbd8oGKKhwZVaMRnsCpSYjTWqQEqD?=
 =?iso-8859-1?Q?PGDTfIcUuXjSxnvnvFj4+QKZD/E8XtJ09bLQvYCG4my+xXLzP89MJ5w/lc?=
 =?iso-8859-1?Q?UVX3z1WdIU3uGh/Hxj1AIByfUvdgHJEiu7LUdPced4mnCXMC7CehevXQ?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB6779.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 34d428cc-be68-4763-2de9-08da0272b45c
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Mar 2022 08:48:10.0563
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: aYAwg32Fvt0kzIqyoQy5RGjE+qyFoIb9edaRk4CF0LImeSf/eejFNO2qD+DHA/d8OH9gMvAtlPRe2ReXQu5ekA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5021
X-Proofpoint-GUID: krt4iCSzukgnmeIMsrRJ9tXWXfnHTam5
X-Proofpoint-ORIG-GUID: rLg2IVzfTRFW5s_ZYVg-aG-lVxJ2C_dV
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.64.514
 definitions=2022-03-10_03,2022-03-09_01,2022-02-23_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 mlxscore=0
 suspectscore=0 malwarescore=0 clxscore=1011 adultscore=0
 priorityscore=1501 impostorscore=0 phishscore=0 bulkscore=0
 mlxlogscore=999 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2202240000 definitions=main-2203100045
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Steve,

> From: Steve Lee <steve.lee.analog@gmail.com>
> Sent: Thursday, March 10, 2022 9:16 AM
> To: lgirdwood@gmail.com; broonie@kernel.org; perex@perex.cz;
> tiwai@suse.com; ckeepax@opensource.cirrus.com; geert@linux-
> m68k.org; rf@opensource.wolfsonmicro.com; shumingf@realtek.com;
> srinivas.kandagatla@linaro.org; krzk@kernel.org; dmurphy@ti.com;
> jack.yu@realtek.com; Sa, Nuno <Nuno.Sa@analog.com>;
> steves.lee@maximintegrated.com; linux-kernel@vger.kernel.org;
> alsa-devel@alsa-project.org
> Cc: Steve Lee <steve.lee.analog@gmail.com>
> Subject: [PATCH] ASoC: max98390: Add reset gpio control
>=20
> [External]
>=20
>  Add reset gpio control to support RESET PIN connected to gpio.
>=20
> Signed-off-by: Steve Lee <steve.lee.analog@gmail.com>
> ---
>  sound/soc/codecs/max98390.c | 18 ++++++++++++++++++
>  sound/soc/codecs/max98390.h |  1 +
>  2 files changed, 19 insertions(+)
>=20
> diff --git a/sound/soc/codecs/max98390.c
> b/sound/soc/codecs/max98390.c
> index b392567c2b3e..574d8d5f1119 100644
> --- a/sound/soc/codecs/max98390.c
> +++ b/sound/soc/codecs/max98390.c
> @@ -1073,6 +1073,24 @@ static int max98390_i2c_probe(struct
> i2c_client *i2c,
>  		return ret;
>  	}
>=20
> +	max98390->reset_gpio =3D of_get_named_gpio(i2c-
> >dev.of_node,
> +						"maxim,reset-gpios", 0);

Why not using devm_gpiod_get_optional()? We could request the pin
already in the asserted state and make the code slightly better...

/* I guess there's no need to save it in our struct as we only use it here?=
 */
struct gpio_desc *reset_gpio;=20

reset_gpio =3D devm_gpiod_get_optional(&i2c->dev, "reset", GPIOD_OUT_HIGH);
if (reset_gpio) {
      usleep_range(1000, 2000);
     /* bring out of reset */
      gpio_direction_output(max98390->reset_gpio, 0);
      usleep_range(1000, 2000);
}

Also, do we have this on the bindings doc? If not, it should be done on a s=
econd
patch on this series...

- Nuno S=E1