Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: d3oIMWwvuAQV6UndhLvAszP4+VCnv8RRMV8McQWmxvswft5hQ90tQyTEjNKe81KnRfgAt/gqxs
 zLj3SfBq5LL0uLhEhI2pMWm7t9xXCQYA/zwzzdL0vkamrsmX8+nc9eCxtUx0TxDLVNLBnEel7G
 7EgcC4UX/bO+sHdPi+2zdjk0LRDIjE6AAdSmUygbkiRlDUfCKtH7f42h+Str7Oxo7GPp223oDh
 HpvAw49xSFAVveF1b38dgOpQWYHETEtBgibBScqwsRxaqbKlJzHfUprURDyj2DOhbmOpOj212q
 8675fxL//nuSkfOJbSsWdMdk
IronPort-SDR: w9KX95uYRkEiKcLBYQRbgA6Fsj6FJKR7sdCO0eP9K0XOYylBf9LWtr7Ya1CfUURpq8q/pJX758
 xCi/3888IDUKkq2Rlc4BLalnQnda57wESP1F6WpmgtXFpZpzeThVjHC7nlDU2844YFtCo/qref
 Wq9XbVgNKft6cA8wEeHrx4rU8HFZ9xmRZtKjj20KewZJ1dBafKI6CL9zUq5IfL3icZMjE4+aZB
 ZnvzLipl+fyVYSh8rQjcpKhNzkA+0E9vmi912/7lNAgvDJIELNBhE/nAdRTcCZfdgJ3M5zqCSW
 GnQ=
WDCIronportException: Internal
Message-ID: <268d5589-fb80-b1d8-a513-69530ca2ab9e@opensource.wdc.com>
Date:   Thu, 10 Mar 2022 11:21:37 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH V3] ata: pata_pxa: Use platform_get_irq() to get the
 interrupt
Content-Language: en-US
To:     cgel.zte@gmail.com
Cc:     chi.minghao@zte.com.cn, linux-ide@vger.kernel.org,
        linux-kernel@vger.kernel.org, s.shtylyov@omp.ru, zealci@zte.com.cn
References: <d1dfb244-eda3-b5c6-c6bd-c0294a9a4a94@opensource.wdc.com>
 <20220309072834.2081944-1-chi.minghao@zte.com.cn>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220309072834.2081944-1-chi.minghao@zte.com.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/9/22 16:28, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
> 
> platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
> allocation of IRQ resources in DT core code, this causes an issue
> when using hierarchical interrupt domains using "interrupts" property
> in the node as this bypasses the hierarchical setup and messes up the
> irq chaining.
> 
> In preparation for removal of static setup of IRQ resource from DT core
> code use platform_get_irq().
> 
> v1->v2:
>     - Use more specific in the subject: ata: pata_pxa:
>     - Switch to returning 'irq'
> v2->v3:
>     - drop the unlikely()
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>

Applied to for-5.18 (without commit message fix). Thanks !


-- 
Damien Le Moal
Western Digital Research