Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp1335595pxp; Thu, 10 Mar 2022 03:35:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJzkXm7uN4bF1OiYKw9pgs8BGGxqMyOuPj3SlO0tf5adKRk4pkqyDkmjYCjGanXkT+6o3Crv X-Received: by 2002:a17:906:b252:b0:6ce:41e2:5bb7 with SMTP id ce18-20020a170906b25200b006ce41e25bb7mr3718460ejb.179.1646912121875; Thu, 10 Mar 2022 03:35:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646912121; cv=none; d=google.com; s=arc-20160816; b=IDbFvscZBWFu9ZLh+otXAY0XUEe/phJy8accFcr+TvKWwK/UJhlSPtL9iFokle8eFf MROkqvcGchb6tj6r1piQagxO6zMsuSW6aqoaweUcl+GfJLfmDDd3FJ2P8XZ1S/eZYCvP rSZM+ysoMitTKGeeJmJDGv0eO5zkfnXq11FmRln/FxQVscUfliNG4pv4RTk1l9mjlQbT 4NXaOuP+/zbOzSpwiHo14Vx/rtbl1LejWbKsv5YNom3D7bKQvdnld21+QRrAH1UN61ka dFpzCR1CfJUSMe9HbJczFKdXk4KNI5Ql1MWsyAU+S877nDp1lFTSbeGqxNeY58+uw/w4 TKvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=5RsWokZGOFJHPSzwoFuRByNyvzp3uTbc23/Q6qnvKW8=; b=oeWL3X78VepZr2M7xDCE76W2w74zaePeZuF37qe2uzWjzvN39mSiaZildtDFJJn8Ab nHFg9HdqHj3KkP0Y0XtYJO8Vy3cDZZku5VH39YzhAOg10nyaTMS5kT3K+q10dNmdeOsG O4uEOY9W6ndV0bwGxjkpNDoO7qVo+gRaoboaOOJvD9mbmNrTdvxzTe+zqDmMKrqirijC AU0ItnVHErAZ5PBFxatIejTh5vEfgQ3NH3XfXRU6lJBiFYfLGHJm/owWHwZP1gW57TnE GpGjWWV0ABDjJCpe8T3D8s0cotk0TKxjrdt3vyLBbuMp6gKk+hkR0uooSpkqj7Bf32pe 6uow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=iHQ1uKun; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l23-20020aa7c317000000b0041614e83a7dsi2653202edq.626.2022.03.10.03.34.58; Thu, 10 Mar 2022 03:35:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=iHQ1uKun; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238662AbiCIWbP (ORCPT + 99 others); Wed, 9 Mar 2022 17:31:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235577AbiCIWbO (ORCPT ); Wed, 9 Mar 2022 17:31:14 -0500 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3183B121504 for ; Wed, 9 Mar 2022 14:30:14 -0800 (PST) Received: by mail-pj1-x1033.google.com with SMTP id gj15-20020a17090b108f00b001bef86c67c1so3566260pjb.3 for ; Wed, 09 Mar 2022 14:30:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5RsWokZGOFJHPSzwoFuRByNyvzp3uTbc23/Q6qnvKW8=; b=iHQ1uKunf0NymIhVJIIqi7PFPBXTAa1tiZGNpujjf74K/kDazamSmkiR4Dg1s5QZHK iMusadKiN5y+2u5Djnr7bVioodOs4MwoVwqcMRXI5RhgBIhh0oFImZmU6YONj6IK1GVI KuasjKumBG9o/CEYrZ60+Ps+Yva34+UWZNAqA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5RsWokZGOFJHPSzwoFuRByNyvzp3uTbc23/Q6qnvKW8=; b=s0Pj9XlLRw8nejLkxD3rDRtyfnnW+XXPiy6VMK/3YYLNgIpbOKjxwJDv4API8gdjtX JrrA7JvNf5eR0ZFbaaGJfGF/3yaXfapLtvUq7u5Cp+OhC+7C10OFOWc4SfL7kOYMWFYg hsI+x3bRRCUtfPkUipCrzNUvmXm0vNGIJYLnljtAGhcOyw6ORLegQsR5qM3xL18iXaCI 8LXkFQjpON4ZqFNWulxNzGSjBXIJ7zXMUH875l5vt+wd9dh90mgm+r8ol0j/y9H/OjCj siKBBI/VYXZvN+M3ygDaF5hBjNTIvYj765rSJOSSp55a9/rTBLQEZx1UXlasEpjYFnig WASw== X-Gm-Message-State: AOAM530vg55U0kYCAeeNaAdZUm70BBUFaEushPbaoxTAu3PIFis9UxTD qVesv2+RADcVCII1cjvH3zFFGkFjr4nOfQ== X-Received: by 2002:a17:902:bc47:b0:151:ac43:eae0 with SMTP id t7-20020a170902bc4700b00151ac43eae0mr1969023plz.117.1646865013674; Wed, 09 Mar 2022 14:30:13 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id e6-20020a63aa06000000b00380c8bed5a6sm1802737pgf.46.2022.03.09.14.30.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Mar 2022 14:30:13 -0800 (PST) Date: Wed, 9 Mar 2022 14:30:12 -0800 From: Kees Cook To: "Eric W. Biederman" Cc: linux-kernel@vger.kernel.org, Linus Torvalds , Alexey Gladkov , Kyle Huey , Oleg Nesterov , Al Viro , Jens Axboe Subject: Re: [PATCH 06/13] task_work: Remove unnecessary include from posix_timers.h Message-ID: <202203091430.8D5A105@keescook> References: <87o82gdlu9.fsf_-_@email.froward.int.ebiederm.org> <20220309162454.123006-6-ebiederm@xmission.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220309162454.123006-6-ebiederm@xmission.com> X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 09, 2022 at 10:24:47AM -0600, Eric W. Biederman wrote: > Break a header file circular dependency by removing the unnecessary > include of task_work.h from posix_timers.h. > > sched.h -> posix-timers.h > posix-timers.h -> task_work.h > task_work.h -> sched.h > > Add missing includes of task_work.h to: > arch/x86/mm/tlb.c > kernel/time/posix-cpu-timers.c > > Signed-off-by: "Eric W. Biederman" Reviewed-by: Kees Cook -- Kees Cook