Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp1340665pxp; Thu, 10 Mar 2022 03:42:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJzkIQ9tmN7azWulTf14aVGTy7HOZj+vscEhhj2ttcH+j3XGN15oSkyRLu0bFJydUD+TFubd X-Received: by 2002:a17:903:22c4:b0:151:99cf:66f2 with SMTP id y4-20020a17090322c400b0015199cf66f2mr4469105plg.47.1646912544609; Thu, 10 Mar 2022 03:42:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646912544; cv=none; d=google.com; s=arc-20160816; b=tYP6GsR+1JVXtMOtXfbIli/pSIwp04m16dBXbCmtjEdgh4P3RqAroCTIrrCWaYtvdg s0T7dqyiwx/miHh/Ei1Hb3nKdgtL/hm1TbPsqDOxFCSdxrFC0dOWd/wDbOQYbIk2n4RA vHcrGtAt4cbyuMEXd9A9SG/WsHilLpvllMVYqXutzagPNKRtRQn/Ixi9ueC2vYQjaN6r dR54uPmFqZ2WOjOnYnG3fz/38ixbFvhpMIIqjA7U6JF2QNpi2EsfqwUxk6n34/jVDUkK 3hBt+2YDDKUrLtygQIGJnlhxC8pcgebGIF62uKMcBDbOebnAZeBXYapl+a7wugjp0exX Cqjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=pNaApBBmAFna2/gfVjkwHKrzxYYV5pSIb0D8KRcGP6M=; b=e9RowvaXoZLAqxi41xeAZylfLQBlpTOP2ApGJpZLRg3ROJpK6/BP8ycvJj1RPnf1kw jNRSLCQ3ndB9naJsoKSbHOaUVpxPXDGB0wRpZ7Bi49cXhKfV27qYAjyt2HlQJUut7dH1 8qKy3h82qlBw0pbULoABSWIQP3ORBOHMG6cFSfJqCxQ8aak6wrz+eplzt27Um3xihC7F Xi5h6WeeqqyhARGiVspw23/gzPQy++/SNcuMZbx8D/k3L6uPYvG2bedcicbFC2VtyEmE Rs6SnePQkb1Kj8syAYr5cOky/AxpWwgM7txix+AoMTurMDN+RkgnB3crewlc5Hr44cRR EUHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Edra+o4f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n12-20020a170903110c00b0014fdfea8f41si4923351plh.448.2022.03.10.03.42.04; Thu, 10 Mar 2022 03:42:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Edra+o4f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236123AbiCIWUr (ORCPT + 99 others); Wed, 9 Mar 2022 17:20:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236927AbiCIWUp (ORCPT ); Wed, 9 Mar 2022 17:20:45 -0500 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E57A8119437 for ; Wed, 9 Mar 2022 14:19:45 -0800 (PST) Received: by mail-pf1-x434.google.com with SMTP id a5so3488579pfv.2 for ; Wed, 09 Mar 2022 14:19:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pNaApBBmAFna2/gfVjkwHKrzxYYV5pSIb0D8KRcGP6M=; b=Edra+o4fL92NfRATPL5v6vF/V0TkcwKYIgnnYHma8YwOS4i0WsmjFsrFMMfhlppSd4 nBD/E9cQX4j5Te7eXfotTR7k+uf3HptxEptVcil9oAuPkaT1tpM7kCg60eaEtLwb0RQh 7UZbkYKhYKUKgfjmm76gLhvwbQrG3LSZeWtQ0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pNaApBBmAFna2/gfVjkwHKrzxYYV5pSIb0D8KRcGP6M=; b=zYvbiIyOC6ADE8DDylhTh13+zWxl/ZTIa4gQaUvaFKpUO391WlnzkKPf0aIgjvOu9u 81WF27G8PBGFkQawA9fT03v7nKT41RgygE6UTe9IBJWCXiiTMGYDjDKM1LCK8TiJEoez WddOQC5ERFCYkIThsaRVEnrEIRJmDMaVVOz8pzgRCTDQctk2d9vw8MDDnkJqlmIBqv6J TN+3JTP2AawAGDOy4HBshxEBteqe4H0s7QIXpYl7a0+YyCwujtNgms1EC0GyII/osbR0 aTArdYo+q1nRwRBo+ekxzsQimJG+xu/NXAAedoCwwh6WYRTp5beCo5q7gFgX81NKKOQZ FjNg== X-Gm-Message-State: AOAM532JG81+dO6rlWclMGWeGW8i7QGhDMeXZtw7vNpEXYq2VVNdGWc0 x75WWjNI94LLeziiyvlTnTVajA== X-Received: by 2002:a05:6a00:228d:b0:4f6:d4a8:7f47 with SMTP id f13-20020a056a00228d00b004f6d4a87f47mr1855971pfe.66.1646864385140; Wed, 09 Mar 2022 14:19:45 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id a38-20020a056a001d2600b004f70d5e92basm4255105pfx.34.2022.03.09.14.19.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Mar 2022 14:19:44 -0800 (PST) Date: Wed, 9 Mar 2022 14:19:43 -0800 From: Kees Cook To: "Eric W. Biederman" Cc: linux-kernel@vger.kernel.org, Linus Torvalds , Alexey Gladkov , Kyle Huey , Oleg Nesterov , Al Viro , Jens Axboe Subject: Re: [PATCH 01/13] ptrace: Move ptrace_report_syscall into ptrace.h Message-ID: <202203091419.D24EC994F@keescook> References: <87o82gdlu9.fsf_-_@email.froward.int.ebiederm.org> <20220309162454.123006-1-ebiederm@xmission.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220309162454.123006-1-ebiederm@xmission.com> X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 09, 2022 at 10:24:42AM -0600, Eric W. Biederman wrote: > Move ptrace_report_syscall from tracehook.h into ptrace.h where it > belongs. > > Signed-off-by: "Eric W. Biederman" Yes, as others have said, fixing the naming confusion alone is reason enough. :) Reviewed-by: Kees Cook -- Kees Cook