Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp1402624pxp; Thu, 10 Mar 2022 05:00:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJx5FGK+hUsZd3AbivwrfzixrB3fmzRIiIY96d8mbkx08UJx07bvXlQNC2qCrSdgXEEbOnjx X-Received: by 2002:a05:6a00:1894:b0:4f7:288:9844 with SMTP id x20-20020a056a00189400b004f702889844mr4635718pfh.28.1646917248817; Thu, 10 Mar 2022 05:00:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646917248; cv=none; d=google.com; s=arc-20160816; b=GzI6DRyIqz8RJRefL/ISA+PqvprvtlxWfoWJ1QfX/v0OVEosoziAndUUQrSa8hjzf2 zE2DRChGf41lB0HZZgNOc/lvDpNAxVUHZZlMdZ4NYY+tobRBVnS2HRXNbFKUlPcd7yIA HScKNodDL7c3+GQZgTTLyuVCwP6/lDuJpmczgwnLGHkHWTDKzX6ixcHFe4Lkvu3zIzdW ejV00R7oU/anXs+J0PDw0UAG6NSkAAxZT2X7U83T4A3syYajaGIEVQ74dkETW6uTR/rH UvDcgNfaiusx1PHmY9DGbXeM0C3J+JCmMdNJKgdM2/XrmOCQJwL3BH+S/ZvmDfJPfYwR LX9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=MXGfZFZy2nSOUaUT/HgP9XcZAvjivW5RDRT/U40MraY=; b=CiYx1CgFCvlCRKk5LFff78wgRF9T16OqtvjJY1lZgzRN1s2O6iQ7ShCbSPXuU825Pf 6ZxCJ8fZO3uOEvcN2tARsuW/gaLnBqO0huzs9+M6aj4XpJTWQ5k+NiJbQfVfmGnKWdHH 4+phS8FltDT5NTbs51X6dkhe6eTelmRRntyfq5kSwxE1MR5bF4y3oMPX9FMQR+3BvlO6 6kzh2/cwvPEdrHORFuf/Q96Kj+9oh16DewQYxSYOAk3SnLuhObn7bXuLleO7lCxidceU qJP546n2oV/RbvBKNG78dAUC6ioVXxjQM8U1NLgAkZTUdzlXa9zK0T7HYS3J3g+jTSbH Gynw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gnuweeb.org header.s=default header.b=UbgY3rrF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnuweeb.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a9-20020a656549000000b00378973cf263si4571591pgw.226.2022.03.10.05.00.32; Thu, 10 Mar 2022 05:00:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gnuweeb.org header.s=default header.b=UbgY3rrF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnuweeb.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238340AbiCJB6L (ORCPT + 99 others); Wed, 9 Mar 2022 20:58:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239159AbiCJB55 (ORCPT ); Wed, 9 Mar 2022 20:57:57 -0500 Received: from gnuweeb.org (gnuweeb.org [51.81.211.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A6B2128652; Wed, 9 Mar 2022 17:56:58 -0800 (PST) Received: from [192.168.43.69] (unknown [114.10.7.234]) by gnuweeb.org (Postfix) with ESMTPSA id 95EB37E2CF; Thu, 10 Mar 2022 01:56:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1646877417; bh=S24z/t0QvOEntOijnJinUqvbbvEQPEekxjzJptrBJeE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=UbgY3rrFyFXJ/ibKUs7htmEdqCjrbw9WZEtiv/C1zfOOIurJqnvsu3ksOzcVltmLc BpTQmvmUKMBDmH8yRtW2KnSfnvvhAt57669e3cqNigGB11tua8eE6LrnSq2nQWnN3w l0VwWFMN5wRQygja9COGAxzHPgOquxXuu2v7jvrPixz0XvIfTgDG+iXRr0uUsIFwf2 /ID4a/Fv4af7n1hMddxfx1qmKcfYtuRVUBxYMkMasRM4JHiMPKHdnUea8zpLCdhntC 70/1CxeDetnnZk9/Il0Azr18Eogxnz6zB81Ox8s455pn6BEf85HToK4FPbXJx4Chrs 8LaReuVb4ty0Q== Message-ID: <2530ff9c-4861-2295-6156-356da33f9565@gnuweeb.org> Date: Thu, 10 Mar 2022 08:56:37 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v4 2/2] x86/mce/amd: Fix memory leak when `threshold_create_bank()` fails Content-Language: en-US To: Yazen Ghannam Cc: Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Ingo Molnar , Thomas Gleixner , Tony Luck , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, gwml@vger.gnuweeb.org, x86@kernel.org, stable@vger.kernel.org, Alviro Iskandar Setiawan , Jiri Hladky , Greg Kroah-Hartman , Alviro Iskandar Setiawan References: <20220301094608.118879-1-ammarfaizi2@gnuweeb.org> <20220301094608.118879-3-ammarfaizi2@gnuweeb.org> <4371a592-6686-c535-4daf-993dedb43cd4@gnuweeb.org> <109a10da-d1d1-c47a-2f04-31796457f6ff@gnuweeb.org> <20220303015826.4176416-1-alviro.iskandar@gnuweeb.org> <49313736-61f8-d001-0fe4-b6166c859585@gnuweeb.org> <9dfe087a-f941-1bc4-657d-7e7c198888ff@gnuweeb.org> From: Ammar Faizi In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/10/22 3:55 AM, Yazen Ghannam wrote: > The commit message should use passive voice: no "I" or "we". > > Otherwise, I think the patch looks good. Fixed in the v5 revision, thanks! Link: https://lore.kernel.org/lkml/20220310015306.445359-1-ammarfaizi2@gnuweeb.org/ -- Ammar Faizi