Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220309155856.155540075@linuxfoundation.org> <CADVatmMODnr1vQ3VGLOACT16wLEFA6hFrTzY44VdPO2M7gX+iw@mail.gmail.com>
 <Yijw3wz29xNiIhWl@kroah.com>
In-Reply-To: <Yijw3wz29xNiIhWl@kroah.com>
From:   Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Date:   Thu, 10 Mar 2022 09:51:12 +0000
Message-ID: <CADVatmMbww0jVS7O9BmtrGzfyBN0hfm8n7QNEdZpiigJGSp20Q@mail.gmail.com>
Subject: Re: [PATCH 4.19 00/18] 4.19.234-rc1 review
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel <linux-kernel@vger.kernel.org>,
        Stable <stable@vger.kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Guenter Roeck <linux@roeck-us.net>,
        Shuah Khan <shuah@kernel.org>, patches@kernelci.org,
        lkft-triage@lists.linaro.org, Pavel Machek <pavel@denx.de>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        Florian Fainelli <f.fainelli@gmail.com>, slade@sladewatkins.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Mar 10, 2022 at 9:18 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Wed, Mar 09, 2022 at 06:08:19PM +0000, Sudip Mukherjee wrote:
> > Hi Greg,
> >
> > On Wed, Mar 9, 2022 at 4:03 PM Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > >
> > > This is the start of the stable review cycle for the 4.19.234 release.
> > > There are 18 patches in this series, all will be posted as a response
> > > to this one.  If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Fri, 11 Mar 2022 15:58:48 +0000.
> > > Anything received after that time might be too late.
> >
> > My tests are still running, but just an initial result for you,
> >
> > x86_64 defconfig fails with:
> > arch/x86/kernel/cpu/bugs.c: In function 'spectre_v2_select_mitigation':
> > arch/x86/kernel/cpu/bugs.c:973:41: error: implicit declaration of
> > function 'unprivileged_ebpf_enabled'
> > [-Werror=implicit-function-declaration]
> >   973 |         if (mode == SPECTRE_V2_EIBRS && unprivileged_ebpf_enabled())
>
> It's in a .h file, how can it be undefined?  Must be a include path
> somewhere, let me dig...

Looks like the problem is that both "static inline bool
unprivileged_ebpf_enabled(void)" are in the "#ifdef
CONFIG_BPF_SYSCALL" section of include/linux/bpf.h.
I think the one returning false should be in the #else section.


-- 
Regards
Sudip