Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Mar 2022 12:32:30 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     =?iso-8859-1?B?zfFpZ28=?= Huguet <ihuguet@redhat.com>,
        lkp@intel.com
Cc:     rajur@chelsio.com, kbuild@lists.01.org, lkp@intel.com,
        kbuild-all@lists.01.org,
        Linux List Kernel Mailing <linux-kernel@vger.kernel.org>
Subject: Re: drivers/net/ethernet/chelsio/cxgb4/sge.c:2571
 cxgb4_ethofld_send_flowc() warn: missing error code 'ret'
Message-ID: <20220310093230.GC3315@kadam>
References: <202107070458.FO35EqwU-lkp@intel.com>
 <CACT4ouey2QXf=PJThXG8adrLmCet4Ptu+VDDKBy2hOARqsghXQ@mail.gmail.com>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CACT4ouey2QXf=PJThXG8adrLmCet4Ptu+VDDKBy2hOARqsghXQ@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?2fArtcKwqpmeujC40Z6Kez38cTZl7JCy3yigypDd/FFgi1fflS4kExbARM?=
 =?iso-8859-1?Q?9zv5tProRpgtiSnlex5GSeTvtU43jHUdbQ9fscU/GLjJTmyeQCK9b9hpHs?=
 =?iso-8859-1?Q?NSZEeAcQP4VEXGb/UbqG2VjE9FXJT9TpKztJ6OHrAVX9nSafjZCN5zqYAN?=
 =?iso-8859-1?Q?GZpA/xy9WCwSAcFnrKIP+qCmWYHe8Vh6KxpXG9moe0lnJyv+rGx5vVrhaN?=
 =?iso-8859-1?Q?a4i+aPCl5xpoOEv3A6n9QFqTqzv0tsVgYyB6et5KrZHdal/vvPEuiRbi2Z?=
 =?iso-8859-1?Q?Pic6h3coYnT6wW09cnds9Qg37vv9/+v1r+QehicJ41T2mkydnPXYZ6ZoAI?=
 =?iso-8859-1?Q?GKaR+Hpw/NDtN69Zz0sdh5wOrB6noO9LlW4O/4J3qXuk+tnLsOqDNIaqO1?=
 =?iso-8859-1?Q?SJ8F3QQzvUBUBkyuyNOo3HJ4+cGeJ134KlGyhNOitPg9DldXWDBFdUSkrs?=
 =?iso-8859-1?Q?8G542fPo1SUogbOyX8+NTyvhm7+B5TpRSs1dkpfnGMLglZtnzpTTmTAYya?=
 =?iso-8859-1?Q?yR/VV7ZZc1kbloEC5twRjEDVdb8xgoOtOV+upulejVF6crVSLFCv4/H2yW?=
 =?iso-8859-1?Q?CdLWpw0x15fSchIyc4m+N/4l8LoKQJioX8SsyAqkd6P4i5oNldYTHeEtpU?=
 =?iso-8859-1?Q?VaIKsVt5kFGiglp652nnoAcbfa9NG3Xikvd63/2ROuhVOarX/V3I+vucVa?=
 =?iso-8859-1?Q?XbT/H01hAzY4HDN8SvRFSnq+H5XzCdH3p73fxZ07F8dCHEp1xVdvn4G+2O?=
 =?iso-8859-1?Q?D7T0DKV+ekDWn/tM6LW8YqcvSuRJUBr84u1/xHSNKCcpVViOpMxya9p68w?=
 =?iso-8859-1?Q?v1xMrCDSJhD59DHx4magVXht3D0Dz6D96/+7X0L67ij2hkDvn1uVsHTOYC?=
 =?iso-8859-1?Q?K/dLtVjHkqfzwOWiXnBeHA63aTWI6nBsiR+Ipa64D78JGas9YVDquRfj0Q?=
 =?iso-8859-1?Q?q9jVGS6Lsdx5GeTkMqy8rqUsueyrt7ve6PiXcCWDeGACf1nLquJpMyLstp?=
 =?iso-8859-1?Q?WkwAjgoLpKhl4Eq0qw983QYQVzkFom4jZYXjBuR3uti4YNpnEdqZPOpWKj?=
 =?iso-8859-1?Q?LWtnf1yMk2LFZebRfej0TLBWAx+OiHXbaUSY/9wb2xbMaMcGkLx7CYhrmz?=
 =?iso-8859-1?Q?YATT6JbfUrHVKbt4r1zUqHsvieBpTjxnG63CPwoydoXTvZjvZG/WIzaoju?=
 =?iso-8859-1?Q?iMw8GbqkgE9BV1m1uVJzai/rPBL5sJdwQA9QPmCb8SvjtLvKZrAnTO4l+2?=
 =?iso-8859-1?Q?WBMCH3DychkeL/UQar3qoIyO6FJSu+ec59ejuw94FEcLbvXesZdY+aWOrM?=
 =?iso-8859-1?Q?cVR4TACklYuifSx8nHMdrgUSJjX3Dehk5HhetaMrkX91frP3wcj0N+3Qm2?=
 =?iso-8859-1?Q?3ItGN44GuSCkQfTvb72URdjGyOtdZTQgRqJxeZxt4kGFYvPzwmogzh3V5j?=
 =?iso-8859-1?Q?58kUy9R7kY+GqYQJP9k52ECeXyonXgldx6W+GCY9Y1TXlcC5BOHPEV2WHT?=
 =?iso-8859-1?Q?xR8ld54LurbXlQkwnA5hD0+4FEoxO4sObvIG/BgjN8aA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9efd8f67-ac2d-4dd3-0fe5-08da0278ed0e
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2022 09:32:42.5767
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: m5MGig8s+wJGJXgXfrGSauE2Xlc2hzbKI5H9XMGLhz3HrmUI4Op2NNu68BY2mwCI6Kkf5oZyLj4YStoER66H23U3nt8ZyqUyYZvWtQWnp1o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4536
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10281 signatures=692062
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0
 suspectscore=0 bulkscore=0 mlxlogscore=999 adultscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2203100049
X-Proofpoint-GUID: tX_6dNe9mvBeboQZYcvibXV22sKNDu_G
X-Proofpoint-ORIG-GUID: tX_6dNe9mvBeboQZYcvibXV22sKNDu_G
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Mar 10, 2022 at 09:00:58AM +0100, ??igo Huguet wrote:
> On Wed, Jul 7, 2021 at 9:37 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
> >
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git  master
> > head:   79160a603bdb51916226caf4a6616cc4e1c58a58
> > commit: 52bfcdd87e83d9e69d22da5f26b1512ffc81deed net:CXGB4: fix leak if sk_buff is not used
> > config: x86_64-randconfig-m001-20210706 (attached as .config)
> > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > New smatch warnings:
> > drivers/net/ethernet/chelsio/cxgb4/sge.c:2571 cxgb4_ethofld_send_flowc() warn: missing error code 'ret'
> 
> This was already reported here:
> https://lore.kernel.org/all/202107070458.FO35EqwU-lkp@intel.com/ 

To be honest, I saw that it was old, and I did wonder why the kbuild bot
was sending warnings from ancient code.

But at the same time, the code looked suspicious enough that I just
resent instead of investigating.  :P

With kbuild warnings, I always solemnly promise everyone that "These are
a one time email.  Feel free to ignore false positives."  Unfortunately
those promises are just lies to make people happy.

regards,
dan carpenter