Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Mar 2022 14:29:50 +0100
Message-ID: <s5hilsmey0h.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     huangwenhui <huangwenhuia@uniontech.com>
Cc:     perex@perex.cz, tiwai@suse.com, jeremy.szu@canonical.com,
        hui.wang@canonical.com, wse@tuxedocomputers.com, cam@neo-zeon.de,
        kailang@realtek.com, tanureal@opensource.cirrus.com, sami@loone.fi,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek - Fix headset mic problem for a HP machine with alc671
In-Reply-To: <20220310130301.22827-1-huangwenhuia@uniontech.com>
References: <20220310130301.22827-1-huangwenhuia@uniontech.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Thu, 10 Mar 2022 14:03:01 +0100,
huangwenhui wrote:
> 
> On a HP 288 Pro G8, the front Mic could not be detected.
> 
> Signed-off-by: huangwenhui <huangwenhuia@uniontech.com>

Thanks for the patch.  Most of the changes look OK, but one thing I
still don't get:

> +	case HDA_FIXUP_ACT_INIT:
> +		alc_write_coef_idx(codec, 0x19, 0xa054);
> +		msleep(80);
> +		snd_hda_codec_write(codec, hp_pin, 0,
> +			    AC_VERB_SET_AMP_GAIN_MUTE, AMP_OUT_UNMUTE);

Why this unconditional unmute is required for fixing the mic problem?


Takashi