To: trond.myklebust@fys.uio.no
CC: akpm@linux-foundation.org, staubach@redhat.com, hugh@veritas.com,
       linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
       linux-kernel@vger.kernel.org
In-reply-to: <1172083004.9108.6.camel@heimdal.trondhjem.org> (message from
	Trond Myklebust on Wed, 21 Feb 2007 13:36:44 -0500)
Subject: Re: [PATCH] update ctime and mtime for mmaped write
References: <E1HJvdA-0003Nj-00@dorka.pomaz.szeredi.hu>
	 <1172081562.9108.1.camel@heimdal.trondhjem.org>
	 <E1HJwCl-0003V6-00@dorka.pomaz.szeredi.hu> <1172083004.9108.6.camel@heimdal.trondhjem.org>
Message-Id: <E1HJwXe-0003bD-00@dorka.pomaz.szeredi.hu>
From: Miklos Szeredi <miklos@szeredi.hu>
Date: Wed, 21 Feb 2007 19:50:14 +0100
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1216
Lines: 31

> > > > This flag is checked in msync() and __fput(), and if set, the file
> > > > times are updated and the flag is cleared
> > > 
> > > Why not also check inside vfs_getattr?
> > 
> > This is the minimum, that the standard asks for.
> > 
> > Note, your porposal would touch the times in vfs_getattr(), which
> > means, that the modification times would depend on the time of the
> > last stat() call, which is not really right, though it would still be
> > conforming.
> > 
> > It is much saner, if the modification time is always the time of the
> > last write() or msync().
> 
> I disagree. The above doesn't allow a program like 'make' to discover
> whether or not the file has changed by simply calling stat(). Instead,
> you're forcing a call to msync()+stat().

Yes, but that's the only portable way _anyway_.

And it probably doesn't matter, programs using mmap to write to a file
_will_ call msync, or at least close the file, when they're done.

Thanks,
Miklos
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/