Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220302171816.1170782-1-kvigor@gmail.com> <20220302171816.1170782-2-kvigor@gmail.com>
In-Reply-To: <20220302171816.1170782-2-kvigor@gmail.com>
From:   Miklos Szeredi <miklos@szeredi.hu>
Date:   Thu, 10 Mar 2022 11:27:45 +0100
Message-ID: <CAJfpegvpKKO-dFg7P8fERq5-BcQSC7uh2cYzz-Ufo7wHvnvv9g@mail.gmail.com>
Subject: Re: [RFC PATCH 1/1] FUSE: Add FUSE_TRUST_MAX_RA flag enabling
 readahead settings >128KB.
To:     Kevin Vigor <kvigor@gmail.com>
Cc:     linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, 2 Mar 2022 at 18:18, Kevin Vigor <kvigor@gmail.com> wrote:
>
> The existing process_init_reply() in fs/fuse/inode.c sets the ra_pages
> value to the minimum of the max_readahead value provided by the user
> and the pre-existing ra_pages value, which is initialized to
> VM_READAHEAD_PAGES. This makes it impossible to increase the readahead
> value to larger values.
>
> Add a new flag which causes us to blindly accept the user-provided
> value. Note that the existing read_ahead_kb sysfs entry for normal
> block devices does the same (simply accepts user-provided values
> directly with no checks).

read_ahead_kb only allows root to open for write.  Allowing non-root
arbitrary read ahead window size is not a good idea, IMO.

Thanks,
Miklos