Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220309145052.219138-1-sxwjean@me.com> <20220309145052.219138-3-sxwjean@me.com>
 <YijHr+kkp2bPE1dA@casper.infradead.org>
In-Reply-To: <YijHr+kkp2bPE1dA@casper.infradead.org>
From:   Xiongwei Song <sxwjean@gmail.com>
Date:   Thu, 10 Mar 2022 09:17:54 +0800
Message-ID: <CAEVVKH-an5XO7a3kVJ_fRhqAcMR-2TEnSd5mmWQPqHpnOduAZw@mail.gmail.com>
Subject: Re: [PATCH 2/2] mm: slub: Delete useless parameter of alloc_slab_page()
To:     Matthew Wilcox <willy@infradead.org>
Cc:     Xiongwei Song <sxwjean@me.com>, Christoph Lameter <cl@linux.com>,
        Pekka Enberg <penberg@kernel.org>,
        David Rientjes <rientjes@google.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Vlastimil Babka <vbabka@suse.cz>, longman@redhat.com,
        guro@fb.com, linux-mm@kvack.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Mar 9, 2022 at 11:29 PM Matthew Wilcox <willy@infradead.org> wrote:
>
> On Wed, Mar 09, 2022 at 10:50:52PM +0800, sxwjean@me.com wrote:
> > From: Xiongwei Song <sxwjean@gmail.com>
> >
> > The parameter @s is useless for alloc_slab_page(), let's delete it.
>
> Perhaps we could add a little more information here.
>
> It was added in 2014 by 5dfb41750992 ("sl[au]b: charge slabs to kmemcg
> explicitly").  The need for it was removed in 2020 by 1f3147b49d75
> ("mm: slub: call account_slab_page() after slab page initialization").

Ok. Will update.

>
> Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>

Thank you.

Regards,
Xiongwei