Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Claudiu Manoil <claudiu.manoil@nxp.com>
To:     Miaoqian Lin <linmq006@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        "Y.B. Lu" <yangbo.lu@nxp.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net v2] gianfar: ethtool: Fix refcount leak in
 gfar_get_ts_info
Thread-Topic: [PATCH net v2] gianfar: ethtool: Fix refcount leak in
 gfar_get_ts_info
Thread-Index: AQHYNCGtN3clJ+D1hUuog5ZVB2MFSqy4NvOA
Date:   Thu, 10 Mar 2022 07:23:54 +0000
Message-ID: <AM9PR04MB8397C4159072C82CD99895EF960B9@AM9PR04MB8397.eurprd04.prod.outlook.com>
References: <e68aa1f1-233f-6e5b-21a6-0443d565ca65@intel.com>
 <20220310015313.14938-1-linmq006@gmail.com>
In-Reply-To: <20220310015313.14938-1-linmq006@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?a/bKKP85lFYDufIGqmKInUf9570uwt7uyOOuRAAyQUJxi+AGkt86GwWVrHsy?=
 =?us-ascii?Q?UZwOVuF2ucwMVTB8gcms+340+oDLgqOl8ycSmye2wYEbh0NG1tAj68RxSC6R?=
 =?us-ascii?Q?itdzJuLM7/eJqJqgIGPj7SH8ePyl84GyayMmGiEskG1ce3H2Lm1VnsVsRgRA?=
 =?us-ascii?Q?VkCvClMYE+8DkArYE+YN5W6rCQP+Im89thhS+c28fQ6y1kjSwukO1bvHCpJl?=
 =?us-ascii?Q?lpjB6/W5q6KJe0B80eydbfIf66kP4j9fAy7Hw10ZFQHzBPMerfzK0dSLv3Ue?=
 =?us-ascii?Q?6SkkRv3tBM77+zbDtCi/vNl4ht20ZRC+2J1obzf0rcMGnSxwCY1nsQ8xH/du?=
 =?us-ascii?Q?wGgdV7Nhmi2pNEBZAbeBVxUiAwva5FIVxWy11nPY3LOa51tdlewiq6QJRPMU?=
 =?us-ascii?Q?i3PfhpQZ7yViIHCL/7GkJUPMqW2iLzmY4DnMLEIjgmrGrfMQUMm2uihr18Ak?=
 =?us-ascii?Q?3pECpRBdl+4Dqy7jCNQ6cpyAsnzkGPHuNYk1JgWBRc3p7qB1/c6fx9wN/cKM?=
 =?us-ascii?Q?sVk5Dtw+P18LH0h/RC+gnRiWSL3Cdot14HnIzwtv+e8Zm4Yv9T3ZnKFB+6L9?=
 =?us-ascii?Q?vpqmRm98wkKLy5Sa1S2M6HPuFk5a3bsoTMHiFu4h5HIUwWzrKDGVEqrzuc/L?=
 =?us-ascii?Q?9So72OuahuVwxxpxlClMQE7j+PC6v0vdr9hTDBDxJu+Lhzbr8joBOmNeTwe8?=
 =?us-ascii?Q?yxAumJyyqL1j/fe+JXUirkIUSq5xEDOpqxXo37NrOEFILE09WTolKxGR1cPL?=
 =?us-ascii?Q?CDBOSjVj4Bcb9Fo8YqeS18thHDsXA5O0LKlMg2vJSDACIExPc2oscMKJwPCI?=
 =?us-ascii?Q?mcYF31td7PEejgzk44KeVPmCQ3mgP2ChYzHn8g8Hfa5gMkzCFa6wNKN3M2fV?=
 =?us-ascii?Q?H6qeNpajBXmzUugOsLn1sawF//Y+5aWvTwy6RmWR5yjbjmXj2q4keje/5gpr?=
 =?us-ascii?Q?inrbLQY1FMqLWGDVubhqRpUOc/3Cao264KUz7zZGDy3hcOkh6kYdWLxvjB0V?=
 =?us-ascii?Q?q1TLcW+mnT6ZdLlyc8HidQWGWS3aR/CEKE9HNLiIIt5oLlBi0BOLzBL9ahyv?=
 =?us-ascii?Q?+3Sj6fhBtSmz+V2EqKAaaNglAFOXXh4OrMn534bVfkk0UUNbg5B2IfWnC0wM?=
 =?us-ascii?Q?hW2DadXPSfIIyHMrL89Ze75EoK5UXzF50JbuLrxnyDGikdbNncQXz8lQQwqV?=
 =?us-ascii?Q?iAYU3xLaT9iKp820QpMNjbcseug5jZUPajD+pTHozPdSp7ZhFMZZqkUOfnyV?=
 =?us-ascii?Q?ilRBvZGfzBzKVtdNhY8dJAUYGjS54IBrcKLlbmt8qSFM/yUQkFTXKwmzsDFi?=
 =?us-ascii?Q?AZRFybncIPvlExP6xQWBsmo7QPuKzo4vp2suy5mH5jZYRFjbDgJE/gaL4RFJ?=
 =?us-ascii?Q?WaeE3QL7sZXrgFY4VtctyYmC+jS+RZJgf8CXfXFCk1SZbMALnMNnBSVrE7zV?=
 =?us-ascii?Q?WuSWe4nhUrJ/q4+w4+V4V9u/inlk1urY4Hg6ixJx9hoC1lm08FfCw+zPXlTQ?=
 =?us-ascii?Q?L06Ms7cY+79o0wBJqOuNB3xbC6Zwi/1AmGtZit7ZojUGXlQSa1L1uppiFjHq?=
 =?us-ascii?Q?QUGfCg1wW+de7gYIEE3cmObSI0ICcOZOgdykd+GJW0VRKkDMxuIzIkjNm/2g?=
 =?us-ascii?Q?ekEpJE82WBxv980MgQ7qkg4=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8397.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 16ff4231-b2aa-4223-d5ea-08da0266ef42
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Mar 2022 07:23:54.9463
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3UK6MUASn5Rg1hkMZ6RA1ior6gLH7MOBEEuksPItKPu2DE6HqT+MwkUG/zIR5h/0QKhbGAQBnSEWhy43pNUjYQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5268
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Miaoqian Lin <linmq006@gmail.com>
> Sent: Thursday, March 10, 2022 3:53 AM
> To: Claudiu Manoil <claudiu.manoil@nxp.com>; David S. Miller
> <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>; Y.B. Lu
> <yangbo.lu@nxp.com>; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: linmq006@gmail.com
> Subject: [PATCH net v2] gianfar: ethtool: Fix refcount leak in gfar_get_t=
s_info
>=20
> The of_find_compatible_node() function returns a node pointer with
> refcount incremented, We should use of_node_put() on it when done
> Add the missing of_node_put() to release the refcount.
>=20
> Fixes: 7349a74ea75c ("net: ethernet: gianfar_ethtool: get phc index throu=
gh
> drvdata")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> ---
> changes in v2:
> - Fix the subject
> ---

Reviewed-by: Claudiu Manoil <claudiu.manoil@nxp.com>