Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e68aa1f1-233f-6e5b-21a6-0443d565ca65@intel.com>
Date:   Wed, 9 Mar 2022 12:19:03 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.2
Subject: Re: [PATCH] ethtool: Fix refcount leak in gfar_get_ts_info
Content-Language: en-US
To:     Miaoqian Lin <linmq006@gmail.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Jakub Kicinski" <kuba@kernel.org>, Yangbo Lu <yangbo.lu@nxp.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20220309091149.775-1-linmq006@gmail.com>
From:   Jesse Brandeburg <jesse.brandeburg@intel.com>
In-Reply-To: <20220309091149.775-1-linmq006@gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cHNlaVN2cXhaWFgrS1VoaTlQVWdqbU5ISmEzRzFVYWlodGZqbmNFNkZsc3Nv?=
 =?utf-8?B?RjJ2cGNTYW5ybnZ2U0xPV25QTUxNeUNHcHkrWG9EbCtTTVdHRHZyU0RWK0pm?=
 =?utf-8?B?SHdBVm95UmNiMHhRSG1IKzFINHlWaTdCbjcvRmxUWStOdjNDL0U4ZmpjVTdp?=
 =?utf-8?B?cFh3QlhHbXR2L3FNdHRHWHhHUWI1RHRBOXFkOFk4RTcwZlU1cE0vUTZBQms0?=
 =?utf-8?B?blBLMVBVQm81YkxieG5WL2hnYUI1SUZISjJMWFNwRzgwTzJ2MkRmWW5sTE11?=
 =?utf-8?B?c1RWOFhXdGlHeFdDczdyUGU4QlM2U1FxbTFGNkdweG5yODAvUC92cjVXRHVo?=
 =?utf-8?B?VEd5b0F2eGM2RWNnRkdVTzZCeTA2Tk14THRabFJPOXZOY1pRUTRUUlJJc0FX?=
 =?utf-8?B?ZlFqSlRtMVQxQlI3K1FiSlBGT1p2TGtLUFQvSXZ0OWppRnptdzYzV0Z3dERX?=
 =?utf-8?B?bmxaRWhtTU1HQmlLNW1BK251aUdKajJURExCVkl2aHFxTTF1a1RKaEhoWEJq?=
 =?utf-8?B?SlNCL1lKYWsvMHhOamxVZ1lucERaUzhoUTM5UTZiTnl5Q1l5aGFESEhiS2ZW?=
 =?utf-8?B?MGZWNlZCaXJZR3JuQ3R1Ykc4eEZ0dVNjK2NLRDdEMndQRFVvZmV2aWkrMWtk?=
 =?utf-8?B?Um9FS0RQbW1CMTlvL1lzTWRoc0dJRWFKY3RlaGRPRTNtY3N6eGhjbVN2SHE3?=
 =?utf-8?B?TnVQQldSbGdTaVR1U25EUzJ3VmNsMUMyb29wQTh4R1B3dE12ajFTZEduQnhq?=
 =?utf-8?B?SlYwMmlBdFZoN3MyQTBobXdnWnJRYWFWWGZ3cEtBUUErNFR2VFZ1RlhNdXFa?=
 =?utf-8?B?VjUybUxpYVg5bVVzVzFCdXRuOEVkdFg3a0dmRGoxZ2owNHgzNWh6bVA2RUZN?=
 =?utf-8?B?NWJmN3ZkUHdoOTJNdnBFQjFxQUozOXdtb1QzeVF1dmsyaUJiMC9SaG9wb3ZX?=
 =?utf-8?B?T3hFdkh6OUVNdVQ4M1dMSTV0Q2kxdWI4V3VGMXh0bmFINUZtV0FINU1hZ3lK?=
 =?utf-8?B?cTRFN3JQajlKNmVncVZuNVBLOHNyMlAvVEhqTGFZK3dveUllU282bngwOFkr?=
 =?utf-8?B?VlZ4MmdCWFk3OUtUWTBmTTlmMHYzWGY0MFZ2WkkreHRYZlorNmhuQ251cGNX?=
 =?utf-8?B?QWxiR1NlZDBvemY3K3VpWnVXMnlnd1o4Y2VUL1pXTzlHVE1YNStpMHRBdFJv?=
 =?utf-8?B?eVU2RFoyYWI1M2pxcjc4bGpqVis2dmZTT2xvNEVDSkRTYjkwN0tVcWpkM0dT?=
 =?utf-8?B?NUwvQ3JRYnZBeDlhdTd5NDNKSkNrNS8wc0lIUmtQcnpIVG1HQklUWWErZllz?=
 =?utf-8?B?SG5CYWM2Ylk5R0NFNk5Xd1hXRitHNWFzb3k3aUVRc1B5UGFTUDI3aUFBV1B4?=
 =?utf-8?B?d2VRWTBDeXdYcjZFVVIxbmpyWDU3Qm05WHdjcVQrVjQ4QjVxVm5DbFExWE5h?=
 =?utf-8?B?TFg4TDc1YkpNVjF2SERFWnFPOEsrREh2elFYMmNCdk9RK2FTSVFNQi9GU3V5?=
 =?utf-8?B?OW5iVzMxakR1aGoxREZrcFBQZ015TGtRYmxMTktmZ3BiNnNvdnVVUzcwK2Q5?=
 =?utf-8?B?cUVTRnB5U0hTR0pIakNJeExYYkVTdndoV0w4b29lYkRpZDBsWWJUaHF4NUEw?=
 =?utf-8?B?cnZLTFc2SFg4aEMzaDhHcXhvbnlmcUY3Vm1ZSmxIYVVTLy9xU0dHalRmbWRz?=
 =?utf-8?B?Nm9yRUV5WlhxUWlVODhYZ3RKcG9UcWVrSXZMMi9ON1V1MVE0bFRoT1NnUzBm?=
 =?utf-8?B?NXpscDllblBUb2NTV1pVcXI4VGdDYlNKRjh3T0lHVVlmQ3Y3VkZYcWVSZGV2?=
 =?utf-8?B?N1BqWjg0SUJaK1FhUWdGRFpZOHFUOXkvdFNlZ2pRVHk0WHZzWVJpNC9SeURr?=
 =?utf-8?B?T2R5aDBIaUZTeHBPak1rSnlIbG5jNDhGRTZ3MXE4Uzh3UWpTbHJBYlpqUHRU?=
 =?utf-8?B?THRBZWtwQTZpejFGZm9OUUZBSE5IMlNnSjFEY1c5S09GVHJZMkpicTRoL0N2?=
 =?utf-8?B?UUxvaFJDYm8yQUVzQUxhVTlWTkF4azRFTVU5bVJzbEYwSzdDR0NUMEhzWlF6?=
 =?utf-8?B?bWJHQmFhRjBGbU5MeERSTFFqclg5NEVBRFREbmhsT1FrbUtnY3NkLzVsZ0p2?=
 =?utf-8?B?MFByQUZLbnJqb081SGZxc0xFQjFsWWNmOUR2Y3FaZTNFSmtXdnFIZ0UxVitP?=
 =?utf-8?B?STlCY2NjZVEwT2NienJTeHkxdXcxcjJsckFoNHdEQzU4YlpqUi91WDJzbTJ1?=
 =?utf-8?Q?pDkpJrdaGd4gjCLmX8JGdIglxgrDV2AFL4F9YHxnQk=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e7fb3b8d-f80f-40e0-038d-08da020a0f63
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4914.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2022 20:19:05.8817
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: T8rRdWUBmIaxbVk2KOhpyTdw958Ar/exa//NY6LWlcHQOtJFa+eN5gw2ZHaCIsyOYYcJQ025uB096agqJePQPfjriX6+JlJjXzVHGqw0I/A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3371
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

 > Subject: [PATCH] ethtool: Fix refcount leak in gfar_get_ts_info

should be:
[PATCH net v2] gianfar: ethtool: Fix refcount leak in gfar_get_ts_info

On 3/9/2022 1:11 AM, Miaoqian Lin wrote:
> The of_find_compatible_node() function returns a node pointer with
> refcount incremented, We should use of_node_put() on it when done
> Add the missing of_node_put() to release the refcount.
> 
> Fixes: 7349a74ea75c ("net: ethernet: gianfar_ethtool: get phc index through drvdata")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
>   drivers/net/ethernet/freescale/gianfar_ethtool.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/freescale/gianfar_ethtool.c b/drivers/net/ethernet/freescale/gianfar_ethtool.c
> index ff756265d58f..9a2c16d69e2c 100644
> --- a/drivers/net/ethernet/freescale/gianfar_ethtool.c
> +++ b/drivers/net/ethernet/freescale/gianfar_ethtool.c
> @@ -1464,6 +1464,7 @@ static int gfar_get_ts_info(struct net_device *dev,
>   	ptp_node = of_find_compatible_node(NULL, NULL, "fsl,etsec-ptp");
>   	if (ptp_node) {
>   		ptp_dev = of_find_device_by_node(ptp_node);
> +		of_node_put(ptp_node);
>   		if (ptp_dev)
>   			ptp = platform_get_drvdata(ptp_dev);
>   	}

If you fix the subject and resend a v2, you can add
Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>