Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 9 Mar 2022 22:31:32 +0000
From:   Yazen Ghannam <yazen.ghannam@amd.com>
To:     Borislav Petkov <bp@alien8.de>
Cc:     linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
        mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com,
        rric@kernel.org, Smita.KoralahalliChannabasappa@amd.com
Subject: Re: [PATCH v4 18/24] EDAC/amd64: Define function to insert CS ID
 into address
Message-ID: <YikqxFfS9qrLLXM4@yaz-ubuntu>
References: <20220127204115.384161-1-yazen.ghannam@amd.com>
 <20220127204115.384161-19-yazen.ghannam@amd.com>
 <YgpUc7J2/4+n2oMv@zn.tnic>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YgpUc7J2/4+n2oMv@zn.tnic>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FBA5bsHDcQ1vOtwInLHJhQ/v26JWJxg237rqhQpBDr6pSmxGXai0Lw2Z92iB?=
 =?us-ascii?Q?te2pi6Zc0tZvJl7SncEZv5Vy3j7UgoLxfp/qXqIiaa3LjkbWGL3PEbB7aQej?=
 =?us-ascii?Q?pOB/FKUivM4Ecz/TztpbWF2QLHp+8cRhb+VHdZNMOazWuYDB/E/zUGagOdBG?=
 =?us-ascii?Q?lVIO1EMCfIE1x4KSkxiXT15tm7C8eV9ijPVhC5Mg6c8d+lU2nXDS+dCeKb1C?=
 =?us-ascii?Q?ib3T7sBd40Kxmx7k+D0U/2Id057tLKz8i4nW8HFGSyEC1Zk5xt5+VtYzVCx7?=
 =?us-ascii?Q?dd2CX8boqPBku9EvBGLKDJD5vsI4TAhSq6mhTxmpELH+8gK1FSCKE+7W7duz?=
 =?us-ascii?Q?PzilFo2Eb2ZrMwgKeeT7tYvHbIRwU9rkGVKUbfD/5D3xHhbgwDz1cI2ew2Id?=
 =?us-ascii?Q?cq95KNYw6QxzRoCQFjOrM0+fNKjxQm5DDjrIzxn2TQf1srXgX7Ui7FZoypzr?=
 =?us-ascii?Q?OgWc1kxgbtplTN6O3tusoZuA1e4wSfz8LdqrLm+y/iNBxIApgzX5z7Sd837D?=
 =?us-ascii?Q?tzgy5/Qe7PNcnrLjvSK9IKxcRChOPnGJqf3LybDOYTeUDS70/YvkoS4wQ6FM?=
 =?us-ascii?Q?1lFwr+uoSnsm9gK4j9Oy1OOgEYp3p5oMquIHRS9JAEriEQ2dMQy3VO3kxxbA?=
 =?us-ascii?Q?2hibmx65jF1XyYCXrikI6VMgkbv1PvGEfBDSEyyYR6MxEV3Jpve2FmaWUOk+?=
 =?us-ascii?Q?kEZjXIR8rSmebqQCiqMgnd5cQ957nJDYmVgsTi4QPMDb2o0xpAMoUlP+3AqK?=
 =?us-ascii?Q?gfMdCj4JyQx4aDyvwwIn5vU/OAtApN+M1lJRbV5M6YG3JHOUFlENvQ7lH4LT?=
 =?us-ascii?Q?gReUy0kz+QikDOpLWau9Mrhbbm3C8j2iwGGJ1bVImEd8/JRWo3oLdrVoxdo8?=
 =?us-ascii?Q?hCfJt3uLrEhHF9eT3tqpUCpfuqBKqMCi9qNHw2poqAvP7kJ9U1T0gbENzS2f?=
 =?us-ascii?Q?igmROc8JihftoWlZ6wBWRCPdQb3mruV+4SKA2s2sHM8nlQNne7QyvyOae+sa?=
 =?us-ascii?Q?oZ9Unnq2retMotYQ8OGWetS+/go01N5d4a7sIc7lyyx8qncRFc25ex8KTw/d?=
 =?us-ascii?Q?FtflJ0LWFC2lC2rnfVhRz6BYTu+CyOMlOzrImlPMxSN0IuEWHAWLVBW2QEAR?=
 =?us-ascii?Q?F5JMx2VsRdVMv7JobYfiaiwGNgWUCVkctocg6VnwY7+KPUL2cGu30ymhohRA?=
 =?us-ascii?Q?J0eTcbLmebDxV7qboh99Y+tfXNOKh66+xtavGe0PObBvDFG628D5kLm1gUF6?=
 =?us-ascii?Q?rtOVJzaPYT2tdFGA/SQR+Ujp89USkPUz18YHu9yuTw2yOSGnbrZuI9hYy5G4?=
 =?us-ascii?Q?nyv2OENsAtILTSjStA/dR7OlAW4HFjts8uzDAEyJEB8wmT/ULWRIblWa09nb?=
 =?us-ascii?Q?ojgKCWV2lPABaq3BsD4PctI3fqufujjNQUYS33rUqrB9UqZcnzrhJ0C5qP8B?=
 =?us-ascii?Q?dRAWmN+ygKiS2tIXfLQGdoQRaU/Hg7Hu?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8b0a7bd8-9412-464a-ea27-08da021c927c
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2022 22:31:36.7283
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wpFGTiC2tgSM9vfMPZlSci46uW7GmTt2Us+ySm1PvTJ8vBg0S1s83MHhlPKxpR3/vGE1I1kiFdbwAO20WhPTOQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5137
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 14, 2022 at 02:09:07PM +0100, Borislav Petkov wrote:
> On Thu, Jan 27, 2022 at 08:41:09PM +0000, Yazen Ghannam wrote:
> > @@ -1326,20 +1331,7 @@ static int denormalize_addr(struct addr_ctx *ctx)
> >  		return -EINVAL;
> >  	}
> >  
> > -	if (num_intlv_bits > 0) {
> > -		u64 temp_addr_i;
> > -
> > -		/*
> > -		 * The pre-interleaved address consists of XXXXXXIIIYYYYY
> > -		 * where III is the ID for this CS, and XXXXXXYYYYY are the
> > -		 * address bits from the post-interleaved address.
> > -		 * "num_intlv_bits" has been calculated to tell us how many "I"
> > -		 * bits there are. "intlv_addr_bit" tells us how many "Y" bits
> > -		 * there are (where "I" starts).
> > -		 */
> 
> That comment looks useful, why remove it?
>

No firm reason. I just got the feeling it wasn't very useful. But I'll keep it
in case others find it helpful.

Thanks,
Yazen