Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp1491106pxp; Thu, 10 Mar 2022 06:31:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJxRWWB7sx5rWTsvYG0Eszu0+t71iuWebxigp3FTs2KHV6xqAtVP3dT2je0TNW4aIbxW8ROi X-Received: by 2002:a17:906:5d12:b0:6db:8b63:f17 with SMTP id g18-20020a1709065d1200b006db8b630f17mr1996316ejt.194.1646922704276; Thu, 10 Mar 2022 06:31:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646922704; cv=none; d=google.com; s=arc-20160816; b=hubWSPzwuKeDAOH1Kl8gtyE9jUp7VYJVyHIHjZ8o7ACgZxDzQbz3JlQJhd/w+LE7p9 EKUt9cIy524Ip7hMItHebipGfQ1p3wbFB/pX7/qYJVOMoB3qcQ3aeGacUxNDSnQB02xB 2DPSFVtq1CSN+7+APQU2XJQfzB0pq9riuiX9XVGEX9qimocP80XUvt6ikaVvCnKSYWBJ zT4oyyii0v43E0Fb+HyeCEOXfzNESqEChmPbpsmmrY7sI3vXHhnfWeYi9WM8vbNx7cSg yH1fkTZjAa0o2fdMSMpOUZMJkeI0Hx/Nje44k/VVqcO7vmOi4zHwleOlOx1vYDCAu5YS 6AIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=6Wfvf+Q1dHpq5+onmxCyJ2OGjzL7oPxurPNJQLIqmfY=; b=gDM+Eg1CvHLwB4xuza/PaA+x2ybbISBXX2WjlEoQlU/uuKdDa1zhLKY2IcdBVmcz+U 75bUXIEIBLdSWQ8H6p4wRbi//X/hXmBTbkIv4NWo0tXdA4Wnp1OgR9GYhJdDdQJAkBO9 xGAkCSdpQeKNJrsciun1Bp1zmwu/M0cltY2+AonnXD5OKMxtJ9sBjzKQg2P17uMt7mMi xDQHcINNXqHFvAJuvEQ9hmda2WCjhLS+5IF37bIXlKbhrJ7OJaWGQP8AQcuPiBphUFi3 N5Q4ZjDpOmikgaz3ZirxOpK5Xe74D9fNyx326DOHUiL13UxprOJPSKu31EokQfXd//Dz byAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=i+lRW+f7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r24-20020a170906549800b006cfcff2e235si3234658ejo.336.2022.03.10.06.31.18; Thu, 10 Mar 2022 06:31:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=i+lRW+f7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236012AbiCIS26 (ORCPT + 99 others); Wed, 9 Mar 2022 13:28:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233444AbiCIS25 (ORCPT ); Wed, 9 Mar 2022 13:28:57 -0500 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3834730F4F; Wed, 9 Mar 2022 10:27:57 -0800 (PST) Received: by mail-lf1-x12e.google.com with SMTP id r7so5318860lfc.4; Wed, 09 Mar 2022 10:27:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=6Wfvf+Q1dHpq5+onmxCyJ2OGjzL7oPxurPNJQLIqmfY=; b=i+lRW+f7oPWk7jcy7w1AalK8NE85rsaceNF0w2ytooHwol3fZIMtcywmIm+P0I2Vp5 b+JLJzp7IzP554e+1ELikmlo/Gm5zZfHmbcHfi3D0FUQgCwDpKPcQuPb1ymOTVWyMnXB xTBXt+q+wTmhmOP60lxSNUqgGwsYNMUCiMMJgCdS90sMovQkRNfygN59OyQ+k8wQhl38 m75RZeoyfKQIeIjB3hUJ1EH3DJTKX05/8ABd2dtgJ/lsqkIChoXJG9v+N5u6n4J81BSZ 6eZG5riskYhC23IYlbnclwaVdRRQ/m91DZgDlCl3pMmJGj5P52GWS9OrAfUCZS1YxlPq 2Byg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=6Wfvf+Q1dHpq5+onmxCyJ2OGjzL7oPxurPNJQLIqmfY=; b=BuZHNgVkiA24SLO8HX8BQT798vwzeDQlMGVQuMxAIzntqmwDmyg4m6WPlF5O0fuBB7 d0JKndl1dfA2e8hiyJ32zv9HIO9NZinZo2UEwPAgyNahMkJ+pZKnJ33/XN/v1vUcIci3 1uqwZLDUBRfDULsWAqTfdMFF5Mb0exo6QDJd1p5KOLqk5kpZKtnCQooxw9weoA3qdVYD K/79WtYdZAR1jb2JaOwbmHQiD95QwUsvSU48fVgsTr0CTyTpuGn5h58paBY7MKYOa1RY LtHfzEMfKfV96a9VJc1HfRBVWfz8czqkq3dgGTre984RPrVL/vJJ5aHp6hFzxlmLcAB2 oSYA== X-Gm-Message-State: AOAM5338V6Y5LhaQwAzljEXSSNSjFeenVZvGyrg2nVkDjgWxnX05aA5c dWPOLaLmVqhaGX7MQCIe3s0= X-Received: by 2002:a05:6512:33d3:b0:448:38e4:3088 with SMTP id d19-20020a05651233d300b0044838e43088mr556297lfg.272.1646850475308; Wed, 09 Mar 2022 10:27:55 -0800 (PST) Received: from [192.168.1.11] ([94.103.229.107]) by smtp.gmail.com with ESMTPSA id q26-20020a19a41a000000b004485b32c483sm210037lfc.192.2022.03.09.10.27.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Mar 2022 10:27:54 -0800 (PST) Message-ID: Date: Wed, 9 Mar 2022 21:27:53 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] NFC: port100: fix use-after-free in port100_send_complete Content-Language: en-US To: Krzysztof Kozlowski , sameo@linux.intel.com, thierry.escande@linux.intel.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+16bcb127fb73baeecb14@syzkaller.appspotmail.com References: <20220308185007.6987-1-paskripkin@gmail.com> From: Pavel Skripkin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On 3/9/22 12:52, Krzysztof Kozlowski wrote: > > > Reviewed-by: Krzysztof Kozlowski > > Thanks, this looks good. I think I saw similar patterns also in other > drivers, e.g. pn533. I will check it later, but if you have spare time, > feel free to investigate. > > Similar cases (unresolved): > https://syzkaller.appspot.com/bug?extid=1dc8b460d6d48d7ef9ca > https://syzkaller.appspot.com/bug?extid=abd2e0dafb481b621869 > https://syzkaller.appspot.com/bug?extid=dbec6695a6565a9c6bc0 > Thanks for reviewing and pointing out to these bugs! Will take a look With regards, Pavel Skripkin