Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 9 Mar 2022 22:03:26 +0000
From:   Yazen Ghannam <yazen.ghannam@amd.com>
To:     Borislav Petkov <bp@alien8.de>
Cc:     linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
        mchehab@kernel.org, tony.luck@intel.com, james.morse@arm.com,
        rric@kernel.org, Smita.KoralahalliChannabasappa@amd.com
Subject: Re: [PATCH v4 08/24] EDAC/amd64: Define function to check DRAM limit
 address
Message-ID: <YikkLnnQX3CJoi37@yaz-ubuntu>
References: <20220127204115.384161-1-yazen.ghannam@amd.com>
 <20220127204115.384161-9-yazen.ghannam@amd.com>
 <YgopjwgItEHPfFtF@zn.tnic>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YgopjwgItEHPfFtF@zn.tnic>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FAEIL11VuDpu+CjJ1lrBeZVlVH5zVv1qmOcq7zOJ1yXCS0pH4aVLWAMrqJtA?=
 =?us-ascii?Q?EXU161lfwj/jto/hgWQnn2rCBy+gX1I47H4VhF+f0uSSVaIxYlmFtcxTrd1j?=
 =?us-ascii?Q?yasklR9eqWkZf92N5k7ugz0EkZc7T5NdQ07hdmPBY47tfzg3f/X18//2IF1o?=
 =?us-ascii?Q?Ao/zNigYCAunYbMIo11to7Ps/KJcdXaiqrVKpGhA3uhQ2Npa3+s333kjZSrY?=
 =?us-ascii?Q?6I962tNDSf9ZtOGhauHF0rUCYLUFr5i9Jrh2X6woMUde32NfAL23p51eJaOx?=
 =?us-ascii?Q?od9ATNp2BYHAz9tvm2cCTtow0FIyaptZsRWxKiKTeCyhNM7CnaRUqS9kczwA?=
 =?us-ascii?Q?kStlaki1F6awvKg8U3sKPHCVemTAehxFOkgaNrGMx2kg6xwzrbRTe3yzrx7f?=
 =?us-ascii?Q?lNa0VKx6clMVOOEUVrpyClNxLw4XIni9xowdtASerJaD3EI+Aj0kcW874f+U?=
 =?us-ascii?Q?O7CchZDOzel+vG4um1OK7lyatGLfp6DvIfhEm4AdIcMRgDRNERjaEeKvXlkQ?=
 =?us-ascii?Q?gD7vFBMcUETVt380Xgshh6a/DvZ1DxSf61HPAZzJunTuhGnKYE2vDeYCqXhf?=
 =?us-ascii?Q?HZtSmTZSEH20leJg/CcT4h7xoVlUWA0BSDAtKNzxYkfIZ97DazX+E9m2+237?=
 =?us-ascii?Q?xpLjRgL+TetrA8ZUsZX8Qq5Hw1VqUf5J15Y5283oUsUWPrBZtw1Bfg9GW6MK?=
 =?us-ascii?Q?4MByCQO2K8Kj+bAwp9RQDjiTf23lcDcwavDrV5jsOL8vXp1T5KeqJ+Mq8pwl?=
 =?us-ascii?Q?47UF1q6P1YpSeX+sqao4kuMgaGv3AA5qXGiYTw+p0ceQSMElR8sSXcp34QER?=
 =?us-ascii?Q?up9HDbzIJSYVonM3Bpt9tmlETnbe66LMFGgCAWZUXFvFv1h+gLK4pu+XccDT?=
 =?us-ascii?Q?8VnszJ4HHTdeED8e6f9pavEHYI/jmFuDf+6BWfq7vMhk623tEaqn5UpQdIkG?=
 =?us-ascii?Q?3WQvQhFiamdbDVbazXHFP7lt+itB4Y5cJ1SuyBacNxfB/DW+owg8VKaWWYM1?=
 =?us-ascii?Q?kppKchYXAM6jGr8ts65NfclLmPvD7JIu1ys2EEMA+F8TfM7vMaAwH2m+pp9j?=
 =?us-ascii?Q?PX1LuxjSXcZJUD/HnYr6I3vo+cxDgJqwmS1aK7zV4cjZBjYvcv0kYq5gCiMp?=
 =?us-ascii?Q?2lHq/jpgL81EUx5wnKitlzWEShW2jR57DS3RUHLvottKgaDY1kwHm/kSqsRy?=
 =?us-ascii?Q?1TOZqce95P2rEw4QmrPc3BLfVPTwutekf7Kmu4OQtNV6xwzaYbXZpF/Aw40a?=
 =?us-ascii?Q?AYjNtgKZBFeZdS09lobenJ/jZdd2EP8gZI/fsYdSB2ppbeKBhImoA0mI6U0O?=
 =?us-ascii?Q?zMUx/rjF+bOmoj3dNuj+gmIwKw0Tg/QRbyKZqV5evWZ+wwxDMTm2GUmNroRJ?=
 =?us-ascii?Q?Q7Jze14redHm6Z3t/DPcrwpyQFnhW7VVfaD6wm7tP8lPT3y4NaZd0PJkT0Gk?=
 =?us-ascii?Q?J1gF0n4PxOCZ69J3QlP+FYW61IjaMkS5NWS5uUbB7oH7uUJ2r9otT4Sye3yr?=
 =?us-ascii?Q?QrYfb7OfQHZfNzIroh9YI+5R91kn5DZ8m3C0T2UdpTBr7STo7LrgakVrESwz?=
 =?us-ascii?Q?PUIkiW1ir6iiz9BFfe289MTqnSY+bHvQIFWGRkyPiqC3zf+fFRLl5OSmaXoD?=
 =?us-ascii?Q?+gg5u4anOQSbg5CYdmJ/Piw=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e5cffd86-a296-43ed-5292-08da0218a89a
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2022 22:03:35.9377
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XuM9X9LOeiUERJeveEuTkJrxgBrjSMp5ddHDvOP/Yp4/f/BcsdPXkEN4wkYlLTtdHbWw0/1F6ghZzGEr+xi+qw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB5020
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 14, 2022 at 11:06:07AM +0100, Borislav Petkov wrote:
> On Thu, Jan 27, 2022 at 08:40:59PM +0000, Yazen Ghannam wrote:
> > Move the DRAM limit check into a separate helper function.
> 
> You're still writing the "what" in commit messages - pls make a note to
> write about "why" you're doing a change instead.
> 
> Because I don't see why you're doing this. Because
> umc_normaddr_to_sysaddr() is supposed to call helper functions only?
> 
> Now if you had the "why" I wouldn't be wondering...
> 
> :)
>

Yes, you're right. I'll update this.

Yes, the goal is to break up the translation procedure into discrete
high-level steps.

Thanks,
Yazen