Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220304203756.3487910-1-ira.weiny@intel.com>
In-Reply-To: <20220304203756.3487910-1-ira.weiny@intel.com>
From:   Dan Williams <dan.j.williams@intel.com>
Date:   Wed, 9 Mar 2022 21:08:36 -0800
Message-ID: <CAPcyv4juDzD4W_xAff2CdTFzKQhqfFkn93Zo_4Mw23v+Rq=1+g@mail.gmail.com>
Subject: Re: [PATCH] fs/dax: Fix run_dax() missing prototype
To:     "Weiny, Ira" <ira.weiny@intel.com>
Cc:     Vishal Verma <vishal.l.verma@intel.com>,
        Linux NVDIMM <nvdimm@lists.linux.dev>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Mar 4, 2022 at 12:38 PM <ira.weiny@intel.com> wrote:
>
> From: Ira Weiny <ira.weiny@intel.com>
>
> The function run_dax() was missing a prototype when compiling with
> warnings.
>
> Add bus.h to fix this.
>

Always include the warning and the compiler in the changelog. I
suspect you hit this with LLVM and not gcc?

super.c has no business including bus.h. If the bots are tripping over
this a better fix is to move it into dax-private.h.