Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 10 Mar 2022 07:29:44 -0800
From:   Christoph Hellwig <hch@infradead.org>
To:     Valentin Kleibel <valentin@vrvis.at>
Cc:     linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        Justin Sanders <justin@coraid.com>,
        Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] block: aoe: handle device timeouts atomic-safe
Message-ID: <YioZaO21yingv0nD@infradead.org>
References: <07bafc71-a6d2-ad6d-4706-7c99047b3228@vrvis.at>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <07bafc71-a6d2-ad6d-4706-7c99047b3228@vrvis.at>
Precedence: bulk

On Thu, Mar 10, 2022 at 04:17:37PM +0100, Valentin Kleibel wrote:
> If an aoe device does not respond to any packet on the network layer within
> aoe_deadsecs, the driver tries to mark the device as down, fail all I/O and
> clean out the queue.

I think the problem is that aoe even tries to queue up request
internally. It really needs to switch to use BLK_MQ_F_BLOCKING and
stop queuing up the requests internall at all.