Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4078dca8-b5d7-7f84-5605-2f5a98563137@gmail.com>
Date:   Thu, 10 Mar 2022 00:22:08 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH] NFC: port100: fix use-after-free in port100_send_complete
Content-Language: en-US
From:   Pavel Skripkin <paskripkin@gmail.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        syzbot+16bcb127fb73baeecb14@syzkaller.appspotmail.com
References: <20220308185007.6987-1-paskripkin@gmail.com>
 <cbdd5e41-7538-6d8f-344a-54a816c6d511@canonical.com>
 <b46bfa75-2c87-61d9-c0fc-33efb2678f27@gmail.com>
In-Reply-To: <b46bfa75-2c87-61d9-c0fc-33efb2678f27@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/9/22 21:27, Pavel Skripkin wrote:
> Hi Krzysztof,
> 
> On 3/9/22 12:52, Krzysztof Kozlowski wrote:
>> 
>> 
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>> 
>> Thanks, this looks good. I think I saw similar patterns also in other
>> drivers, e.g. pn533. I will check it later, but if you have spare time,
>> feel free to investigate.
>> 
>> Similar cases (unresolved):
>> https://syzkaller.appspot.com/bug?extid=1dc8b460d6d48d7ef9ca

This one is crazy :) No logs from driver at all. Even can't find where 
probe failure comes from (or even is there any failures...)

>> https://syzkaller.appspot.com/bug?extid=abd2e0dafb481b621869

Looks like this patch fixes it.

>> https://syzkaller.appspot.com/bug?extid=dbec6695a6565a9c6bc0
>> 

This one is already fixed. Fix bisection is bogus, but this bug is not 
reproducible anymore.


With regards,
Pavel Skripkin