Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v3] media: st-delta: Fix PM disable depth imbalance in
 delta_probe
To:     Miaoqian Lin <linmq006@gmail.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Peter Griffin <peter.griffin@linaro.org>,
        <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <2a3b4095-7b63-4da5-d0fa-43ba86715504@xs4all.nl>
 <20220307080859.14475-1-linmq006@gmail.com>
From:   Hugues FRUCHET - FOSS <hugues.fruchet@foss.st.com>
Message-ID: <9d543059-2a3b-e5b2-59f2-30819d49b74b@foss.st.com>
Date:   Thu, 10 Mar 2022 17:32:32 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20220307080859.14475-1-linmq006@gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Miaoqian Lin,

Thanks for the patch !

Acked-by: Hugues Fruchet <hugues.fruchet@foss.st.com>

BR,
Hugues.

On 3/7/22 9:08 AM, Miaoqian Lin wrote:
> The pm_runtime_enable will decrease power disable depth.
> If the probe fails, we should use pm_runtime_disable() to balance
> pm_runtime_enable().
> 
> Fixes: f386509 ("[media] st-delta: STiH4xx multi-format video decoder v4l2 driver")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
> changes in v2:
> - remove unused label.
> changes in v3:
> - add err_pm_disable label and update related 'goto err'.
> - update commit message
> ---
>   drivers/media/platform/sti/delta/delta-v4l2.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/sti/delta/delta-v4l2.c b/drivers/media/platform/sti/delta/delta-v4l2.c
> index c887a31ebb54..420ad4d8df5d 100644
> --- a/drivers/media/platform/sti/delta/delta-v4l2.c
> +++ b/drivers/media/platform/sti/delta/delta-v4l2.c
> @@ -1859,7 +1859,7 @@ static int delta_probe(struct platform_device *pdev)
>   	if (ret) {
>   		dev_err(delta->dev, "%s failed to initialize firmware ipc channel\n",
>   			DELTA_PREFIX);
> -		goto err;
> +		goto err_pm_disable;
>   	}
>   
>   	/* register all available decoders */
> @@ -1873,7 +1873,7 @@ static int delta_probe(struct platform_device *pdev)
>   	if (ret) {
>   		dev_err(delta->dev, "%s failed to register V4L2 device\n",
>   			DELTA_PREFIX);
> -		goto err;
> +		goto err_pm_disable;
>   	}
>   
>   	delta->work_queue = create_workqueue(DELTA_NAME);
> @@ -1898,6 +1898,8 @@ static int delta_probe(struct platform_device *pdev)
>   	destroy_workqueue(delta->work_queue);
>   err_v4l2:
>   	v4l2_device_unregister(&delta->v4l2_dev);
> +err_pm_disable:
> +	pm_runtime_disable(dev);
>   err:
>   	return ret;
>   }
>