Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] bpf: test_run: use kvfree() for memory allocated with
 kvmalloc()
To:     Yihao Han <hanyihao@vivo.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        netdev@vger.kernel.org, bpf@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     kernel@vivo.com, toke@redhat.com
References: <20220310092828.13405-1-hanyihao@vivo.com>
From:   Daniel Borkmann <daniel@iogearbox.net>
Message-ID: <b611d5d6-fb8c-0c9d-ca12-7131765001ca@iogearbox.net>
Date:   Thu, 10 Mar 2022 16:23:52 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <20220310092828.13405-1-hanyihao@vivo.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

[ You have plenty of folks in Cc, just not Toke given b530e9e1063e, so added him. ;) ]

On 3/10/22 10:28 AM, Yihao Han wrote:
> It is allocated with kvmalloc(), the corresponding release function
> should not be kfree(), use vfree() instead.

nit: s/vfree/kvfree/

> Generated by: scripts/coccinelle/api/kfree_mismatch.cocci

Fixed up typo and added Fixes tag before pushing, thanks!

> Signed-off-by: Yihao Han <hanyihao@vivo.com>
> ---
>   net/bpf/test_run.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/bpf/test_run.c b/net/bpf/test_run.c
> index 25169908be4a..b7e1e5f61c50 100644
> --- a/net/bpf/test_run.c
> +++ b/net/bpf/test_run.c
> @@ -196,9 +196,9 @@ static int xdp_test_run_setup(struct xdp_test_data *xdp, struct xdp_buff *orig_c
>   err_mmodel:
>   	page_pool_destroy(pp);
>   err_pp:
> -	kfree(xdp->skbs);
> +	kvfree(xdp->skbs);
>   err_skbs:
> -	kfree(xdp->frames);
> +	kvfree(xdp->frames);
>   	return err;
>   }
>   
>