Received: by 2002:a05:6a10:413:0:0:0:0 with SMTP id 19csp1931725pxp; Thu, 10 Mar 2022 15:22:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJxlo1JFvu9kQcLJbIXR7AHbsuWcTC5eq3FhdE9a6dxbM9MQa4H8xfZm+4dW8n1skN3HaQ4a X-Received: by 2002:a17:90b:388e:b0:1bf:49ca:2fc0 with SMTP id mu14-20020a17090b388e00b001bf49ca2fc0mr18617659pjb.226.1646954539004; Thu, 10 Mar 2022 15:22:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646954538; cv=none; d=google.com; s=arc-20160816; b=MHC4oBNASoevjCc9VwGoUBvI5LImTAGt2GieGfc4ITUJ1fawnfzHsJVUjHw1Pk8kPu aPVBVwIJMLLBjU+0WydTEgoNFuOMkT5TgsLUdl9PQplLfbEzu14oic3aDDF2qMcC0NEw qb8Ps75Ueo1OTZNXMLP7SHOFR0JUnXsn+kB7nuUnYlYtPLvzrLOIU2YJg4Hp6voJ9Pyq AU7hMUcQd+ZbuwaUrXyPf0XQRlTISKkEbuuGS/GIS5WzDVu0d6V7iCiwlpnxS2K7XTmw qb5iXM4+pqZ4gZhukHXMM4V4YDtjjR5XqgNem2vEE+WdlIwXtdWaoe+SePq6IPUCHo+s 4lZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=x2kPz8wJBnQD5aYQdCtk9GrkdaCMe8zqB3loFrQV2Go=; b=kflkjWGzrbCuIh+GMzLKq2sk5d1qmMF6QJPETm6gYY0Js/QOzRY13pvooPOKN4ys1i sV/UsvE/mtYYo1HjG82E5WCtHadK6PWLFgwWC4QdxP52MnaRnpsl7K8RjBqlLSP8Lg0w FEFLDdApXBSmj7jlGOhO+duweqoR+AhV+1AZxszuRUWW1aytOK5keUruaCbHDVfHg9v4 wTG3yqLAfvfz4Q0pe1mLC8wtKHYJWs4zFseQCGMmFEePo3n+vfTX3d9fHFmY6Uhm9Ft8 1nZST4mq1jNzG86cmomFJb2vIJPLr6DA2SOJxYfiE95z9Q1TIdB44OI6/KcqvDEGHkHX zQzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gIX0JKfX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u21-20020a170902a61500b0014a421ec0cesi6581302plq.218.2022.03.10.15.22.01; Thu, 10 Mar 2022 15:22:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gIX0JKfX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245033AbiCJUoH (ORCPT + 99 others); Thu, 10 Mar 2022 15:44:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233044AbiCJUoF (ORCPT ); Thu, 10 Mar 2022 15:44:05 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99A4913C248; Thu, 10 Mar 2022 12:43:04 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 32128617C6; Thu, 10 Mar 2022 20:43:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34361C340E8; Thu, 10 Mar 2022 20:43:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646944983; bh=2X6X1LYtrX77vVoEtJ20iw6HueElnm3T45J6J+kFSug=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gIX0JKfXhZ9l8mvyXVN0RrwZk2rkkayVp1XwNj28i6eOvc8IA4LQs31F46jwT1oDn f0vyyn9wVXjlaNG2dI9lZI1x1K9uI1jbqSZBeN5RH3D7ix8eB2Di6AfB2mvt1V7+Uw c+uEF6WXqkDukHJhbNrM/lTN279wB4+2qUjLHJnYsmR/JkwTl3J0Vo4aTAIIn25BCT Y2Mfc1Ccps246X2hJEphlrI34oVM2uJYCp8yMkOuXWMu+xiQMrN3RtrzehOnpLZ8QV vU/11rq9xxmaY9QVWmxHdHE2CrPCyPzTucCQ92kgJ53C4Doomwy/Z/9ttVJCN9rmV2 wG842JEznPtjQ== Date: Thu, 10 Mar 2022 12:43:02 -0800 From: Jakub Kicinski To: Oleksij Rempel Cc: "David S. Miller" , Andrew Lunn , Heiner Kallweit , Russell King , kernel@pengutronix.de, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org, paskripkin@gmail.com Subject: Re: [PATCH net-next v1 4/4] net: usb: asix: suspend internal PHY if external is used Message-ID: <20220310124302.0ee9c7bd@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20220310114434.3465481-4-o.rempel@pengutronix.de> References: <20220310114434.3465481-1-o.rempel@pengutronix.de> <20220310114434.3465481-4-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 10 Mar 2022 12:44:34 +0100 Oleksij Rempel wrote: > + /* In case main PHY is not the embedded PHY, we need to take care of > + * embedded PHY as well. */ Another nit would be to move the */ to the next line like checkpatch wants us to.